OC package written even if not part of model

[mjreno]

Version: Commit d50342f
Recreate:

• comment out OC package in quickstart test_component.py test and then run the test

#oc = Oc(
#    parent=gwf,
#   budget_file=f"{gwf_name}.bud",
#    head_file=f"{gwf_name}.hds",
#    save_head=["all"],
#   save_budget=["all"],
#)

Result mymodel.oc:

BEGIN OPTIONS
END OPTIONS

BEGIN PERIOD
END PERIOD

Result mymodel.nam:

BEGIN PACKAGES
 DIS6 mymodel.dis dis
 IC6 mymodel.ic ic
 OC6 mymodel.oc oc
 NPF6 mymodel.npf npf
 CHD6 mymodel.chd chd0


END PACKAGES

BEGIN OPTIONS
END OPTIONS

Test fails when OC package is read for stress period 1. Note also trailing OPTIONS block in name file- maybe this is a separate issue.

[wpbonelli]

I think the root cause here is xattree makes dummy/empty components for packages not explicitly initialized. I don't know if that's what we want out of our backend, maybe better to leave them None. But if not None, I guess we need some kind of is_empty predicate the writer can use to determine whether to write the input file

Note also trailing OPTIONS block in name file- maybe this is a separate issue.

Yeah, would be good to raise separately, in general we want to omit empty blocks. And I also thought we could assume the order the writer processes blocks in would match the DFN block definition order but evidently not.

edit: now I see #231, cool