handle scalars, test component-specific parsing/transformation #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpbonelli
commented
Jul 23, 2025
| def arrays_vars(self, items: list[Any]) -> dict: | ||
| return {item[0].lower(): item[1] for item in items} | ||
|
|
||
| def r2d2(self, _: list[Any]) -> bool: |
Member
Author
There was a problem hiding this comment.
instead of hardcoding these in future, we can inject component class definitions into the transformer, and have a single hook which handles blocks, variables, etc as appropriate based on the class definition
wpbonelli
commented
Jul 23, 2025
| grammar = """ | ||
| start: block* | ||
| block: options_block | arrays_block | ||
| options_block: "begin"i "options"i options_vars "end"i "options"i |
Member
Author
There was a problem hiding this comment.
grammars like these, aware of the names/contents of blocks, and the names/types of variables, can be generated for each component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more progress on lark parser. demonstrate how generated component-specific grammars can build on a typed base grammar knowing about the various input formats (readarray, etc)