Commit 6504ed3
authored
This PR fixes 2 failures I missed while adding support for pandas 2.3:
- `DataFrame.insert` apparently is now typed with `pandas-stubs==2.3`,
but was not typed before. Since pandas 2.3 is compatible with Python 3.9
all CI runs should pick up this change, but if it continues to be an
issue I'll look into a workaround for seeing if it's possible to
conditionally add the `type: ignore` directive.
- `np.cumproduct` was
[deprecated](https://numpy.org/doc/1.26/release/1.25.0-notes.html#deprecations)
some time ago, and removed in numpy>2. We've supported numpy>2 for a
while, so it's unclear why this issue only just triggered.
Signed-off-by: Jonathan Shi <jonathan.shi@snowflake.com>
1 parent e3724b6 commit 6504ed3
File tree
2 files changed
+5
-3
lines changed- modin
- core/dataframe/base/dataframe
- tests/pandas/dataframe
2 files changed
+5
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
| 108 | + | |
| 109 | + | |
108 | 110 | | |
109 | | - | |
| 111 | + | |
110 | 112 | | |
111 | | - | |
| 113 | + | |
112 | 114 | | |
113 | 115 | | |
114 | 116 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
133 | | - | |
| 133 | + | |
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
| |||
0 commit comments