Commit 98c2207
authored
Prior to this commit, calling `DataFrame.eval(inplace=False,
engine='python')` with an assignment would incorrectly update the input
dataframe. The root cause was calling `copy(deep=None)` instead of
`copy(deep=True)`. We need to insert new columns to a deep copy of the
input dataframe. `deep=None` is not part of the `copy` API at all, so we
don't need to fix `copy()` behavior. It happens that `deep=None` does a
deep copy in pandas, which is where we got the `deep=None` code from.
Resolves #7669
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
1 parent 954550a commit 98c2207
File tree
2 files changed
+12
-1
lines changed- modin
- core/computation
- tests/pandas/dataframe
2 files changed
+12
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
381 | 381 | | |
382 | 382 | | |
383 | 383 | | |
384 | | - | |
| 384 | + | |
385 | 385 | | |
386 | 386 | | |
387 | 387 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
385 | 385 | | |
386 | 386 | | |
387 | 387 | | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
388 | 399 | | |
389 | 400 | | |
390 | 401 | | |
| |||
0 commit comments