Skip to content

Commit ba9a743

Browse files
committed
adns9800 does not take 16bit register writes
1 parent e870225 commit ba9a743

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

src/modm/driver/motion/adns9800.hpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,6 @@ class Adns9800 : public adns9800, public modm::SpiDevice<SpiMaster> {
239239
if (shutter_new.isValid()) {
240240
shutter_config = shutter_new;
241241

242-
// @todo waiting for #690 that brings 16bit Spi transfers
243242
writeRegister(Register::Frame_Period_Max_Bound_Lower, shutter_config.period_max & 0xff);
244243
writeRegister(Register::Frame_Period_Max_Bound_Upper, shutter_config.period_max >> 8);
245244

@@ -258,7 +257,6 @@ class Adns9800 : public adns9800, public modm::SpiDevice<SpiMaster> {
258257
shutter_config.period_max = period_max;
259258

260259
if (shutter_config.isValid()) {
261-
// @todo waiting for #690 that brings 16bit Spi transfers
262260
writeRegister(Register::Frame_Period_Max_Bound_Lower, shutter_config.period_max & 0xff);
263261
writeRegister(Register::Frame_Period_Max_Bound_Upper, shutter_config.period_max >> 8);
264262
} else {
@@ -272,7 +270,6 @@ class Adns9800 : public adns9800, public modm::SpiDevice<SpiMaster> {
272270
shutter_config.period_min = period_min;
273271

274272
if (shutter_config.isValid()) {
275-
// @todo waiting for #690 that brings 16bit Spi transfers
276273
writeRegister(Register::Frame_Period_Min_Bound_Lower, shutter_config.period_min & 0xff);
277274
writeRegister(Register::Frame_Period_Min_Bound_Upper, shutter_config.period_min >> 8);
278275
} else {
@@ -286,7 +283,6 @@ class Adns9800 : public adns9800, public modm::SpiDevice<SpiMaster> {
286283
shutter_config.shutter_max = shutter_max;
287284

288285
if (shutter_config.assert()) {
289-
// @todo waiting for #690 that brings 16bit Spi transfers
290286
writeRegister(Register::Shutter_Max_Bound_Lower, shutter_config.shutter_max & 0xff);
291287
writeRegister(Register::Shutter_Max_Bound_Upper, shutter_config.shutter_max >> 8);
292288
} else {

0 commit comments

Comments
 (0)