Skip to content

Commit e0a6e76

Browse files
committed
[driver] bmi270 fixes for PR review
[driver] bmi270 removed exti reverting to exti interface fifo without exti stupid fool fixes
1 parent f901265 commit e0a6e76

File tree

10 files changed

+137
-177
lines changed

10 files changed

+137
-177
lines changed

README.md

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -83,12 +83,12 @@ git clone --recurse-submodules --jobs 8 https://github.com/modm-io/modm.git
8383

8484
## Microcontrollers
8585

86-
modm can create a HAL for <!--allcount-->4003<!--/allcount--> devices of these vendors:
86+
modm can create a HAL for <!--allcount-->3991<!--/allcount--> devices of these vendors:
8787

8888
- STMicroelectronics STM32: <!--stmcount-->3240<!--/stmcount--> devices.
8989
- Microchip SAM: <!--samcount-->355<!--/samcount--> devices.
9090
- Microchip AVR: <!--avrcount-->388<!--/avrcount--> devices.
91-
- Nordic nRF: <!--nrfcount-->19<!--/nrfcount--> devices.
91+
- Nordic nRF: <!--nrfcount-->7<!--/nrfcount--> devices.
9292
- Raspberry Pi: <!--rpicount-->1<!--/rpicount--> device.
9393

9494
Here is a table with all device families and the peripheral drivers they support:
@@ -957,99 +957,100 @@ your specific needs.
957957
<td align="center"><a href="https://modm.io/reference/module/modm-driver-block-device-spi-flash">SPI Flash</a></td>
958958
<td align="center"><a href="https://modm.io/reference/module/modm-driver-bme280">BME280</a></td>
959959
<td align="center"><a href="https://modm.io/reference/module/modm-driver-bmi088">BMI088</a></td>
960-
<td align="center"><a href="https://modm.io/reference/module/modm-driver-bmp085">BMP085</a></td>
960+
<td align="center"><a href="https://modm.io/reference/module/modm-driver-bmi270">BMI270</a></td>
961961
</tr><tr>
962+
<td align="center"><a href="https://modm.io/reference/module/modm-driver-bmp085">BMP085</a></td>
962963
<td align="center"><a href="https://modm.io/reference/module/modm-driver-bmp581">BMP581</a></td>
963964
<td align="center"><a href="https://modm.io/reference/module/modm-driver-bno055">BNO055</a></td>
964965
<td align="center"><a href="https://modm.io/reference/module/modm-driver-cat24aa">CAT24AA</a></td>
965966
<td align="center"><a href="https://modm.io/reference/module/modm-driver-cycle_counter">CYCLE-COUNTER</a></td>
966967
<td align="center"><a href="https://modm.io/reference/module/modm-driver-drv832x_spi">DRV832X</a></td>
967-
<td align="center"><a href="https://modm.io/reference/module/modm-driver-ds1302">DS1302</a></td>
968968
</tr><tr>
969+
<td align="center"><a href="https://modm.io/reference/module/modm-driver-ds1302">DS1302</a></td>
969970
<td align="center"><a href="https://modm.io/reference/module/modm-driver-ds1631">DS1631</a></td>
970971
<td align="center"><a href="https://modm.io/reference/module/modm-driver-ds18b20">DS18B20</a></td>
971972
<td align="center"><a href="https://modm.io/reference/module/modm-driver-dw3110">DW3110</a></td>
972973
<td align="center"><a href="https://modm.io/reference/module/modm-driver-ea_dog">EA-DOG</a></td>
973974
<td align="center"><a href="https://modm.io/reference/module/modm-driver-encoder_input">Encoder Input</a></td>
974-
<td align="center"><a href="https://modm.io/reference/module/modm-driver-encoder_input-bitbang">Encoder Input BitBang</a></td>
975975
</tr><tr>
976+
<td align="center"><a href="https://modm.io/reference/module/modm-driver-encoder_input-bitbang">Encoder Input BitBang</a></td>
976977
<td align="center"><a href="https://modm.io/reference/module/modm-driver-encoder_output-bitbang">Encoder Output BitBang</a></td>
977978
<td align="center"><a href="https://modm.io/reference/module/modm-driver-ft245">FT245</a></td>
978979
<td align="center"><a href="https://modm.io/reference/module/modm-driver-ft6x06">FT6x06</a></td>
979980
<td align="center"><a href="https://modm.io/reference/module/modm-driver-gpio_sampler">Gpio Sampler</a></td>
980981
<td align="center"><a href="https://modm.io/reference/module/modm-driver-hclax">HCLAx</a></td>
981-
<td align="center"><a href="https://modm.io/reference/module/modm-driver-hd44780">HD44780</a></td>
982982
</tr><tr>
983+
<td align="center"><a href="https://modm.io/reference/module/modm-driver-hd44780">HD44780</a></td>
983984
<td align="center"><a href="https://modm.io/reference/module/modm-driver-hmc58x">HMC58x</a></td>
984985
<td align="center"><a href="https://modm.io/reference/module/modm-driver-hmc6343">HMC6343</a></td>
985986
<td align="center"><a href="https://modm.io/reference/module/modm-driver-hx711">HX711</a></td>
986987
<td align="center"><a href="https://modm.io/reference/module/modm-driver-i2c-eeprom">I2C-EEPROM</a></td>
987988
<td align="center"><a href="https://modm.io/reference/module/modm-driver-ili9341">ILI9341</a></td>
988-
<td align="center"><a href="https://modm.io/reference/module/modm-driver-is31fl3733">IS31FL3733</a></td>
989989
</tr><tr>
990+
<td align="center"><a href="https://modm.io/reference/module/modm-driver-is31fl3733">IS31FL3733</a></td>
990991
<td align="center"><a href="https://modm.io/reference/module/modm-driver-itg3200">ITG3200</a></td>
991992
<td align="center"><a href="https://modm.io/reference/module/modm-driver-iwr6843aop">IWR6843AOP</a></td>
992993
<td align="center"><a href="https://modm.io/reference/module/modm-driver-ixm42xxx">IXM42XXX</a></td>
993994
<td align="center"><a href="https://modm.io/reference/module/modm-driver-l3gd20">L3GD20</a></td>
994995
<td align="center"><a href="https://modm.io/reference/module/modm-driver-lan8720a">LAN8720A</a></td>
995-
<td align="center"><a href="https://modm.io/reference/module/modm-driver-lawicel">LAWICEL</a></td>
996996
</tr><tr>
997+
<td align="center"><a href="https://modm.io/reference/module/modm-driver-lawicel">LAWICEL</a></td>
997998
<td align="center"><a href="https://modm.io/reference/module/modm-driver-lis302dl">LIS302DL</a></td>
998999
<td align="center"><a href="https://modm.io/reference/module/modm-driver-lis3dsh">LIS3DSH</a></td>
9991000
<td align="center"><a href="https://modm.io/reference/module/modm-driver-lis3mdl">LIS3MDL</a></td>
10001001
<td align="center"><a href="https://modm.io/reference/module/modm-driver-lm75">LM75</a></td>
10011002
<td align="center"><a href="https://modm.io/reference/module/modm-driver-lp503x">LP503x</a></td>
1002-
<td align="center"><a href="https://modm.io/reference/module/modm-driver-lsm303a">LSM303A</a></td>
10031003
</tr><tr>
1004+
<td align="center"><a href="https://modm.io/reference/module/modm-driver-lsm303a">LSM303A</a></td>
10041005
<td align="center"><a href="https://modm.io/reference/module/modm-driver-lsm6ds33">LSM6DS33</a></td>
10051006
<td align="center"><a href="https://modm.io/reference/module/modm-driver-lsm6dso">LSM6DSO</a></td>
10061007
<td align="center"><a href="https://modm.io/reference/module/modm-driver-ltc2984">LTC2984</a></td>
10071008
<td align="center"><a href="https://modm.io/reference/module/modm-driver-max31855">MAX31855</a></td>
10081009
<td align="center"><a href="https://modm.io/reference/module/modm-driver-max31865">MAX31865</a></td>
1009-
<td align="center"><a href="https://modm.io/reference/module/modm-driver-max6966">MAX6966</a></td>
10101010
</tr><tr>
1011+
<td align="center"><a href="https://modm.io/reference/module/modm-driver-max6966">MAX6966</a></td>
10111012
<td align="center"><a href="https://modm.io/reference/module/modm-driver-max7219">MAX7219</a></td>
10121013
<td align="center"><a href="https://modm.io/reference/module/modm-driver-mcp23x17">MCP23x17</a></td>
10131014
<td align="center"><a href="https://modm.io/reference/module/modm-driver-mcp2515">MCP2515</a></td>
10141015
<td align="center"><a href="https://modm.io/reference/module/modm-driver-mcp3008">MCP3008</a></td>
10151016
<td align="center"><a href="https://modm.io/reference/module/modm-driver-mcp7941x">MCP7941x</a></td>
1016-
<td align="center"><a href="https://modm.io/reference/module/modm-driver-mcp990x">MCP990X</a></td>
10171017
</tr><tr>
1018+
<td align="center"><a href="https://modm.io/reference/module/modm-driver-mcp990x">MCP990X</a></td>
10181019
<td align="center"><a href="https://modm.io/reference/module/modm-driver-mmc5603">MMC5603</a></td>
10191020
<td align="center"><a href="https://modm.io/reference/module/modm-driver-ms5611">MS5611</a></td>
10201021
<td align="center"><a href="https://modm.io/reference/module/modm-driver-ms5837">MS5837</a></td>
10211022
<td align="center"><a href="https://modm.io/reference/module/modm-driver-nokia5110">NOKIA5110</a></td>
10221023
<td align="center"><a href="https://modm.io/reference/module/modm-driver-nrf24">NRF24</a></td>
1023-
<td align="center"><a href="https://modm.io/reference/module/modm-driver-parallel_tft_display">TFT-DISPLAY</a></td>
10241024
</tr><tr>
1025+
<td align="center"><a href="https://modm.io/reference/module/modm-driver-parallel_tft_display">TFT-DISPLAY</a></td>
10251026
<td align="center"><a href="https://modm.io/reference/module/modm-driver-pat9125el">PAT9125EL</a></td>
10261027
<td align="center"><a href="https://modm.io/reference/module/modm-driver-pca8574">PCA8574</a></td>
10271028
<td align="center"><a href="https://modm.io/reference/module/modm-driver-pca9535">PCA9535</a></td>
10281029
<td align="center"><a href="https://modm.io/reference/module/modm-driver-pca9548a">PCA9548A</a></td>
10291030
<td align="center"><a href="https://modm.io/reference/module/modm-driver-pca9685">PCA9685</a></td>
1030-
<td align="center"><a href="https://modm.io/reference/module/modm-driver-qmc5883l">QMC5883L</a></td>
10311031
</tr><tr>
1032+
<td align="center"><a href="https://modm.io/reference/module/modm-driver-qmc5883l">QMC5883L</a></td>
10321033
<td align="center"><a href="https://modm.io/reference/module/modm-driver-sh1106">SH1106</a></td>
10331034
<td align="center"><a href="https://modm.io/reference/module/modm-driver-siemens_s65">SIEMENS-S65</a></td>
10341035
<td align="center"><a href="https://modm.io/reference/module/modm-driver-siemens_s75">SIEMENS-S75</a></td>
10351036
<td align="center"><a href="https://modm.io/reference/module/modm-driver-sk6812">SK6812</a></td>
10361037
<td align="center"><a href="https://modm.io/reference/module/modm-driver-sk9822">SK9822</a></td>
1037-
<td align="center"><a href="https://modm.io/reference/module/modm-driver-ssd1306">SSD1306</a></td>
10381038
</tr><tr>
1039+
<td align="center"><a href="https://modm.io/reference/module/modm-driver-ssd1306">SSD1306</a></td>
10391040
<td align="center"><a href="https://modm.io/reference/module/modm-driver-st7586s">ST7586S</a></td>
10401041
<td align="center"><a href="https://modm.io/reference/module/modm-driver-st7789">ST7789</a></td>
10411042
<td align="center"><a href="https://modm.io/reference/module/modm-driver-stts22h">STTS22H</a></td>
10421043
<td align="center"><a href="https://modm.io/reference/module/modm-driver-stusb4500">STUSB4500</a></td>
10431044
<td align="center"><a href="https://modm.io/reference/module/modm-driver-sx1276">SX1276</a></td>
1044-
<td align="center"><a href="https://modm.io/reference/module/modm-driver-sx128x">SX128X</a></td>
10451045
</tr><tr>
1046+
<td align="center"><a href="https://modm.io/reference/module/modm-driver-sx128x">SX128X</a></td>
10461047
<td align="center"><a href="https://modm.io/reference/module/modm-driver-tcs3414">TCS3414</a></td>
10471048
<td align="center"><a href="https://modm.io/reference/module/modm-driver-tcs3472">TCS3472</a></td>
10481049
<td align="center"><a href="https://modm.io/reference/module/modm-driver-tlc594x">TLC594x</a></td>
10491050
<td align="center"><a href="https://modm.io/reference/module/modm-driver-tmp102">TMP102</a></td>
10501051
<td align="center"><a href="https://modm.io/reference/module/modm-driver-tmp12x">TMP12x</a></td>
1051-
<td align="center"><a href="https://modm.io/reference/module/modm-driver-tmp175">TMP175</a></td>
10521052
</tr><tr>
1053+
<td align="center"><a href="https://modm.io/reference/module/modm-driver-tmp175">TMP175</a></td>
10531054
<td align="center"><a href="https://modm.io/reference/module/modm-driver-touch2046">TOUCH2046</a></td>
10541055
<td align="center"><a href="https://modm.io/reference/module/modm-driver-vl53l0">VL53L0</a></td>
10551056
<td align="center"><a href="https://modm.io/reference/module/modm-driver-vl6180">VL6180</a></td>

examples/nucleo_h723zg/bmi270/calibration/main.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ using Sda = GpioB9; // D14
2222
using Transport = modm::Bmi270I2cTransport<I2c>;
2323
using Imu = modm::Bmi270<Transport>;
2424

25-
Imu imu{static_cast<uint8_t>(0x68)};
25+
Imu imu{Transport::I2cAddress::SdoLow};
2626

2727
namespace
2828
{
@@ -71,7 +71,7 @@ main()
7171
{
7272
Board::initialize();
7373
Leds::setOutput();
74-
I2c::connect<Scl::Scl, Sda::Sda>(I2c::PullUps::Internal);
74+
I2c::connect<Scl::Scl, Sda::Sda>(I2c::PullUps::External);
7575
I2c::initialize<Board::SystemClock, 1_MHz, 10_pct>();
7676

7777
MODM_LOG_INFO << "BMI270 calibration example (CRT + gyro user gain restore)" << modm::endl;

0 commit comments

Comments
 (0)