Add a blocked command and improve user interface

Author: kyb3r

bot.py

@@ -171,8 +171,9 @@ def help_embed(self, prefix):
                f'`{prefix}reply <message...>` - Sends a message to the current thread\'s recipient.\n' \
                f'`{prefix}close` - Closes the current thread and deletes the channel.\n' \
                f'`{prefix}archive` - Closes the current thread and moves the channel to archive category.\n' \
-               f'`{prefix}block` - Blocks a user from using modmail\n' \
-               f'`{prefix}unblock` - Unblocks a user from using modmail\n' \
+               f'`{prefix}block` - Blocks a user from using modmail.\n' \
+               f'`{prefix}blocked` - Shows a list of currently blocked users.\n' \
+               f'`{prefix}unblock` - Unblocks a user from using modmail.\n' \
                f'`{prefix}snippets` - See a list of snippets that are currently configured.\n' \
                f'`{prefix}customstatus` - Sets the Bot status to whatever you want.\n' \
                f'`{prefix}disable` - Closes all threads and disables modmail for the server.\n' 
@@ -317,7 +318,7 @@ async def archive(self, ctx):
         em = discord.Embed(title='Thread Closed')
         em.description = f'{ctx.author.mention} has closed this modmail session.'
         em.color = discord.Color.red()
-        
+
         try:
             await user.send(embed=em)
         except:
@@ -546,12 +547,17 @@ async def reply(self, ctx, *, msg=''):
                     await self.process_reply(ctx.message, user_id=user_id)
 
     @commands.command()
+    @commands.has_permissions(manage_channels=True)
     async def contact(self, ctx, *, user: discord.Member):
         '''Create a thread with a specified member.'''
         categ = discord.utils.get(ctx.guild.categories, id=ctx.channel.category_id)
-        if categ is not None and categ.name == 'Mod Mail':
-            channel = await self.create_thread(user, creator=ctx.author)
-            await ctx.send(f'Created thread {channel.mention}')
+        channel = await self.create_thread(user, creator=ctx.author)
+        
+        em = discord.Embed(title='Created Thread')
+        em.description = f'Thread started in {channel.mention} for {user.mention}'
+        em.color = discord.Color.green()
+
+        await ctx.send(embed=em)
 
     @commands.command(name="customstatus", aliases=['status', 'presence'])
     @commands.has_permissions(administrator=True)
@@ -560,8 +566,45 @@ async def _status(self, ctx, *, message):
         if message == 'clear':
             return await self.change_presence(activity=None)
         await self.change_presence(activity=discord.Game(message))
-        await ctx.send(f"Changed status to **{message}**")
+        em = discord.Embed(title='Status Changed')
+        em.description = message
+        em.color = discord.Color.green()
+        em.set_footer(text='Note: this change is temporary.')
+        await ctx.send(embed=em)
+    
+    @commands.command()
+    @commands.has_permissions(manage_channels=True)
+    async def blocked(self, ctx):
+        '''Returns a list of blocked users'''
+        categ = discord.utils.get(ctx.guild.categories, name='Mod Mail')
+        top_chan = categ.channels[0] #bot-info
+        ids = re.findall(r'\d+', top_chan.topic)
+
+        em = discord.Embed(title='Blocked Users', color=discord.Color.green())
+        em.description = ''
+
+        users = []
+        not_reachable = []
+
+        for id in ids:
+            user = self.get_user(int(id))
+            if user:
+                users.append(user)
+            else:
+                not_reachable.append(id)
+        
+        em.description = 'Here is a list of blocked users.'
+        
+        if users:
+            em.add_field(name='Currently Known', value=' '.join(u.mention for u in users))
+        if not_reachable:
+            em.add_field(name='Unknown', value='\n'.join(f'`{i}`' for i in not_reachable), inline=False)
+        
+        if not users and not not_reachable:
+            em.description = 'Currently there are no blocked users'
 
+        await ctx.send(embed=em)
+        
     @commands.command()
     @commands.has_permissions(manage_channels=True)
     async def block(self, ctx, id=None):
@@ -577,11 +620,25 @@ async def block(self, ctx, id=None):
         topic = str(top_chan.topic)
         topic += '\n' + id
 
+        user = self.get_user(int(id))
+        mention = user.mention if user else f'`{id}`'
+
+        em = discord.Embed()
+        em.color = discord.Color.green()
+
         if id not in top_chan.topic:  
             await top_chan.edit(topic=topic)
-            await ctx.send('User successfully blocked!')
+
+            em.title = 'Success'
+            em.description = f'{mention} is now blocked'
+
+            await ctx.send(embed=em)
         else:
-            await ctx.send('User is already blocked.')
+            em.title = 'Error'
+            em.description = f'{mention} is already blocked'
+            em.color = discord.Color.red()
+
+            await ctx.send(embed=em)
 
     @commands.command()
     @commands.has_permissions(manage_channels=True)
@@ -598,11 +655,25 @@ async def unblock(self, ctx, id=None):
         topic = str(top_chan.topic)
         topic = topic.replace('\n'+id, '')
 
-        if id in top_chan.topic:
+        user = self.get_user(int(id))
+        mention = user.mention if user else f'`{id}`'
+
+        em = discord.Embed()
+        em.color = discord.Color.green()
+
+        if id in top_chan.topic:  
             await top_chan.edit(topic=topic)
-            await ctx.send('User successfully unblocked!')
+
+            em.title = 'Success'
+            em.description = f'{mention} is no longer blocked'
+
+            await ctx.send(embed=em)
         else:
-            await ctx.send('User is not already blocked.')
+            em.title = 'Error'
+            em.description = f'{mention} is not already blocked'
+            em.color = discord.Color.red()
+
+            await ctx.send(embed=em)
 
     @commands.command(hidden=True, name='eval')
     async def _eval(self, ctx, *, body: str):