add update_notifications, resolves #2896

Author: fourjr

CHANGELOG.md

@@ -6,6 +6,16 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 This project mostly adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html);
 however, insignificant breaking changes do not guarantee a major version bump, see the reasoning [here](https://github.com/kyb3r/modmail/issues/319). If you're a plugin developer, note the "BREAKING" section.
 
+# v3.7.14-dev0
+
+### Fixed
+
+- Mentioned `competing` as an activity type ([PR #2902](https://github.com/kyb3r/modmail/pull/2902))
+
+### Added
+
+- `update_notifications` configuration option to toggle bot autoupdate notifications ([GH #2896](https://github.com/kyb3r/modmail/issues/2896))
+
 # v3.7.13
 
 ### Fixed

bot.py

@@ -1,4 +1,4 @@
-__version__ = "3.7.13"
+__version__ = "3.7.14-dev0"
 
 
 import asyncio
@@ -1502,7 +1502,8 @@ async def autoupdate(self):
                     )
                     logger.info("Bot has been updated.")
                     channel = self.log_channel
-                    await channel.send(embed=embed)
+                    if self.bot.config["update_notifications"]:
+                        await channel.send(embed=embed)
             else:
                 try:
                     # update fork if gh_token exists
@@ -1527,14 +1528,18 @@ async def autoupdate(self):
                     channel = self.update_channel
                     if self.hosting_method == HostingMethod.PM2:
                         embed = discord.Embed(title="Bot has been updated", color=self.main_color)
-                        await channel.send(embed=embed)
+                        embed.set_footer(text=f"Updating Modmail v{self.version} " f"-> v{latest.version}")
+                        if self.bot.config["update_notifications"]:
+                            await channel.send(embed=embed)
                     else:
                         embed = discord.Embed(
                             title="Bot has been updated and is logging out.",
                             description="If you do not have an auto-restart setup, please manually start the bot.",
                             color=self.main_color,
                         )
-                        await channel.send(embed=embed)
+                        embed.set_footer(text=f"Updating Modmail v{self.version} " f"-> v{latest.version}")
+                        if self.bot.config["update_notifications"]:
+                            await channel.send(embed=embed)
                     await self.logout()
 
     async def before_autoupdate(self):

core/config.py

@@ -44,6 +44,8 @@ class ConfigManager:
         "log_channel_id": None,
         "mention_channel_id": None,
         "update_channel_id": None,
+        # updates
+        "update_notifications": True,
         # threads
         "sent_emoji": "✅",
         "blocked_emoji": "🚫",
@@ -171,6 +173,7 @@ class ConfigManager:
         "data_collection",
         "enable_eval",
         "disable_autoupdates",
+        "update_notifications",
         "thread_contact_silently",
     }
 

core/config_help.json

@@ -192,10 +192,21 @@
       "`{prefix}config set update_channel_id 9234932582312` (9234932582312 is the channel ID)"
     ],
     "notes": [
-      "This has no effect unless `disable_autoupdates` is set to no.",
+      "This has no effect unless `disable_autoupdates` is set to no and `update_notifications` is set to yes.",
       "See also: `log_channel_id`"
     ]
   },
+  "update_notifications": {
+    "default": "Yes",
+    "description": "This is the channel where update notifications are sent to.",
+    "examples": [
+      "`{prefix}config set update_notifications no"
+    ],
+    "notes": [
+      "This has no effect unless `disable_autoupdates` is set to no.",
+      "See also: `update_channel_id`"
+    ]
+  },
   "sent_emoji": {
     "default": "✅",
     "description": "This is the emoji added to the message when when a Modmail action is invoked successfully (ie. DM Modmail, edit message, etc.).",