fix: anonreply showing None

This fixes a bug where, if no `anon_username` is set and the moderator has no roles, the `anon_username` is not showing as `None` anymore, and will show as intended.

The logic now works as follows:
- If a config anon_username is set → use it
- Else, if a mod_tag is set → use it
- Else, if the moderator has a top role → use that
- Else → use "Anonymous"

Author: lorenzo132

cogs/modmail.py

@@ -1121,10 +1121,9 @@ async def anonadduser(self, ctx, *users_arg: Union[discord.Member, discord.Role,
 
             tag = self.bot.config["mod_tag"]
             if tag is None:
-                tag = str(get_top_role(ctx.author, self.bot.config["use_hoisted_top_role"]))
-            name = self.bot.config["anon_username"]
-            if name is None:
-                name = tag
+                top_role = get_top_role(ctx.author, self.bot.config["use_hoisted_top_role"])
+                tag = str(top_role) if top_role else None
+            name = self.bot.config["anon_username"] or tag or "Anonymous"
             avatar_url = self.bot.config["anon_avatar_url"]
             if avatar_url is None:
                 avatar_url = self.bot.get_guild_icon(guild=ctx.guild, size=128)
@@ -1212,10 +1211,9 @@ async def anonremoveuser(self, ctx, *users_arg: Union[discord.Member, discord.Ro
 
             tag = self.bot.config["mod_tag"]
             if tag is None:
-                tag = str(get_top_role(ctx.author, self.bot.config["use_hoisted_top_role"]))
-            name = self.bot.config["anon_username"]
-            if name is None:
-                name = tag
+                top_role = get_top_role(ctx.author, self.bot.config["use_hoisted_top_role"])
+                tag = str(top_role) if top_role else None
+            name = self.bot.config["anon_username"] or tag or "Anonymous"
             avatar_url = self.bot.config["anon_avatar_url"]
             if avatar_url is None:
                 avatar_url = self.bot.get_guild_icon(guild=ctx.guild, size=128)

core/thread.py

@@ -1652,10 +1652,9 @@ async def send(
                 # Anonymously sending to the user.
                 tag = self.bot.config["mod_tag"]
                 if tag is None:
-                    tag = str(get_top_role(author, self.bot.config["use_hoisted_top_role"]))
-                name = self.bot.config["anon_username"]
-                if name is None:
-                    name = tag
+                    top_role = get_top_role(author, self.bot.config["use_hoisted_top_role"])
+                    tag = str(top_role) if top_role else None
+                name = self.bot.config["anon_username"] or tag or "Anonymous"
                 avatar_url = self.bot.config["anon_avatar_url"]
                 if avatar_url is None:
                     avatar_url = self.bot.get_guild_icon(guild=self.bot.guild, size=128)