Skip to content

Commit a6ebd81

Browse files
committed
Sending files in threads (non-images) now work. resolves #2926
1 parent c2b75dc commit a6ebd81

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ however, insignificant breaking changes do not guarantee a major version bump, s
3232
- Blocked roles will no longer trigger an error during unblock.
3333
- Custom emojis are now supported in `confirm_thread_creation_deny`. ([GH #2916](https://github.com/kyb3r/modmail/issues/2916))
3434
- Finding linked messages in replies work now. ([GH #2920](https://github.com/kyb3r/modmail/issues/2920), [Jerrie-Aries](https://github.com/kyb3r/modmail/issues/2920#issuecomment-751530495))
35+
- Sending files in threads (non-images) now work. ([GH #2926](https://github.com/kyb3r/modmail/issues/2926))
3536

3637
### Internal
3738

core/thread.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -756,7 +756,8 @@ async def reply(
756756
"blocked by the recipient.")
757757
else:
758758
description = ("Your message could not be delivered due "
759-
"to an unknown error. ")
759+
"to an unknown error. Check `?debug` for "
760+
"more information")
760761
tasks.append(
761762
message.channel.send(
762763
embed=discord.Embed(
@@ -933,7 +934,7 @@ async def send(
933934

934935
file_upload_count = 1
935936

936-
for url, filename in attachments:
937+
for url, filename, _ in attachments:
937938
embed.add_field(
938939
name=f"File upload ({file_upload_count})", value=f"[{filename}]({url})"
939940
)

0 commit comments

Comments
 (0)