Fix stuff with viewing perm

Author: Taaku18

CHANGELOG.md

@@ -225,7 +225,7 @@ Un-deprecated the `OWNERS` config variable to support discord developer team acc
 ### New Permissions System
 
 - A brand new permission system! Replacing the old guild-based permissions (ie. manage channels, manage messages), the new system enables you to customize your desired permission level specific to a command or a group of commands for a role or user.
-- There are five permission groups/levels:
+- There are five permission levels:
   - Owner [5]
   - Administrator [4]
   - Moderator [3]
@@ -247,7 +247,7 @@ The same applies to individual commands permissions:
 
 To revoke permission, use `remove` instead of `add`.
 
-To view all roles and users with permission for a permission group or command do:
+To view all roles and users with permission for a permission level or command do:
 -  `?permissions get command command-name`
 -  `?permissions get level owner`
 

cogs/modmail.py

@@ -87,7 +87,7 @@ async def setup(self, ctx):
         await self.bot.config.update()
         await ctx.send(
             "Successfully set up server.\n"
-            "Consider setting permission groups to give access "
+            "Consider setting permission levels to give access "
             "to roles or users the ability to use Modmail.\n"
             f"Type `{self.bot.prefix}permissions` for more info."
         )

cogs/utility.py

@@ -220,9 +220,9 @@ async def send_error_message(self, error):
 
         choices = set()
 
-        for name, cmd in self.context.bot.all_commands.items():
+        for cmd in self.context.bot.walk_commands():
             if not cmd.hidden:
-                choices.add(name)
+                choices.add(cmd.name)
 
         closest = get_close_matches(command, choices)
         if closest:
@@ -1221,7 +1221,7 @@ def _verify_user_or_role(user_or_role):
     @permissions.command(name="add", usage="[command/level] [name] [user_or_role]")
     @checks.has_permissions(PermissionLevel.OWNER)
     async def permissions_add(
-        self, ctx, type_: str.lower, name: str, *, user_or_role: Union[User, Role, str]
+        self, ctx, type_: str.lower, name: str, *, user_or_role: Union[Role, User, str]
     ):
         """
         Add a permission to a command or a permission level.
@@ -1279,7 +1279,7 @@ async def permissions_add(
     )
     @checks.has_permissions(PermissionLevel.OWNER)
     async def permissions_remove(
-        self, ctx, type_: str.lower, name: str, *, user_or_role: Union[User, Role, str]
+        self, ctx, type_: str.lower, name: str, *, user_or_role: Union[Role, User, str]
     ):
         """
         Remove permission to use a command or permission level.
@@ -1300,8 +1300,7 @@ async def permissions_remove(
 
         level = None
         if type_ == "command":
-            command = self.bot.get_command(name.lower())
-            name = command.qualified_name if command is not None else name
+            name = getattr(self.bot.get_command(name.lower()), "qualified_name", name)
         else:
             if name.upper() not in PermissionLevel.__members__:
                 embed = Embed(
@@ -1364,7 +1363,7 @@ def _get_perm(self, ctx, name, type_):
     @permissions.command(name="get", usage="[@user] or [command/level] [name]")
     @checks.has_permissions(PermissionLevel.OWNER)
     async def permissions_get(
-        self, ctx, user_or_role: Union[User, Role, str], *, name: str = None
+        self, ctx, user_or_role: Union[Role, User, str], *, name: str = None
     ):
         """
         View the currently-set permissions.
@@ -1388,7 +1387,7 @@ async def permissions_get(
             levels = []
 
             done = set()
-            for _, command in self.bot.all_commands.items():
+            for command in self.bot.walk_commands():
                 if command not in done:
                     done.add(command)
                     permissions = self.bot.config["command_permissions"].get(
@@ -1421,7 +1420,7 @@ async def permissions_get(
                     color=self.bot.main_color,
                 ),
                 Embed(
-                    title=f"{mention} has permission with the following permission groups:",
+                    title=f"{mention} has permission with the following permission levels:",
                     description=desc_level,
                     color=self.bot.main_color,
                 ),
@@ -1457,7 +1456,7 @@ async def permissions_get(
             else:
                 if user_or_role == "command":
                     done = set()
-                    for _, command in self.bot.all_commands.items():
+                    for command in self.bot.walk_commands():
                         if command not in done:
                             done.add(command)
                             embeds.append(