Escape hyphen in regex string

ChrisLovering · sebkuip · commit c1241d5ea6c4 · 2025-03-10T20:53:51.000+01:00
Unescaped this was permitting any character between $ (index 36) and _ (index 95), which aren't all valid in urls.
diff --git a/core/thread.py b/core/thread.py
@@ -995,7 +995,7 @@ async def send(
                 attachments.append(attachment)
 
         image_urls = re.findall(
-            r"http[s]?:\/\/(?:[a-zA-Z]|[0-9]|[$-_@.&+]|[!*(),]|(?:%[0-9a-fA-F][0-9a-fA-F]))+",
+            r"http[s]?:\/\/(?:[a-zA-Z]|[0-9]|[$\-_@.&+]|[!*(),]|(?:%[0-9a-fA-F][0-9a-fA-F]))+",
             message.content,
         )
 

Original file line number	Diff line number	Diff line change
`@@ -995,7 +995,7 @@ async def send(`
`995`	`995`	`attachments.append(attachment)`
`996`	`996`
`997`	`997`	`image_urls = re.findall(`
`998`		`- r"http[s]?:\/\/(?:[a-zA-Z]\|[0-9]\|[$-_@.&+]\|[!*(),]\|(?:%[0-9a-fA-F][0-9a-fA-F]))+",`
	`998`	`+ r"http[s]?:\/\/(?:[a-zA-Z]\|[0-9]\|[$\-_@.&+]\|[!*(),]\|(?:%[0-9a-fA-F][0-9a-fA-F]))+",`
`999`	`999`	`message.content,`
`1000`	`1000`	`)`
`1001`	`1001`