Skip to content

Commit da0007e

Browse files
ConnorGraypatrickdoc
authored andcommitted
[Integrate] Bump LLVM to 40e545098e (#50539)
- Check `isinstance(results, (Operation, OpView))` when checking for ops with no results in `Graph._add_op`. This check is required after an upstream change where now the Python bindings for `mo.OutputOp` are no longer a subclass of `mlir.Operation. Potentially LLVM PR [114542](llvm/llvm-project#114542) is the related upstream change. * Disabled `Fill.getScalarZeroes` test, which is failing due to a new assertion in LLVM. Filed KERN-1196 to track fixing the test. MAX_GRAPH_API_ORIG_REV_ID: f570b71be0d6fb4a71d38b0b180c9493ac148758
1 parent 9859736 commit da0007e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

max/graph/graph.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
from typing import Callable, Iterable, Optional
1616

1717
from max import _graph, mlir
18+
from max._mlir.ir import OpView
1819
from max.mlir.dialects import mo
1920

2021
from .type import (
@@ -317,7 +318,7 @@ def unwrap(arg):
317318
# Intentionally suppress extra stack traces from max._mlir.
318319
) from None
319320

320-
if isinstance(results, mlir.Operation):
321+
if isinstance(results, (mlir.Operation, OpView)):
321322
return []
322323

323324
# Convert op results from mlir.Value to instances of Value graph-api

0 commit comments

Comments
 (0)