Merge pull request #269 from module-federation/release-0-1-0

prevent thread count from rising above max

Author: tysonrm

nohup.out

@@ -3211,3 +3211,53 @@ Error: Command failed: ./watch.sh 80 8888
   signal: null,
   cmd: './watch.sh 80 8888'
 }
+change domain/thread-pool.js
+Error: Command failed: ./watch.sh 80 8888
+
+    at ChildProcess.exithandler (node:child_process:402:12)
+    at ChildProcess.emit (node:events:513:28)
+    at maybeClose (node:internal/child_process:1100:16)
+    at Process.ChildProcess._handle.onexit (node:internal/child_process:304:5) {
+  code: 7,
+  killed: false,
+  signal: null,
+  cmd: './watch.sh 80 8888'
+}
+change domain/thread-pool.js
+Error: Command failed: ./watch.sh 80 8888
+
+    at ChildProcess.exithandler (node:child_process:402:12)
+    at ChildProcess.emit (node:events:513:28)
+    at maybeClose (node:internal/child_process:1100:16)
+    at Process.ChildProcess._handle.onexit (node:internal/child_process:304:5) {
+  code: 7,
+  killed: false,
+  signal: null,
+  cmd: './watch.sh 80 8888'
+}
+change domain/thread-pool.js
+Error: Command failed: ./watch.sh 80 8888
+
+    at ChildProcess.exithandler (node:child_process:402:12)
+    at ChildProcess.emit (node:events:513:28)
+    at maybeClose (node:internal/child_process:1100:16)
+    at Socket.<anonymous> (node:internal/child_process:458:11)
+    at Socket.emit (node:events:513:28)
+    at Pipe.<anonymous> (node:net:301:12) {
+  code: 7,
+  killed: false,
+  signal: null,
+  cmd: './watch.sh 80 8888'
+}
+change domain/thread-pool.js
+Error: Command failed: ./watch.sh 80 8888
+
+    at ChildProcess.exithandler (node:child_process:402:12)
+    at ChildProcess.emit (node:events:513:28)
+    at maybeClose (node:internal/child_process:1100:16)
+    at Process.ChildProcess._handle.onexit (node:internal/child_process:304:5) {
+  code: 7,
+  killed: false,
+  signal: null,
+  cmd: './watch.sh 80 8888'
+}

src/domain/thread-pool.js

@@ -164,7 +164,7 @@ export class ThreadPool extends EventEmitter {
 
     if (options?.preload) {
       console.info('preload enabled for', this.name)
-      this.startThreads(true)
+      this.startThreads()
     }
   }
 
@@ -516,6 +516,7 @@ export class ThreadPool extends EventEmitter {
       errorTolerance: this.errorRateThreshold(),
       errors: this.errorCount(),
       deployments: this.deploymentCount(),
+      poolCanGrow: this.poolCanGrow(),
       ...Object.entries(process.memoryUsage())
         .map(([k, v]) => ({ [`${k}Mb`]: Math.round(v / 1024 / 1024) }))
         .reduce((a, b) => ({ ...a, ...b })),
@@ -593,6 +594,10 @@ export class ThreadPool extends EventEmitter {
     return this
   }
 
+  enqueue (job) {
+    this.waitingJobs.push(thread => thread.run(job))
+  }
+
   /**
    * Run a job (use case function) on an available thread; or queue the job
    * until one becomes available.
@@ -620,15 +625,15 @@ export class ThreadPool extends EventEmitter {
         ...options
       })
 
-      let thread = this.checkout()
+      const thread = this.checkout()
 
       if (thread) {
         thread.run(job)
         return
       }
 
       console.warn('no threads: queuing job', jobName)
-      this.waitingJobs.push(thread => thread.run(job))
+      this.enqueue(job)
       this.incrementJobsQueued()
     })
   }