build: disable hoistTransitiveImports for better tree shake (#3146)

Author: ScriptedAlchemy

.changeset/popular-pillows-draw.md

@@ -0,0 +1,11 @@
+---
+'@module-federation/webpack-bundler-runtime': patch
+'@module-federation/data-prefetch': patch
+'@module-federation/runtime-tools': patch
+'@module-federation/managers': patch
+'@module-federation/manifest': patch
+'@module-federation/runtime': patch
+'@module-federation/sdk': patch
+---
+
+disable hoistTransitiveImports for better tree shake

packages/data-prefetch/rollup.config.js

@@ -28,6 +28,7 @@ module.exports = (rollupConfig, _projectOptions) => {
           return 'polyfills';
         }
       },
+      hoistTransitiveImports: false,
     }));
   } else {
     rollupConfig.output = {
@@ -37,6 +38,7 @@ module.exports = (rollupConfig, _projectOptions) => {
           return 'polyfills';
         }
       },
+      hoistTransitiveImports: false,
     };
   }
 

packages/managers/rollup.config.js

@@ -9,5 +9,15 @@ module.exports = (rollupConfig, _projectOptions) => {
     }),
   );
 
+  // Check if rollupConfig.output is an array
+  if (Array.isArray(rollupConfig.output)) {
+    rollupConfig.output.forEach((output) => {
+      output.hoistTransitiveImports = false;
+    });
+  } else if (rollupConfig.output) {
+    // If it's not an array, directly set the property
+    rollupConfig.output.hoistTransitiveImports = false;
+  }
+
   return rollupConfig;
 };

packages/manifest/rollup.config.js

@@ -1,6 +1,16 @@
 const copy = require('rollup-plugin-copy');
 
 module.exports = (rollupConfig, _projectOptions) => {
+  // Check if rollupConfig.output is an array
+  if (Array.isArray(rollupConfig.output)) {
+    rollupConfig.output.forEach((output) => {
+      output.hoistTransitiveImports = false;
+    });
+  } else if (rollupConfig.output) {
+    // If it's not an array, directly set the property
+    rollupConfig.output.hoistTransitiveImports = false;
+  }
+
   rollupConfig.plugins.push(
     copy({
       targets: [

packages/runtime-tools/rollup.config.js

@@ -6,5 +6,18 @@ module.exports = (rollupConfig) => {
       'packages/runtime-tools/src/webpack-bundler-runtime.ts',
   };
 
+  // Check if output is an array and add hoistTransitiveImports: false
+  if (Array.isArray(rollupConfig.output)) {
+    rollupConfig.output = rollupConfig.output.map((c) => ({
+      ...c,
+      hoistTransitiveImports: false,
+    }));
+  } else {
+    rollupConfig.output = {
+      ...rollupConfig.output,
+      hoistTransitiveImports: false,
+    };
+  }
+
   return rollupConfig;
 };

packages/runtime/rollup.config.js

@@ -29,6 +29,7 @@ module.exports = (rollupConfig, projectOptions) => {
           return 'polyfills';
         }
       },
+      hoistTransitiveImports: false,
     }));
   } else {
     rollupConfig.output = {
@@ -38,6 +39,7 @@ module.exports = (rollupConfig, projectOptions) => {
           return 'polyfills';
         }
       },
+      hoistTransitiveImports: false,
     };
   }
 

packages/sdk/rollup.config.js

@@ -17,6 +17,7 @@ module.exports = (rollupConfig, _projectOptions) => {
           return 'polyfills';
         }
       },
+      hoistTransitiveImports: false,
     }));
   } else {
     rollupConfig.output = {
@@ -26,6 +27,7 @@ module.exports = (rollupConfig, _projectOptions) => {
           return 'polyfills';
         }
       },
+      hoistTransitiveImports: false,
     };
   }
 

packages/webpack-bundler-runtime/rollup.config.js

@@ -1,26 +1,44 @@
 const copy = require('rollup-plugin-copy');
 
+function manualChunks(id, projectOptions) {
+  // if (id.includes(projectOptions.main)) {
+  //   return;
+  // }
+  // if (
+  //   projectOptions.additionalEntryPoints.some((entryPoint) => {
+  //     return id.includes(entryPoint);
+  //   })
+  // ) {
+  //   return;
+  // }
+  if (id.includes('@swc/helpers')) {
+    return 'polyfills';
+  }
+  // if (!id.includes('webpack-bundler-runtime')) {
+  //   return;
+  // }
+  // if (id.endsWith('types.ts')) {
+  //   return;
+  // }
+  // if (id.endsWith('.d.ts')) return;
+  // const cName = id.split('src/')[1].replace('/', '_').replace('.ts', '');
+  // return cName;
+}
+
 module.exports = (rollupConfig, projectOptions) => {
   rollupConfig.external = [/@module-federation/];
+
   if (Array.isArray(rollupConfig.output)) {
     rollupConfig.output = rollupConfig.output.map((c) => ({
       ...c,
-      manualChunks: (id) => {
-        debugger;
-        if (id.includes('@swc/helpers')) {
-          return 'polyfills';
-        }
-      },
+      manualChunks: (id) => manualChunks(id, projectOptions),
+      hoistTransitiveImports: false,
     }));
   } else {
     rollupConfig.output = {
       ...rollupConfig.output,
-      manualChunks: (id) => {
-        debugger;
-        if (id.includes('@swc/helpers')) {
-          return 'polyfills';
-        }
-      },
+      manualChunks: (id) => manualChunks(id, projectOptions),
+      hoistTransitiveImports: false,
     };
   }