File tree Expand file tree Collapse file tree 3 files changed +15
-2
lines changed Expand file tree Collapse file tree 3 files changed +15
-2
lines changed Original file line number Diff line number Diff line change
1
+ ---
2
+ ' @module-federation/runtime ' : patch
3
+ ' @module-federation/sdk ' : patch
4
+ ---
5
+
6
+ fix: do not delete link tag if no preload
Original file line number Diff line number Diff line change @@ -174,6 +174,7 @@ export function preloadAssets(
174
174
}
175
175
return ;
176
176
} ,
177
+ needDeleteLink : false ,
177
178
} ) ;
178
179
179
180
needAttach && document . head . appendChild ( cssEl ) ;
@@ -220,6 +221,7 @@ export function preloadAssets(
220
221
}
221
222
return ;
222
223
} ,
224
+ needDeleteScript : true ,
223
225
} ) ;
224
226
needAttach && document . head . appendChild ( scriptEl ) ;
225
227
} ) ;
Original file line number Diff line number Diff line change @@ -90,7 +90,8 @@ export function createScript(info: {
90
90
script . onerror = null ;
91
91
script . onload = null ;
92
92
safeWrapper ( ( ) => {
93
- if ( info . needDeleteScript ) {
93
+ const { needDeleteScript = true } = info ;
94
+ if ( needDeleteScript ) {
94
95
script ?. parentNode && script . parentNode . removeChild ( script ) ;
95
96
}
96
97
} ) ;
@@ -121,6 +122,7 @@ export function createLink(info: {
121
122
url : string ;
122
123
cb : ( value : void | PromiseLike < void > ) => void ;
123
124
attrs : Record < string , string > ;
125
+ needDeleteLink ?: boolean ;
124
126
createLinkHook ?: ( url : string ) => HTMLLinkElement | void ;
125
127
} ) {
126
128
// <link rel="preload" href="script.js" as="script">
@@ -175,7 +177,10 @@ export function createLink(info: {
175
177
link . onerror = null ;
176
178
link . onload = null ;
177
179
safeWrapper ( ( ) => {
178
- link ?. parentNode && link . parentNode . removeChild ( link ) ;
180
+ const { needDeleteLink = true } = info ;
181
+ if ( needDeleteLink ) {
182
+ link ?. parentNode && link . parentNode . removeChild ( link ) ;
183
+ }
179
184
} ) ;
180
185
if ( prev ) {
181
186
// eslint-disable-next-line @typescript-eslint/no-explicit-any
You can’t perform that action at this time.
0 commit comments