chore: update NX libraries to v19 (#2764)

Co-authored-by: Colum Ferry <[email protected]>
Co-authored-by: 2heal1 <[email protected]>
Co-authored-by: Hanric <[email protected]>

Author: 3 people

.eslintrc.json

@@ -27,14 +27,18 @@
       "rules": {
         "@typescript-eslint/ban-ts-comment": "off",
         "@typescript-eslint/no-explicit-any": "off",
-        "@typescript-eslint/no-unused-vars": "off"
+        "@typescript-eslint/no-unused-vars": "off",
+        "@typescript-eslint/no-extra-semi": "error",
+        "no-extra-semi": "off"
       }
     },
     {
       "files": ["*.js", "*.jsx"],
       "extends": ["plugin:@nx/javascript"],
       "rules": {
-        "@typescript-eslint/no-useless-constructor": "off"
+        "@typescript-eslint/no-useless-constructor": "off",
+        "@typescript-eslint/no-extra-semi": "error",
+        "no-extra-semi": "off"
       }
     },
     {

.github/workflows/e2e-modern.yml

@@ -44,3 +44,6 @@ jobs:
       - name: E2E Test for ModernJS
         if: steps.check-ci.outcome == 'success'
         run: npx kill-port --port 4001 && npx nx run-many --target=test:e2e --projects=modernjs --parallel=1 && npx kill-port --port 4001
+
+      - name: Kill ports
+        run: npx kill-port --port 4001

.github/workflows/e2e-next-dev.yml

@@ -49,4 +49,4 @@ jobs:
           npx wait-on tcp:3002 &&
           npx wait-on tcp:3000 &&
           npx nx run-many --target=test:e2e --projects=3000-home,3001-shop,3002-checkout --parallel=1 &&
-          lsof -ti tcp:3000,3001,3002 | xargs kill
+          npx kill-port 3000,3001,3002

.github/workflows/e2e-next-prod.yml

@@ -50,4 +50,4 @@ jobs:
           npx wait-on tcp:3002 &&
           npx wait-on tcp:3000 &&
           npx nx run-many --target=test:e2e --projects=3000-home,3001-shop,3002-checkout --parallel=1 &&
-          lsof -ti tcp:3000,3001,3002 | xargs kill
+          npx kill-port 3000,3001,3002

.prettierignore

@@ -8,3 +8,6 @@
 pnpm-lock.yaml
 **/dist/**
 apps/website-new/docs
+
+/.nx/workspace-data
+/.nx/cache

apps/3000-home/components/SharedNav.tsx

@@ -24,7 +24,6 @@ const SharedNav = () => {
         </>
       ),
       key: '/',
-      onMouseEnter: () => {},
     },
     {
       className: 'shop-menu-link',

apps/3000-home/package.json

@@ -5,22 +5,9 @@
   "dependencies": {
     "antd": "5.19.1",
     "@ant-design/cssinjs": "^1.21.0",
-    "buffer": "5.7.1",
-    "encoding": "0.1.13",
-    "eslint-scope": "7.2.2",
-    "events": "3.3.0",
-    "js-cookie": "3.0.5",
     "lodash": "4.17.21",
     "next": "14.1.2",
-    "node-fetch": "2.7.0",
-    "react": "18.2.0",
-    "react-dom": "18.2.0",
-    "schema-utils": "3.3.0",
-    "terser-webpack-plugin": "5.3.10",
-    "typescript": "5.3.3",
-    "upath": "2.0.1",
-    "url": "0.11.3",
-    "util": "0.12.5"
+    "react": "18.3.1"
   },
   "devDependencies": {
     "@module-federation/nextjs-mf": "workspace:*",

apps/3000-home/project.json

@@ -3,6 +3,7 @@
   "$schema": "../../node_modules/nx/schemas/project-schema.json",
   "sourceRoot": "apps/3000-home",
   "projectType": "application",
+  "tags": [],
   "targets": {
     "build": {
       "executor": "@nx/next:build",
@@ -93,6 +94,5 @@
         ]
       }
     }
-  },
-  "tags": []
+  }
 }

apps/3001-shop/package.json

@@ -3,31 +3,11 @@
   "version": "1.0.0",
   "private": true,
   "dependencies": {
-    "acorn": "8.12.1",
     "antd": "5.19.1",
     "@ant-design/cssinjs": "^1.21.0",
-    "buffer": "5.7.1",
-    "chrome-trace-event": "1.0.4",
-    "encoding": "0.1.13",
-    "enhanced-resolve": "5.15.0",
-    "eslint-scope": "7.2.2",
-    "eventemitter3": "5.0.1",
-    "events": "3.3.0",
-    "fast-glob": "3.3.2",
     "lodash": "4.17.21",
     "next": "14.1.2",
-    "node-fetch": "2.7.0",
-    "react": "18.2.0",
-    "react-dom": "18.2.0",
-    "schema-utils": "3.3.0",
-    "semver": "6.3.1",
-    "tapable": "2.2.1",
-    "terser-webpack-plugin": "5.3.10",
-    "typescript": "5.3.3",
-    "upath": "2.0.1",
-    "url": "0.11.3",
-    "util": "0.12.5",
-    "webpack-sources": "3.2.3"
+    "react": "18.3.1"
   },
   "devDependencies": {
     "@module-federation/nextjs-mf": "workspace:*",

apps/3001-shop/project.json

@@ -3,6 +3,7 @@
   "$schema": "../../node_modules/nx/schemas/project-schema.json",
   "sourceRoot": "apps/3001-shop",
   "projectType": "application",
+  "tags": [],
   "targets": {
     "build": {
       "executor": "@nx/next:build",
@@ -92,6 +93,5 @@
         }
       }
     }
-  },
-  "tags": []
+  }
 }