Skip to content

Commit 0f71cbc

Browse files
authored
fix(sdk): createLink hook error dom attr rel (#3463)
1 parent 578aa43 commit 0f71cbc

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

.changeset/fair-lies-move.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@module-federation/sdk': patch
3+
---
4+
5+
fix(sdk): createLink hook error dom attr rel

packages/sdk/src/dom.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { CreateScriptHookDom, CreateScriptHookReturnDom } from './types';
1+
import type { CreateScriptHookDom, CreateScriptHookReturnDom } from './types';
22
import { warn } from './utils';
33
// eslint-disable-next-line @typescript-eslint/no-explicit-any
44
export async function safeWrapper<T extends (...args: Array<any>) => any>(
@@ -155,11 +155,11 @@ export function createLink(info: {
155155
for (let i = 0; i < links.length; i++) {
156156
const l = links[i];
157157
const linkHref = l.getAttribute('href');
158-
const linkRef = l.getAttribute('ref');
158+
const linkRel = l.getAttribute('rel');
159159
if (
160160
linkHref &&
161161
isStaticResourcesEqual(linkHref, info.url) &&
162-
linkRef === info.attrs['ref']
162+
linkRel === info.attrs['rel']
163163
) {
164164
link = l;
165165
needAttach = false;

0 commit comments

Comments
 (0)