Skip to content

Commit 103cd07

Browse files
fix(runtime): correct type structure for preload remote hook (#2515)
1 parent d1d9809 commit 103cd07

File tree

2 files changed

+15
-6
lines changed

2 files changed

+15
-6
lines changed

.changeset/bright-items-draw.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@module-federation/runtime': patch
3+
---
4+
5+
fix types for beforePreloadRemote args hook

packages/runtime/src/remote/index.ts

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -92,11 +92,15 @@ export class RemoteHandler {
9292
],
9393
void | unknown
9494
>('errorLoadRemote'),
95-
beforePreloadRemote: new AsyncHook<{
96-
preloadOps: Array<PreloadRemoteArgs>;
97-
options: Options;
98-
origin: FederationHost;
99-
}>(),
95+
beforePreloadRemote: new AsyncHook<
96+
[
97+
{
98+
preloadOps: Array<PreloadRemoteArgs>;
99+
options: Options;
100+
origin: FederationHost;
101+
},
102+
]
103+
>('beforePreloadRemote'),
100104
generatePreloadAssets: new AsyncHook<
101105
[
102106
{
@@ -195,7 +199,7 @@ export class RemoteHandler {
195199
const { host } = this;
196200

197201
await this.hooks.lifecycle.beforePreloadRemote.emit({
198-
preloadOptions,
202+
preloadOps: preloadOptions,
199203
options: host.options,
200204
origin: host,
201205
});

0 commit comments

Comments
 (0)