Merge branch 'pr9-implementation' into share-filter

Author: ScriptedAlchemy

packages/enhanced/src/lib/sharing/SharePlugin.ts

@@ -57,15 +57,7 @@ class SharePlugin {
               };
         return config;
       },
-      (item, key) => {
-        // Enhanced validation for shared config
-        if (item.include && item.exclude) {
-          throw new Error(
-            `Cannot specify both include and exclude filters for shared module "${key}"`,
-          );
-        }
-        return item;
-      },
+      (item) => item,
     );
     const consumes: Record<string, ConsumesConfig>[] = sharedOptions.map(
       ([key, options]) => ({
@@ -184,27 +176,15 @@ class SharePlugin {
     process.env['FEDERATION_WEBPACK_PATH'] =
       process.env['FEDERATION_WEBPACK_PATH'] || getWebpackPath(compiler);
 
-    // Apply ConsumeSharedPlugin with enhanced error handling
-    try {
-      new ConsumeSharedPlugin({
-        shareScope: this._shareScope,
-        consumes: this._consumes,
-      }).apply(compiler);
-    } catch (error) {
-      const message = error instanceof Error ? error.message : String(error);
-      throw new Error(`Failed to apply ConsumeSharedPlugin: ${message}`);
-    }
+    new ConsumeSharedPlugin({
+      shareScope: this._shareScope,
+      consumes: this._consumes,
+    }).apply(compiler);
 
-    // Apply ProvideSharedPlugin with enhanced error handling
-    try {
-      new ProvideSharedPlugin({
-        shareScope: this._shareScope,
-        provides: this._provides,
-      }).apply(compiler);
-    } catch (error) {
-      const message = error instanceof Error ? error.message : String(error);
-      throw new Error(`Failed to apply ProvideSharedPlugin: ${message}`);
-    }
+    new ProvideSharedPlugin({
+      shareScope: this._shareScope,
+      provides: this._provides,
+    }).apply(compiler);
   }
 }
 

packages/enhanced/test/compiler-unit/sharing/SharePlugin.test.ts

@@ -273,9 +273,7 @@ describe('SharePlugin Compiler Integration', () => {
         new SharePlugin({
           shared: {},
         });
-      }).toThrow(
-        'SharePlugin requires at least one shared module configuration',
-      );
+      }).not.toThrow();
 
       expect(() => {
         new SharePlugin({
@@ -286,9 +284,7 @@ describe('SharePlugin Compiler Integration', () => {
             },
           },
         });
-      }).toThrow(
-        'Cannot specify both include and exclude filters for shared module "react"',
-      );
+      }).not.toThrow();
     });
   });
 });

packages/enhanced/test/configCases/sharing/consume-filters/webpack.config.js

@@ -37,7 +37,7 @@ module.exports = {
         },
         // Request filtering tests
         'components/': {
-          shareKey: 'request-prefix',
+          shareKey: 'request-prefix/',
           include: {
             request: /^Button/,
           },

packages/enhanced/test/unit/sharing/SharePlugin.improved.test.ts

@@ -287,15 +287,13 @@ describe('SharePlugin Real Behavior', () => {
   });
 
   describe('edge cases and error handling', () => {
-    it('should throw error for empty shared configuration', () => {
+    it('should handle empty shared configuration', () => {
       expect(() => {
         new SharePlugin({
           shareScope: 'default',
           shared: {},
         });
-      }).toThrow(
-        'SharePlugin requires at least one shared module configuration',
-      );
+      }).not.toThrow();
     });
 
     it('should handle missing shareScope with default fallback', () => {

packages/enhanced/test/unit/sharing/SharePlugin.test.ts

@@ -44,17 +44,15 @@ const SharePlugin = require('../../../src/lib/sharing/SharePlugin').default;
 
 describe('SharePlugin', () => {
   describe('constructor', () => {
-    it('should throw error for empty shared configuration', () => {
+    it('should handle empty shared configuration', () => {
       expect(() => {
         new SharePlugin({
           shared: {},
         });
-      }).toThrow(
-        'SharePlugin requires at least one shared module configuration',
-      );
+      }).not.toThrow();
     });
 
-    it('should throw error for conflicting include/exclude filters', () => {
+    it('should allow both include and exclude filters together', () => {
       expect(() => {
         new SharePlugin({
           shared: {
@@ -64,9 +62,7 @@ describe('SharePlugin', () => {
             },
           },
         });
-      }).toThrow(
-        'Cannot specify both include and exclude filters for shared module "react"',
-      );
+      }).not.toThrow();
     });
 
     it('should initialize with string shareScope', () => {

packages/modernjs/src/constant.ts

@@ -1,3 +1,3 @@
 export const LOCALHOST = 'localhost';
 export const PLUGIN_IDENTIFIER = '[ Modern.js Module Federation ]';
-// Force rebuild - CI fix attempt
+

packages/rsbuild-plugin/tsconfig.json

@@ -15,14 +15,7 @@
     "skipDefaultLibCheck": true,
     "declaration": true,
     "noImplicitAny": false,
-    "paths": {
-      "@module-federation/sdk": ["../sdk/src/index.ts"],
-      "@module-federation/sdk/*": ["../sdk/src/*"],
-      "@module-federation/enhanced": ["../enhanced/src/index.ts"],
-      "@module-federation/enhanced/*": ["../enhanced/src/*"],
-      "@module-federation/node": ["../node/src/index.ts"],
-      "@module-federation/node/*": ["../node/src/*"]
-    }
+
   },
   "include": ["src", "../../global.d.ts", "__tests__/**/*"],
   "exclude": [