Skip to content

Commit 2394e38

Browse files
fix(modernjs): auto set enableAsyncEntry when bundler is rspack (#2939)
Co-authored-by: Zack Jackson <[email protected]>
1 parent 541494d commit 2394e38

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

.changeset/nice-crews-beg.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@module-federation/modern-js': patch
3+
---
4+
5+
fix(modernjs): auto set enableAsyncEntry when bundler is rspack

packages/modernjs/src/cli/configPlugin.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,10 @@ export const moduleFederationConfigPlugin = (
127127
FEDERATION_IPV4: JSON.stringify(ipv4),
128128
REMOTE_IP_STRATEGY: JSON.stringify(userConfig.remoteIpStrategy),
129129
},
130+
enableAsyncEntry:
131+
bundlerType === 'rspack'
132+
? modernjsConfig.source?.enableAsyncEntry ?? true
133+
: modernjsConfig.source?.enableAsyncEntry,
130134
},
131135
dev: {
132136
assetPrefix: modernjsConfig?.dev?.assetPrefix

packages/modernjs/src/cli/ssrPlugin.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -42,16 +42,7 @@ export const moduleFederationSSRPlugin = (
4242
return { entrypoint, plugins };
4343
},
4444
config: async () => {
45-
const bundlerType =
46-
useAppContext().bundlerType === 'rspack' ? 'rspack' : 'webpack';
47-
4845
return {
49-
source: {
50-
enableAsyncEntry:
51-
bundlerType === 'rspack'
52-
? modernjsConfig.source?.enableAsyncEntry ?? true
53-
: modernjsConfig.source?.enableAsyncEntry,
54-
},
5546
tools: {
5647
rspack(config, { isServer }) {
5748
if (isServer) {

0 commit comments

Comments
 (0)