feat(enhanced): implement multiple share scope support (#3524)

Co-authored-by: Hanric <[email protected]>

Author: ScriptedAlchemy

.cursorignore

@@ -1,77 +0,0 @@
-# Cache and temporary files
-**/.cache/
-**/.temp/
-**/coverage/
-**/dist/
-
-# Documentation and config files
-**/*.md
-**/*.yaml
-**/*.yml
-**/.eslintrc*
-**/.prettierrc*
-**/.swcrc
-**/jest.config.*
-**/tsconfig.*
-**/*/stats.json
-
-# First ignore everything
-*
-
-# Then allow specific packages and their contents
-!packages/webpack-bundler-runtime/
-!packages/webpack-bundler-runtime/**/*
-!packages/sdk/
-!packages/sdk/**/*
-!packages/enhanced/
-!packages/enhanced/**/*
-
-# Allow package.json files
-!package.json
-!packages/*/package.json
-!**/package.json
-
-# Explicitly ignore specific packages
-packages/dts-plugin/
-packages/typescript/
-packages/native-*
-packages/core/
-packages/assemble-release-plan/
-packages/native-federation-typescript/
-packages/esbuild/
-
-# Ignore specific directories
-apps/
-webpack/tooling/
-webpack/setup/
-webpack/test/
-webpack/benchmark/
-tools/
-.husky/
-.github/
-.vscode/
-.verdaccio/
-
-!apps/manifest-demo/*.ts
-
-# Ignore specific files
-.cursorignore
-jest.preset.js
-babel.config.json
-nx.json
-LICENSE
-.nxignore
-netlify.toml
-renovate.json
-.npmrc
-.cursorrules
-.prettierignore
-.editorconfig
-ai-lint-fix.js
-manifest.json
-typedoc.json
-typedoc.base.json
-commitlint.config.js
-.eslintignore
-commit-gen.js
-main.py

package.json

@@ -23,7 +23,7 @@
     "commit": "cz",
     "docs": "typedoc",
     "f": "nx format:write",
-    "enhanced:jest": "pnpm build && cd packages/enhanced && NODE_OPTIONS=--experimental-vm-modules npx jest test/ConfigTestCases.basictest.js",
+    "enhanced:jest": "pnpm build && cd packages/enhanced && NODE_OPTIONS=--experimental-vm-modules npx jest test/ConfigTestCases.basictest.js test/unit",
     "lint": "nx run-many --target=lint",
     "test": "nx run-many --target=test",
     "build": "nx run-many --target=build --parallel=5  --projects=tag:type:pkg",

packages/enhanced/jest.config.ts

@@ -33,7 +33,10 @@ export default {
   moduleFileExtensions: ['ts', 'js', 'html'],
   coverageDirectory: '../../coverage/packages/enhanced',
   rootDir: __dirname,
-  testMatch: ['<rootDir>/test/*.basictest.js'],
+  testMatch: [
+    '<rootDir>/test/*.basictest.js',
+    '<rootDir>/test/unit/**/*.test.ts',
+  ],
 
   testEnvironment: path.resolve(__dirname, './test/patch-node-env.js'),
   setupFilesAfterEnv: ['<rootDir>/test/setupTestFramework.js'],

packages/enhanced/src/declarations/plugins/sharing/ConsumeSharedModule.d.ts

@@ -18,7 +18,7 @@ export type ConsumeOptions = {
   /**
    * share scope
    */
-  shareScope: string;
+  shareScope: string | string[];
   /**
    * version requirement
    */

packages/enhanced/src/declarations/plugins/sharing/ConsumeSharedPlugin.d.ts

@@ -24,7 +24,7 @@ export interface ConsumeSharedPluginOptions {
   /**
    * Share scope name used for all consumed modules (defaults to 'default').
    */
-  shareScope?: string;
+  shareScope?: string | string[];
 }
 /**
  * Modules that should be consumed from share scope. Property names are used to match requested modules in this compilation. Relative requests are resolved, module requests are matched unresolved, absolute paths will match resolved requests. A trailing slash will match all requests with this prefix. In this case shareKey must also have a trailing slash.
@@ -62,7 +62,7 @@ export interface ConsumesConfig {
   /**
    * Share scope name.
    */
-  shareScope?: string;
+  shareScope?: string | string[];
   /**
    * Allow only a single version of the shared module in share scope (disabled by default).
    */

packages/enhanced/src/declarations/plugins/sharing/ProvideSharedPlugin.d.ts

@@ -21,7 +21,7 @@ export interface ProvideSharedPluginOptions {
   /**
    * Share scope name used for all provided modules (defaults to 'default').
    */
-  shareScope?: string;
+  shareScope?: string | string[];
 }
 /**
  * Modules that should be provided as shared modules to the share scope. Property names are used as share keys.
@@ -47,7 +47,7 @@ export interface ProvidesConfig {
   /**
    * Share scope name.
    */
-  shareScope?: string;
+  shareScope?: string | string[];
   /**
    * Version of the provided module. Will replace lower matching versions, but not higher.
    */

packages/enhanced/src/declarations/plugins/sharing/SharePlugin.d.ts

@@ -20,7 +20,7 @@ export interface SharePluginOptions {
   /**
    * Share scope name used for all shared modules (defaults to 'default').
    */
-  shareScope?: string;
+  shareScope?: string | string[];
   /**
    * Modules that should be shared in the share scope. When provided, property names are used to match requested modules in this compilation.
    */
@@ -62,7 +62,7 @@ export interface SharedConfig {
   /**
    * Share scope name.
    */
-  shareScope?: string;
+  shareScope?: string | string[];
   /**
    * Allow only a single version of the shared module in share scope (disabled by default).
    */

packages/enhanced/src/lib/container/ContainerEntryDependency.ts

@@ -18,21 +18,21 @@ const { Dependency } = require(
 class ContainerEntryDependency extends Dependency {
   public name: string;
   public exposes: [string, ExposeOptions][];
-  public shareScope: string;
+  public shareScope: string | string[];
   public injectRuntimeEntry: string;
   public dataPrefetch: containerPlugin.ContainerPluginOptions['dataPrefetch'];
 
   /**
    * @param {string} name entry name
    * @param {[string, ExposeOptions][]} exposes list of exposed modules
-   * @param {string} shareScope name of the share scope
+   * @param {string|string[]} shareScope name of the share scope
    * @param {string[]} injectRuntimeEntry the path of injectRuntime file.
    * @param {containerPlugin.ContainerPluginOptions['dataPrefetch']} dataPrefetch whether enable dataPrefetch
    */
   constructor(
     name: string,
     exposes: [string, ExposeOptions][],
-    shareScope: string,
+    shareScope: string | string[],
     injectRuntimeEntry: string,
     dataPrefetch: containerPlugin.ContainerPluginOptions['dataPrefetch'],
   ) {

packages/enhanced/src/lib/container/ContainerEntryModule.ts

@@ -62,21 +62,21 @@ export type ExposeOptions = {
 class ContainerEntryModule extends Module {
   private _name: string;
   private _exposes: [string, ExposeOptions][];
-  private _shareScope: string;
+  private _shareScope: string | string[];
   private _injectRuntimeEntry: string;
   private _dataPrefetch: containerPlugin.ContainerPluginOptions['dataPrefetch'];
 
   /**
    * @param {string} name container entry name
    * @param {[string, ExposeOptions][]} exposes list of exposed modules
-   * @param {string} shareScope name of the share scope
+   * @param {string|string[]} shareScope name of the share scope
    * @param {string} injectRuntimeEntry the path of injectRuntime file.
    * @param {containerPlugin.ContainerPluginOptions['dataPrefetch']} dataPrefetch whether enable dataPrefetch
    */
   constructor(
     name: string,
     exposes: [string, ExposeOptions][],
-    shareScope: string,
+    shareScope: string | string[],
     injectRuntimeEntry: string,
     dataPrefetch: containerPlugin.ContainerPluginOptions['dataPrefetch'],
   ) {
@@ -115,7 +115,11 @@ class ContainerEntryModule extends Module {
    * @returns {string} a unique identifier of the module
    */
   override identifier(): string {
-    return `container entry (${this._shareScope}) ${JSON.stringify(
+    const scopeStr = Array.isArray(this._shareScope)
+      ? this._shareScope.join('|')
+      : this._shareScope;
+
+    return `container entry (${scopeStr}) ${JSON.stringify(
       this._exposes,
     )} ${this._injectRuntimeEntry} ${JSON.stringify(this._dataPrefetch)}`;
   }

packages/enhanced/src/lib/container/ContainerReferencePlugin.ts

@@ -109,7 +109,7 @@ class ContainerReferencePlugin {
 
         normalModuleFactory.hooks.factorize.tap(
           'ContainerReferencePlugin',
-          // @ts-ignore
+          //@ts-ignore
           (data) => {
             if (!data.request.includes('!')) {
               for (const [key, config] of remotes) {