chore: upgrade nx (#3774)

Author: ScriptedAlchemy

.changeset/spotty-buttons-cough.md

@@ -0,0 +1,5 @@
+---
+'@module-federation/storybook-addon': patch
+---
+
+fix type error with nx update

.cursor/mcp.json

@@ -0,0 +1,7 @@
+{
+  "mcpServers": {
+    "nx-mcp": {
+      "url": "http://localhost:9442/sse"
+    }
+  }
+}

.cursorignore

@@ -4,11 +4,6 @@
 **/coverage/
 **/dist/
 
-# Documentation and config files
-**/*.yaml
-**/*.yml
-
-
 # Explicitly ignore specific packages
 packages/typescript/
 packages/native-*
@@ -24,7 +19,6 @@ webpack/test/
 webpack/benchmark/
 tools/
 .husky/
-.github/
 .verdaccio/
 
 
@@ -33,7 +27,6 @@ tools/
 .cursorignore
 jest.preset.js
 babel.config.json
-nx.json
 LICENSE
 .nxignore
 netlify.toml

.github/workflows/build-and-test.yml

@@ -9,6 +9,7 @@ on:
 jobs:
   checkout-install:
     runs-on: ubuntu-latest
+    timeout-minutes: 30
     steps:
       - name: Checkout Repository
         uses: actions/checkout@v3
@@ -26,23 +27,39 @@ jobs:
           node-version: '18'
           cache: 'pnpm'
 
+      - name: Cache Browsers
+        uses: actions/cache@v3
+        id: browsers-cache
+        with:
+          path: |
+            ~/.cache/ms-playwright
+            ~/.cache/Cypress
+          key: ${{ runner.os }}-browsers-${{ hashFiles('**/pnpm-lock.yaml') }}
+
+      - name: Set Playwright cache status
+        run: echo "PLAYWRIGHT_CACHE_HIT=${{ steps.browsers-cache.outputs.cache-hit }}" >> $GITHUB_ENV
+
       - name: Set Nx SHA
         uses: nrwl/nx-set-shas@v3
 
       - name: Install Dependencies
         run: pnpm install
 
       - name: Install Cypress
+        # if: steps.browsers-cache.outputs.cache-hit != 'true'
         run: npx cypress install
 
       - name: Check Code Format
         run: npx nx format:check
 
+      - name: Print Number of CPU Cores
+        run: nproc
+
       - name: Warm Nx Cache
-        run: npx nx run-many --targets=build --projects=tag:type:pkg
+        run: npx nx run-many --targets=build --projects=tag:type:pkg --parallel=4
 
       - name: Run Build for All
-        run: npx nx run-many --targets=build --projects=tag:type:pkg --skip-nx-cache
+        run: npx nx run-many --targets=build --projects=tag:type:pkg --parallel=4 --skip-nx-cache
 
       - name: Check Package Publishing Compatibility
         run: |
@@ -63,7 +80,7 @@ jobs:
         with:
           max_attempts: 2
           timeout_minutes: 10
-          command: npx nx affected -t test --parallel=3 --exclude='*,!tag:type:pkg' --skip-nx-cache
+          command: npx nx affected -t test --parallel=3 --exclude='*,!tag:type:pkg'
 
       - name: Run Affected Experimental Tests
         uses: nick-fields/retry@v3

.github/workflows/devtools.yml

@@ -13,6 +13,7 @@ env:
 jobs:
   main:
     runs-on: ubuntu-latest
+    timeout-minutes: 30
     steps:
       - name: Checkout Repository
         uses: actions/checkout@v3

.github/workflows/e2e-manifest.yml

@@ -7,6 +7,7 @@ on:
 jobs:
   e2e-manifest:
     runs-on: ubuntu-latest
+    timeout-minutes: 30
     steps:
       - name: Checkout Repository
         uses: actions/checkout@v3
@@ -45,7 +46,7 @@ jobs:
 
       - name: E2E Test for Manifest Demo Development
         if: steps.check-ci.outcome == 'success'
-        run: pnpm run app:manifest:dev & echo "done" && npx wait-on tcp:3009 && npx wait-on tcp:3012 && npx wait-on http://127.0.0.1:4001/ && npx nx run-many --target=e2e --projects=manifest-webpack-host --parallel=1 && npx kill-port 3013 3009 3010 3011 3012 4001
+        run: pnpm run app:manifest:dev & echo "done" && npx wait-on tcp:3009 && npx wait-on tcp:3012 && npx wait-on http://127.0.0.1:4001/ && npx nx run-many --target=e2e --projects=manifest-webpack-host --parallel=2 && npx kill-port 3013 3009 3010 3011 3012 4001
 
       - name: E2E Test for Manifest Demo Production
         if: steps.check-ci.outcome == 'success'

.github/workflows/e2e-modern-ssr.yml

@@ -6,6 +6,7 @@ on:
 jobs:
   e2e-modern:
     runs-on: ubuntu-latest
+    timeout-minutes: 30
     steps:
       - name: Checkout Repository
         uses: actions/checkout@v3
@@ -44,20 +45,20 @@ jobs:
 
       - name: E2E Test for Modern.js SSR
         if: steps.check-ci.outcome == 'success'
-        run: |
-          lsof -ti tcp:3050,3051,3052,3053,3054,3055,3056 | xargs -r kill &&
-          pnpm run app:modern:dev &
-          sleep 30 &&
-          # wait response content-type is application/json
-          for port in 3050 3051 3052 3053 3054 3055 3056; do
-            while true; do
-              response=$(curl -s -I http://127.0.0.1:$port/mf-manifest.json)
-              content_type=$(echo "$response" | grep -i "Content-Type" | awk '{print $2}' | tr -d '\r')
-              if [[ $content_type != *"text/html"* ]]; then
-                break
-              fi
-              sleep 1
+        uses: nick-fields/retry@v3
+        with:
+          max_attempts: 2
+          timeout_minutes: 10
+          command: |
+            lsof -ti tcp:3050,3051,3052,3053,3054,3055,3056 | xargs -r kill &&
+            pnpm run app:modern:dev &
+            sleep 30 &&
+            for port in 3050 3051 3052 3053 3054 3055 3056; do
+              while true; do
+                response=$(curl -s http://127.0.0.1:$port/mf-manifest.json)
+                if echo "$response" | jq empty >/dev/null 2>&1; then
+                  break
+                fi
+                sleep 1
+              done
             done
-          done
-          npx nx run modernjs-ssr-host:e2e &&
-          lsof -ti tcp:3050,3051,3052,3053,3054,3055,3056 | xargs kill

.github/workflows/e2e-modern.yml

@@ -7,6 +7,7 @@ on:
 jobs:
   e2e-modern:
     runs-on: ubuntu-latest
+    timeout-minutes: 30
     steps:
       - name: Checkout Repository
         uses: actions/checkout@v3

.github/workflows/e2e-next-dev.yml

@@ -6,6 +6,7 @@ on:
 jobs:
   e2e-next-dev:
     runs-on: ubuntu-latest
+    timeout-minutes: 30
     steps:
       - name: Checkout Repository
         uses: actions/checkout@v3
@@ -44,15 +45,20 @@ jobs:
       - name: Run condition check script
         id: check-ci
         run: node tools/scripts/ci-is-affected.mjs --appName=3000-home
+      - name: E2E Test for Next.js Dev - Home
+        if: steps.check-ci.outcome == 'success'
+        run: |
+          killall node
+          npx nx run 3000-home:test:e2e
+
+      - name: E2E Test for Next.js Dev - Shop
+        if: steps.check-ci.outcome == 'success'
+        run: |
+          killall node
+          npx nx run 3001-shop:test:e2e
 
-      - name: E2E Test for Next.js Dev
+      - name: E2E Test for Next.js Dev - Checkout
         if: steps.check-ci.outcome == 'success'
         run: |
-          npx kill-port 3000,3001,3002 &&
-          pnpm run app:next:dev &
-          sleep 1 &&
-          npx wait-on tcp:3001 &&
-          npx wait-on tcp:3002 &&
-          npx wait-on tcp:3000 &&
-          npx nx run-many --target=test:e2e --projects=3000-home,3001-shop,3002-checkout --parallel=1 &&
-          npx kill-port 3000,3001,3002
+          killall node
+          npx nx run 3002-checkout:test:e2e

.github/workflows/e2e-next-prod.yml

@@ -6,6 +6,7 @@ on:
 jobs:
   e2e-next-prod:
     runs-on: ubuntu-latest
+    timeout-minutes: 30
     steps:
       - name: Checkout Repository
         uses: actions/checkout@v3
@@ -42,14 +43,20 @@ jobs:
         id: check-ci
         run: node tools/scripts/ci-is-affected.mjs --appName=3000-home
 
-      - name: E2E Test for Next.js Prod
+      - name: E2E Test for Next.js Prod - Home
         if: steps.check-ci.outcome == 'success'
         run: |
-          pnpm run --filter @module-federation/3002-checkout --filter @module-federation/3000-home --filter @module-federation/3001-shop build &&
-          pnpm run app:next:prod &
-          sleep 4 &&
-          npx wait-on tcp:3001 &&
-          npx wait-on tcp:3002 &&
-          npx wait-on tcp:3000 &&
-          npx nx run-many --target=test:e2e --projects=3000-home,3001-shop,3002-checkout --parallel=1 &&
-          npx kill-port 3000,3001,3002
+          killall node
+          npx nx run 3000-home:test:e2e:production
+
+      - name: E2E Test for Next.js Prod - Shop
+        if: steps.check-ci.outcome == 'success'
+        run: |
+          killall node
+          npx nx run 3001-shop:test:e2e:production
+
+      - name: E2E Test for Next.js Prod - Checkout
+        if: steps.check-ci.outcome == 'success'
+        run: |
+          killall node
+          npx nx run 3002-checkout:test:e2e:production