Fix/relative path (#2610)

Author: ilteoood

.changeset/forty-dolls-sell.md

@@ -0,0 +1,6 @@
+---
+'@module-federation/native-federation-typescript': patch
+'@module-federation/native-federation-tests': patch
+---
+
+ability to use relative paths

packages/native-federation-tests/src/configurations/hostPlugin.test.ts

@@ -7,7 +7,7 @@ describe('hostPlugin', () => {
     name: 'moduleFederationHost',
     filename: 'remoteEntry.js',
     remotes: {
-      moduleFederationTypescript: 'http://localhost:3000/remoteEntry.js',
+      moduleFederationTests: 'http://localhost:3000/remoteEntry.js',
     },
     shared: {
       react: { singleton: true, eager: true },
@@ -37,7 +37,7 @@ describe('hostPlugin', () => {
         });
 
         expect(mapRemotesToDownload).toStrictEqual({
-          moduleFederationTypescript: 'http://localhost:3000/@mf-tests.zip',
+          moduleFederationTests: 'http://localhost:3000/@mf-tests.zip',
         });
       });
 
@@ -56,7 +56,7 @@ describe('hostPlugin', () => {
         expect(hostOptions).toStrictEqual(options);
 
         expect(mapRemotesToDownload).toStrictEqual({
-          moduleFederationTypescript: 'http://localhost:3000/custom-tests.zip',
+          moduleFederationTests: 'http://localhost:3000/custom-tests.zip',
         });
       });
     });
@@ -65,7 +65,7 @@ describe('hostPlugin', () => {
       const subpathModuleFederationConfig = {
         ...moduleFederationConfig,
         remotes: {
-          moduleFederationTypescript:
+          moduleFederationTests:
             'http://localhost:3000/subpatha/subpathb/remoteEntry.js',
         },
       };
@@ -75,9 +75,26 @@ describe('hostPlugin', () => {
       });
 
       expect(mapRemotesToDownload).toStrictEqual({
-        moduleFederationTypescript:
+        moduleFederationTests:
           'http://localhost:3000/subpatha/subpathb/@mf-tests.zip',
       });
     });
+
+    it('correctly resolve remotes with relative reference in place of absolute url', () => {
+      const subpathModuleFederationConfig = {
+        ...moduleFederationConfig,
+        remotes: {
+          moduleFederationTests: '/subpatha/remoteEntry.js',
+        },
+      };
+
+      const { mapRemotesToDownload } = retrieveHostConfig({
+        moduleFederationConfig: subpathModuleFederationConfig,
+      });
+
+      expect(mapRemotesToDownload).toStrictEqual({
+        moduleFederationTests: '/subpatha/@mf-tests.zip',
+      });
+    });
   });
 });

packages/native-federation-tests/src/configurations/hostPlugin.ts

@@ -12,17 +12,21 @@ const retrieveRemoteStringUrl = (remote: string) => {
   return splittedRemote[splittedRemote.length - 1];
 };
 
+const FILE_PROTOCOL = 'file:';
+
 const buildZipUrl = (hostOptions: Required<HostOptions>, remote: string) => {
   const remoteStringUrl = retrieveRemoteStringUrl(remote);
-  const remoteUrl = new URL(remoteStringUrl);
+  const remoteUrl = new URL(remoteStringUrl, FILE_PROTOCOL);
 
   const pathnameWithoutEntry = remoteUrl.pathname
     .split('/')
     .slice(0, -1)
     .join('/');
   remoteUrl.pathname = `${pathnameWithoutEntry}/${hostOptions.testsFolder}.zip`;
 
-  return remoteUrl.href;
+  return remoteUrl.protocol === FILE_PROTOCOL
+    ? remoteUrl.pathname
+    : remoteUrl.href;
 };
 
 const resolveRemotes = (hostOptions: Required<HostOptions>) => {

packages/native-federation-typescript/src/configurations/hostPlugin.test.ts

@@ -77,5 +77,22 @@ describe('hostPlugin', () => {
           'http://localhost:3000/subpatha/subpathb/@mf-types.zip',
       });
     });
+
+    it('correctly resolve remotes with relative reference in place of absolute url', () => {
+      const subpathModuleFederationConfig = {
+        ...moduleFederationConfig,
+        remotes: {
+          moduleFederationTypescript: '/subpatha/remoteEntry.js',
+        },
+      };
+
+      const { mapRemotesToDownload } = retrieveHostConfig({
+        moduleFederationConfig: subpathModuleFederationConfig,
+      });
+
+      expect(mapRemotesToDownload).toStrictEqual({
+        moduleFederationTypescript: '/subpatha/@mf-types.zip',
+      });
+    });
   });
 });

packages/native-federation-typescript/src/configurations/hostPlugin.ts

@@ -11,17 +11,21 @@ const retrieveRemoteStringUrl = (remote: string) => {
   return splittedRemote[splittedRemote.length - 1];
 };
 
+const FILE_PROTOCOL = 'file:';
+
 const buildZipUrl = (hostOptions: Required<HostOptions>, remote: string) => {
   const remoteStringUrl = retrieveRemoteStringUrl(remote);
-  const remoteUrl = new URL(remoteStringUrl);
+  const remoteUrl = new URL(remoteStringUrl, FILE_PROTOCOL);
 
   const pathnameWithoutEntry = remoteUrl.pathname
     .split('/')
     .slice(0, -1)
     .join('/');
   remoteUrl.pathname = `${pathnameWithoutEntry}/${hostOptions.typesFolder}.zip`;
 
-  return remoteUrl.href;
+  return remoteUrl.protocol === FILE_PROTOCOL
+    ? remoteUrl.pathname
+    : remoteUrl.href;
 };
 
 const resolveRemotes = (hostOptions: Required<HostOptions>) => {