Skip to content

Commit 32eba3c

Browse files
authored
fix: chunkId may equal number 0 (#2306)
1 parent d94e413 commit 32eba3c

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

.changeset/quiet-ways-shake.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@module-federation/enhanced': patch
3+
---
4+
5+
fix: chunkId may equal number 0

packages/enhanced/src/lib/sharing/ConsumeSharedRuntimeModule.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,9 @@ class ConsumeSharedRuntimeModule extends RuntimeModule {
9999
'consume-shared',
100100
);
101101
if (!modules) continue;
102-
if (!chunk.id) continue;
102+
// chunk.id may equal 0
103+
if (chunk.id === null || (typeof chunk.id === 'string' && !chunk.id))
104+
continue;
103105

104106
addModules(
105107
modules,

0 commit comments

Comments
 (0)