perf: remove live binding from cjs builds (#3701)

Author: ScriptedAlchemy

.changeset/small-baboons-nail.md

@@ -0,0 +1,36 @@
+---
+'@module-federation/inject-external-runtime-core-plugin': patch
+'@module-federation/bridge-react-webpack-plugin': patch
+'@module-federation/third-party-dts-extractor': patch
+'create-module-federation': patch
+'@module-federation/webpack-bundler-runtime': patch
+'@module-federation/bridge-shared': patch
+'@module-federation/bridge-react': patch
+'@module-federation/bridge-vue3': patch
+'@module-federation/devtools': patch
+'@module-federation/storybook-addon': patch
+'@module-federation/rsbuild-plugin': patch
+'@module-federation/data-prefetch': patch
+'@module-federation/runtime-tools': patch
+'@module-federation/retry-plugin': patch
+'@module-federation/runtime-core': patch
+'@module-federation/error-codes': patch
+'@module-federation/dts-plugin': patch
+'@module-federation/nextjs-mf': patch
+'@module-federation/utilities': patch
+'@module-federation/enhanced': patch
+'@module-federation/managers': patch
+'@module-federation/manifest': patch
+'@module-federation/modern-js': patch
+'bundle-size': patch
+'website-new': patch
+'@module-federation/esbuild': patch
+'@module-federation/runtime': patch
+'@module-federation/rspack': patch
+'@module-federation/modernjsapp': patch
+'@module-federation/node': patch
+'@module-federation/cli': patch
+'@module-federation/sdk': patch
+---
+
+Disable live bindings on cjs builds of the runtime packages

packages/error-codes/rollup.config.js

@@ -11,6 +11,7 @@ module.exports = (rollupConfig, projectOptions) => {
         c.format === 'esm'
           ? c.chunkFileNames.replace('.js', '.mjs')
           : c.chunkFileNames,
+      ...(c.format === 'cjs' ? { externalLiveBindings: false } : {}),
     }));
   } else {
     rollupConfig.output = {
@@ -25,6 +26,9 @@ module.exports = (rollupConfig, projectOptions) => {
         rollupConfig.output.format === 'esm'
           ? rollupConfig.output.chunkFileNames.replace('.js', '.mjs')
           : rollupConfig.output.chunkFileNames,
+      ...(rollupConfig.output.format === 'cjs'
+        ? { externalLiveBindings: false }
+        : {}),
     };
   }
 

packages/runtime-core/rollup.config.cjs

@@ -36,6 +36,7 @@ module.exports = (rollupConfig, projectOptions) => {
         c.format === 'cjs'
           ? c.chunkFileNames.replace('.js', '.cjs')
           : c.chunkFileNames,
+      ...(c.format === 'cjs' ? { externalLiveBindings: false } : {}),
     }));
   } else {
     rollupConfig.output = {
@@ -54,6 +55,9 @@ module.exports = (rollupConfig, projectOptions) => {
         rollupConfig.output.format === 'cjs'
           ? rollupConfig.output.chunkFileNames.replace('.js', '.cjs')
           : rollupConfig.output.chunkFileNames,
+      ...(rollupConfig.output.format === 'cjs'
+        ? { externalLiveBindings: false }
+        : {}),
     };
   }
 

packages/runtime-core/src/global.ts

@@ -11,7 +11,6 @@ import {
   ModuleInfo,
   isDebugMode,
 } from '@module-federation/sdk';
-import { getBuilderId } from './utils/env';
 import { warn } from './utils/logger';
 import { FederationRuntimePlugin } from './type/plugin';
 

packages/runtime-plugins/inject-external-runtime-core-plugin/rollup.config.cjs

@@ -33,6 +33,7 @@ module.exports = (rollupConfig, _projectOptions) => {
         c.format === 'cjs'
           ? c.chunkFileNames.replace('.js', '.cjs')
           : c.chunkFileNames,
+      ...(c.format === 'cjs' ? { externalLiveBindings: false } : {}),
     }));
   } else {
     rollupConfig.output = {
@@ -51,6 +52,9 @@ module.exports = (rollupConfig, _projectOptions) => {
         rollupConfig.output.format === 'cjs'
           ? rollupConfig.output.chunkFileNames.replace('.js', '.cjs')
           : rollupConfig.output.chunkFileNames,
+      ...(rollupConfig.output.format === 'cjs'
+        ? { externalLiveBindings: false }
+        : {}),
     };
   }
 

packages/runtime-tools/rollup.config.cjs

@@ -1,4 +1,4 @@
-module.exports = (rollupConfig) => {
+module.exports = function (rollupConfig) {
   rollupConfig.input = {
     index: 'packages/runtime-tools/src/index.ts',
     runtime: 'packages/runtime-tools/src/runtime.ts',
@@ -7,23 +7,28 @@ module.exports = (rollupConfig) => {
     'runtime-core': 'packages/runtime-tools/src/runtime-core.ts',
   };
 
-  // Check if output is an array and add hoistTransitiveImports: false
   if (Array.isArray(rollupConfig.output)) {
-    rollupConfig.output = rollupConfig.output.map((c) => ({
-      ...c,
-      hoistTransitiveImports: false,
-      entryFileNames:
-        c.format === 'cjs'
-          ? c.entryFileNames.replace('.js', '.cjs')
-          : c.entryFileNames,
-      chunkFileNames:
-        c.format === 'cjs'
-          ? c.chunkFileNames.replace('.js', '.cjs')
-          : c.chunkFileNames,
-    }));
+    rollupConfig.output = rollupConfig.output.map(function (c) {
+      var outputConfig = Object.assign({}, c, {
+        hoistTransitiveImports: false,
+        entryFileNames:
+          c.format === 'cjs'
+            ? c.entryFileNames.replace('.js', '.cjs')
+            : c.entryFileNames,
+        chunkFileNames:
+          c.format === 'cjs'
+            ? c.chunkFileNames.replace('.js', '.cjs')
+            : c.chunkFileNames,
+      });
+
+      if (c.format === 'cjs') {
+        outputConfig.externalLiveBindings = false;
+      }
+
+      return outputConfig;
+    });
   } else {
-    rollupConfig.output = {
-      ...rollupConfig.output,
+    var outputConfig = Object.assign({}, rollupConfig.output, {
       hoistTransitiveImports: false,
       entryFileNames:
         rollupConfig.output.format === 'cjs'
@@ -33,7 +38,12 @@ module.exports = (rollupConfig) => {
         rollupConfig.output.format === 'cjs'
           ? rollupConfig.output.chunkFileNames.replace('.js', '.cjs')
           : rollupConfig.output.chunkFileNames,
-    };
+    });
+
+    if (rollupConfig.output.format === 'cjs') {
+      outputConfig.externalLiveBindings = false;
+    }
+    rollupConfig.output = outputConfig;
   }
 
   return rollupConfig;