Skip to content

Commit 3ba956d

Browse files
authored
chore: re export preset path for rsbuild (#3155)
1 parent 8d34aa8 commit 3ba956d

File tree

10 files changed

+56
-35
lines changed

10 files changed

+56
-35
lines changed

.changeset/hungry-ghosts-matter.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
'@module-federation/storybook-addon': patch
3+
---
4+
chore: re export preset path for rsbuild

apps/rslib-module/.storybook/main.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ const config: StorybookConfig = {
1717
},
1818
addons: [
1919
{
20-
name: '@module-federation/storybook-addon/preset.js',
20+
name: '@module-federation/storybook-addon/preset',
2121
options: {
2222
remotes: {
2323
'rslib-module':

apps/rslib-module/README.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,16 @@ nx serve rslib-module
1818

1919
Dev package
2020

21+
1.
22+
23+
```
24+
nx serve rslib-module
25+
```
26+
27+
2.
28+
2129
```
22-
nx serve rslib-module & nx storybook rslib-module
30+
nx storybook rslib-module
2331
```
2432

2533
visit http://localhost:6006

packages/storybook-addon/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ const config: StorybookConfig = {
6161
},
6262
addons: [
6363
{
64-
name: '@module-federation/storybook-addon/preset.js',
64+
name: '@module-federation/storybook-addon/preset',
6565
options: {
6666
// add remote here and then you can load remote in your story
6767
remotes: {

packages/storybook-addon/package.json

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,19 @@
1818
"README.md"
1919
],
2020
"author": "Fiodorov Andrei <[email protected]> (https://github.com/fyodorovandrei)",
21+
"main": "dist/src/index.js",
22+
"module": "dist/src/index.js",
23+
"types": "dist/src/index.d.ts",
2124
"exports": {
2225
".": {
2326
"import": "./dist/src/index.js",
2427
"require": "./dist/src/index.js",
25-
"types": "./dist/src/indexd.ts"
28+
"types": "./dist/src/index.d.ts"
29+
},
30+
"./preset": {
31+
"import": "./dist/preset.js",
32+
"require": "./dist/preset.js",
33+
"types": "./dist/preset.d.ts"
2634
},
2735
"./*": "./*"
2836
},
@@ -33,9 +41,11 @@
3341
]
3442
}
3543
},
36-
"devDependencies": {
44+
"dependencies": {
3745
"@module-federation/enhanced": "workspace:*",
38-
"@module-federation/sdk": "workspace:*",
46+
"@module-federation/sdk": "workspace:*"
47+
},
48+
"devDependencies": {
3949
"@module-federation/utilities": "workspace:*",
4050
"@rsbuild/core": "^1.0.19",
4151
"@storybook/core-common": "7.6.20",

packages/storybook-addon/preset.js

Lines changed: 0 additions & 16 deletions
This file was deleted.

packages/storybook-addon/preset.ts

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
import { withModuleFederation } from './src/utils/with-module-federation-enhanced-rsbuild';
2+
3+
import type { RsbuildConfig } from '@rsbuild/core';
4+
import type { moduleFederationPlugin } from '@module-federation/sdk';
5+
6+
export default {
7+
rsbuildFinal: (
8+
config: RsbuildConfig,
9+
options: moduleFederationPlugin.ModuleFederationPluginOptions,
10+
) => {
11+
const { remotes, shared, name, shareStrategy } = options;
12+
13+
return withModuleFederation(config, {
14+
name,
15+
remotes,
16+
shared,
17+
shareStrategy,
18+
});
19+
},
20+
};

packages/storybook-addon/project.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,7 @@
1313
"outputPath": "packages/storybook-addon/dist",
1414
"main": "packages/storybook-addon/src/index.ts",
1515
"tsConfig": "packages/storybook-addon/tsconfig.lib.json",
16-
"assets": [
17-
"packages/storybook-addon/*.md",
18-
"packages/storybook-addon/preset.js"
19-
]
16+
"assets": ["packages/storybook-addon/*.md"]
2017
},
2118
"dependsOn": [
2219
{

packages/storybook-addon/tsconfig.lib.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@
55
"declaration": true,
66
"types": ["node"]
77
},
8-
"include": ["src/**/*.ts"],
8+
"include": ["src/**/*.ts", "preset.ts"],
99
"exclude": ["jest.config.ts", "src/**/*.spec.ts", "src/**/*.test.ts"]
1010
}

pnpm-lock.yaml

Lines changed: 6 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)