PR8: SharePlugin - Unified API (#3914)

Co-authored-by: Claude <[email protected]>

Author: ScriptedAlchemy

.claude/hooks/prompt-optimizer.js

@@ -209,7 +209,9 @@ async function main() {
         }
 
         // Skip optimization for very short or simple prompts that don't need enhancement
+        const wordCount = prompt.trim().split(/\s+/).length;
         if (
+          wordCount <= 4 ||
           prompt.length < 10 ||
           /^(hi|hello|hey|thanks|thank you)$/i.test(prompt.trim())
         ) {

.claude/settings.json

@@ -59,7 +59,9 @@ jobs:
         run: nproc
 
       - name: Run Build for All
-        run: npx nx run-many --targets=build --projects=tag:type:pkg --parallel=4
+        run: |
+          npx nx run-many --targets=build --projects=tag:type:pkg --parallel=4 --skip-nx-cache
+          npx nx run-many --targets=build --projects=tag:type:pkg --parallel=4
 
       - name: Check Package Publishing Compatibility
         run: |

.github/workflows/build-and-test.yml

@@ -124,6 +124,7 @@
     "@pmmmwh/react-refresh-webpack-plugin": "0.5.15",
     "@rollup/plugin-alias": "5.1.1",
     "@rollup/plugin-replace": "6.0.1",
+    "@rslib/core": "^0.10.4",
     "@rspack/core": "1.3.9",
     "@rspack/dev-server": "1.1.1",
     "@semantic-release/changelog": "^6.0.3",

apps/website/tmp/apps/website/tsconfig.tsbuildinfo

@@ -40,7 +40,9 @@ class SharePlugin {
       options.shared,
       (item, key) => {
         if (typeof item !== 'string')
-          throw new Error('Unexpected array in shared');
+          throw new Error(
+            `Unexpected array in shared configuration for key "${key}"`,
+          );
         const config: SharedConfig =
           item === key || !isRequiredVersion(item)
             ? {
@@ -112,6 +114,7 @@ class SharePlugin {
       shareScope: this._shareScope,
       consumes: this._consumes,
     }).apply(compiler);
+
     new ProvideSharedPlugin({
       shareScope: this._shareScope,
       provides: this._provides,

package.json

@@ -0,0 +1,290 @@
+/*
+ * @jest-environment node
+ */
+
+import { createMockCompiler } from '../utils';
+import webpack from 'webpack';
+import path from 'path';
+import SharePlugin from '../../../src/lib/sharing/SharePlugin';
+
+// Mock the child plugins to prevent deep integration testing
+jest.mock('../../../src/lib/sharing/ConsumeSharedPlugin', () => {
+  return jest.fn().mockImplementation(() => ({
+    apply: jest.fn(),
+  }));
+});
+
+jest.mock('../../../src/lib/sharing/ProvideSharedPlugin', () => {
+  return jest.fn().mockImplementation(() => ({
+    apply: jest.fn(),
+  }));
+});
+
+// Import mocked modules
+import ConsumeSharedPlugin from '../../../src/lib/sharing/ConsumeSharedPlugin';
+import ProvideSharedPlugin from '../../../src/lib/sharing/ProvideSharedPlugin';
+
+describe('SharePlugin Compiler Integration', () => {
+  let mockCompiler: webpack.Compiler;
+  let mockCompilation: webpack.Compilation;
+
+  beforeEach(() => {
+    mockCompiler = createMockCompiler();
+    mockCompilation = {
+      hooks: {
+        afterOptimizeChunks: {
+          tap: jest.fn(),
+        },
+        additionalTreeRuntimeRequirements: {
+          tap: jest.fn(),
+        },
+        runtimeRequirementInTree: {
+          for: jest.fn().mockReturnValue({ tap: jest.fn() }),
+        },
+      },
+      compiler: mockCompiler,
+      options: {
+        context: path.resolve(__dirname, '../../../'),
+      },
+      dependencyFactories: new Map(),
+      dependencyTemplates: new Map(),
+      addRuntimeModule: jest.fn(),
+      resolverFactory: {
+        get: jest.fn().mockReturnValue({
+          resolve: jest.fn(),
+        }),
+      },
+    } as any;
+
+    // Clear mocks before each test
+    (ConsumeSharedPlugin as jest.Mock).mockClear();
+    (ProvideSharedPlugin as jest.Mock).mockClear();
+  });
+
+  it('should integrate with webpack compilation lifecycle', () => {
+    const plugin = new SharePlugin({
+      shared: {
+        react: '^17.0.0',
+        lodash: {
+          requiredVersion: '^4.17.0',
+          singleton: true,
+        },
+      },
+    });
+
+    // Apply the plugin
+    plugin.apply(mockCompiler);
+
+    // Verify both child plugins are created and applied
+    expect(ConsumeSharedPlugin).toHaveBeenCalledTimes(1);
+    expect(ProvideSharedPlugin).toHaveBeenCalledTimes(1);
+
+    // Verify the plugins are applied to the compiler
+    const consumeInstance = (ConsumeSharedPlugin as jest.Mock).mock.results[0]
+      .value;
+    const provideInstance = (ProvideSharedPlugin as jest.Mock).mock.results[0]
+      .value;
+
+    expect(consumeInstance.apply).toHaveBeenCalledWith(mockCompiler);
+    expect(provideInstance.apply).toHaveBeenCalledWith(mockCompiler);
+  });
+
+  it('should handle advanced configuration with filters', () => {
+    const plugin = new SharePlugin({
+      shareScope: 'custom-scope',
+      shared: {
+        'react/': {
+          include: {
+            request: /components/,
+            version: '^17.0.0',
+          },
+          nodeModulesReconstructedLookup: true,
+        },
+        lodash: {
+          version: '4.17.21',
+          singleton: true,
+          eager: true,
+        },
+      },
+    });
+
+    // Should not throw during plugin application
+    expect(() => plugin.apply(mockCompiler)).not.toThrow();
+  });
+
+  it('should handle fallback version configuration', () => {
+    const plugin = new SharePlugin({
+      shared: {
+        react: {
+          include: {
+            version: '^17.0.0',
+            fallbackVersion: '17.0.0',
+          },
+        },
+        'utils/': {
+          exclude: {
+            version: '^2.0.0',
+            fallbackVersion: '2.0.0',
+          },
+        },
+      },
+    });
+
+    // Should not throw during plugin application
+    expect(() => plugin.apply(mockCompiler)).not.toThrow();
+  });
+
+  it('should handle layer configuration', () => {
+    const plugin = new SharePlugin({
+      shared: {
+        react: {
+          layer: 'framework',
+          issuerLayer: 'application',
+        },
+        utilities: {
+          layer: 'utilities',
+        },
+      },
+    });
+
+    // Should not throw during plugin application
+    expect(() => plugin.apply(mockCompiler)).not.toThrow();
+  });
+
+  it('should support multiple shareScopes', () => {
+    const plugin = new SharePlugin({
+      shareScope: ['primary', 'secondary'],
+      shared: {
+        react: '^17.0.0',
+        lodash: {
+          shareScope: 'custom',
+          requiredVersion: '^4.17.0',
+        },
+      },
+    });
+
+    // Should not throw during plugin application
+    expect(() => plugin.apply(mockCompiler)).not.toThrow();
+  });
+
+  it('should handle import false configuration', () => {
+    const plugin = new SharePlugin({
+      shared: {
+        react: {
+          import: false, // Only consume, don't provide
+          requiredVersion: '^17.0.0',
+        },
+        lodash: {
+          import: 'lodash-es', // Provide different module
+          requiredVersion: '^4.17.0',
+        },
+      },
+    });
+
+    // Should not throw during plugin application
+    expect(() => plugin.apply(mockCompiler)).not.toThrow();
+  });
+
+  it('should handle experiments configuration', () => {
+    const plugin = new SharePlugin({
+      shared: {
+        react: '^17.0.0',
+      },
+      experiments: {
+        nodeModulesReconstructedLookup: true,
+      },
+    });
+
+    // Should not throw during plugin application
+    expect(() => plugin.apply(mockCompiler)).not.toThrow();
+  });
+
+  it('should pass through all filtering options to child plugins', () => {
+    const plugin = new SharePlugin({
+      shareScope: 'test-scope',
+      shared: {
+        'components/': {
+          include: {
+            request: /Button|Modal/,
+            version: '^1.0.0',
+          },
+          nodeModulesReconstructedLookup: true,
+          singleton: true,
+          eager: false,
+        },
+        react: {
+          version: '17.0.0',
+          strictVersion: true,
+          packageName: 'react',
+          layer: 'framework',
+          issuerLayer: 'application',
+        },
+      },
+    });
+
+    // Should create valid plugin instance
+    expect(plugin).toBeInstanceOf(SharePlugin);
+
+    // Should not throw during plugin application
+    expect(() => plugin.apply(mockCompiler)).not.toThrow();
+  });
+
+  describe('helper methods integration', () => {
+    it('should provide debugging information about shared modules', () => {
+      const plugin = new SharePlugin({
+        shareScope: 'debug-scope',
+        shared: {
+          react: '^17.0.0',
+          lodash: {
+            import: false,
+            requiredVersion: '^4.17.0',
+          },
+          'utils/': {
+            version: '1.0.0',
+            nodeModulesReconstructedLookup: true,
+          },
+        },
+      });
+
+      // Test all helper methods
+      const options = plugin.getOptions();
+      expect(options.shareScope).toBe('debug-scope');
+
+      const shareScope = plugin.getShareScope();
+      expect(shareScope).toBe('debug-scope');
+
+      const consumes = plugin.getConsumes();
+      expect(consumes).toHaveLength(3);
+
+      const provides = plugin.getProvides();
+      expect(provides).toHaveLength(2); // lodash excluded due to import: false
+
+      const sharedInfo = plugin.getSharedInfo();
+      expect(sharedInfo).toEqual({
+        totalShared: 3,
+        consumeOnly: 1,
+        provideAndConsume: 2,
+        shareScopes: ['debug-scope'],
+      });
+    });
+
+    it('should validate configurations during construction', () => {
+      expect(() => {
+        new SharePlugin({
+          shared: {},
+        });
+      }).not.toThrow();
+
+      expect(() => {
+        new SharePlugin({
+          shared: {
+            react: {
+              include: { version: '^17.0.0' },
+              exclude: { version: '^16.0.0' },
+            },
+          },
+        });
+      }).not.toThrow();
+    });
+  });
+});