fix: no delete exist types if fetch new types failed (#2634)

Author: 2heal1

.changeset/mighty-goats-hang.md

@@ -0,0 +1,5 @@
+---
+'@module-federation/dts-plugin': patch
+---
+
+fix: no delete exist types if fetch new types failed

packages/dts-plugin/src/core/lib/DTSManager.spec.ts

@@ -185,20 +185,8 @@ describe('DTSManager', () => {
     });
   });
 
-  it('correct consumeTypes', async () => {
-    const distFolder = join(projectRoot, 'dist', typesFolder);
-    const zip = new AdmZip();
-    await zip.addLocalFolderPromise(distFolder, {});
-    axios.get = vi.fn().mockResolvedValueOnce({ data: zip.toBuffer() });
-
-    await dtsManager.consumeTypes();
-
-    const targetFolder = join(projectRoot, hostOptions.typesFolder);
-    expect(
-      dirTree(targetFolder, {
-        exclude: [/node_modules/, /dev-worker/, /plugins/, /server/],
-      }),
-    ).toMatchObject({
+  describe('consumeTypes', async () => {
+    const expectedStructure = {
       name: '@mf-types-dts-test-consume-types',
       children: [
         {
@@ -318,6 +306,31 @@ describe('DTSManager', () => {
           name: 'remotes',
         },
       ],
+    };
+    const targetFolder = join(projectRoot, hostOptions.typesFolder);
+    it('correct consumeTypes', async () => {
+      const distFolder = join(projectRoot, 'dist', typesFolder);
+      const zip = new AdmZip();
+      await zip.addLocalFolderPromise(distFolder, {});
+      axios.get = vi.fn().mockResolvedValueOnce({ data: zip.toBuffer() });
+
+      await dtsManager.consumeTypes();
+
+      expect(
+        dirTree(targetFolder, {
+          exclude: [/node_modules/, /dev-worker/, /plugins/, /server/],
+        }),
+      ).toMatchObject(expectedStructure);
+    });
+
+    it('no delete exist remote types if fetch new remote types failed', async () => {
+      axios.get = vi.fn().mockRejectedValue(new Error('error'));
+      await dtsManager.consumeTypes();
+      expect(
+        dirTree(targetFolder, {
+          exclude: [/node_modules/, /dev-worker/, /plugins/, /server/],
+        }),
+      ).toMatchObject(expectedStructure);
     });
   });
 

packages/dts-plugin/src/core/lib/DTSManager.ts

@@ -341,18 +341,6 @@ class DTSManager {
 
   async consumeArchiveTypes(options: HostOptions) {
     const { hostOptions, mapRemotesToDownload } = retrieveHostConfig(options);
-    if (hostOptions.deleteTypesFolder) {
-      await rm(hostOptions.typesFolder, {
-        recursive: true,
-        force: true,
-      }).catch((error) =>
-        fileLog(
-          `Unable to remove types folder, ${error}`,
-          'consumeArchiveTypes',
-          'error',
-        ),
-      );
-    }
 
     const downloadPromises = Object.entries(mapRemotesToDownload).map(
       async (item) => {

packages/dts-plugin/src/core/lib/archiveHandler.ts

@@ -1,5 +1,6 @@
 import AdmZip from 'adm-zip';
 import { resolve, join } from 'path';
+import { rm } from 'fs/promises';
 import typescript from 'typescript';
 
 import { HostOptions } from '../interfaces/HostOptions';
@@ -63,6 +64,21 @@ export const downloadTypesArchive = (hostOptions: Required<HostOptions>) => {
           responseType: 'arraybuffer',
         }).catch(downloadErrorLogger(destinationFolder, url));
 
+        try {
+          if (hostOptions.deleteTypesFolder) {
+            await rm(destinationPath, {
+              recursive: true,
+              force: true,
+            });
+          }
+        } catch (error) {
+          fileLog(
+            `Unable to remove types folder, ${error}`,
+            'downloadTypesArchive',
+            'error',
+          );
+        }
+
         const zip = new AdmZip(Buffer.from(response.data));
         zip.extractAllTo(destinationPath, true);
         return [destinationFolder, destinationPath];

packages/dts-plugin/vite.config.ts

@@ -4,7 +4,7 @@ import { defineConfig } from 'vite';
 import { nxViteTsPaths } from '@nx/vite/plugins/nx-tsconfig-paths.plugin';
 
 export default defineConfig({
-  cacheDir: '../../node_modules/.vite/native-federation-tests',
+  cacheDir: '../../node_modules/.vite/dts-plugin',
 
   plugins: [nxViteTsPaths()],