Skip to content

Commit 4fc20cc

Browse files
fix(runtime): adding reject to args in loadEsmEntry (#2067)
Co-authored-by: Zack Jackson <[email protected]>
1 parent c15c3e7 commit 4fc20cc

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

.changeset/late-wasps-watch.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@module-federation/runtime': patch
3+
---
4+
5+
adding reject to args in loadEsmEntry

packages/runtime/src/utils/load.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ export async function loadEsmEntry({
2020
if (!remoteEntryExports) {
2121
// eslint-disable-next-line no-eval
2222
new Function(
23-
'resolve',
24-
`import("${entry}").then((res)=>{resolve(res);}, (error)=> reject(error))`,
25-
)(resolve);
23+
'callbacks',
24+
`import("${entry}").then(callbacks[0]).catch(callbacks[1])`,
25+
)([resolve, reject]);
2626
} else {
2727
resolve(remoteEntryExports);
2828
}

0 commit comments

Comments
 (0)