fix(runtime): runtime should not pre-register shared while strategy is 'loaded-first' (#2056)

Author: 2heal1

.changeset/hip-cars-drop.md

@@ -0,0 +1,5 @@
+---
+'@module-federation/runtime': patch
+---
+
+fix(runtime): runtime should not pre-register shared while strategy is 'loaded-first'

packages/runtime/src/core.ts

@@ -671,7 +671,8 @@ export class FederationHost {
       );
       if (
         !activeVersion ||
-        (!activeVersion.loaded &&
+        (activeVersion.strategy !== 'loaded-first' &&
+          !activeVersion.loaded &&
           (Boolean(!eager) !== !activeVersionEager
             ? eager
             : hostName > activeVersion.from))
@@ -699,7 +700,6 @@ export class FederationHost {
         register(shareName, shared);
       }
     });
-
     if (strategy === 'version-first') {
       this.options.remotes.forEach((remote) => {
         if (remote.shareScope === shareScopeName) {

packages/runtime/src/module/index.ts

@@ -91,7 +91,7 @@ class Module {
           origin: this.host,
         });
 
-      remoteEntryExports.init(
+      await remoteEntryExports.init(
         initContainerOptions.shareScope,
         initContainerOptions.initScope,
         initContainerOptions.remoteEntryInitOptions,

packages/runtime/src/type/config.ts

@@ -130,5 +130,5 @@ export type RemoteEntryExports = {
     shareScope: ShareScopeMap[string],
     initScope?: InitScope,
     remoteEntryInitOPtions?: RemoteEntryInitOptions,
-  ) => void;
+  ) => void | Promise<void>;
 };