fix(runtime): preserve generic in loadRemote/loadShare/loadShareSync (#2325) (#2345)

Co-authored-by: Zack Jackson <[email protected]>

Author: crutch12

.changeset/tasty-parents-guess.md

@@ -0,0 +1,5 @@
+---
+'@module-federation/runtime': patch
+---
+
+fix: preserve generic in loadRemote/loadShare/loadShareSync

packages/runtime/__tests__/global.spec.ts

@@ -1,5 +1,5 @@
-import { assert, describe, test, it, vi } from 'vitest';
-import { init } from '../src/index';
+import { assert, describe, test, it, vi, expectTypeOf } from 'vitest';
+import { init, loadRemote, loadShare, loadShareSync } from '../src/index';
 import { getInfoWithoutType } from '../src/global';
 
 describe('global', () => {
@@ -44,4 +44,32 @@ describe('global', () => {
       value: 4,
     });
   });
+
+  describe('global types (generic)', () => {
+    it('loadRemote', async () => {
+      const typedLoadRemote: typeof loadRemote<string> = loadRemote;
+      expectTypeOf(typedLoadRemote).returns.toMatchTypeOf<
+        Promise<string | null>
+      >();
+      expectTypeOf(typedLoadRemote).returns.not.toMatchTypeOf<Promise<null>>();
+    });
+
+    it('loadShare', async () => {
+      const typedLoadShare: typeof loadShare<string> = loadShare;
+      expectTypeOf(typedLoadShare).returns.toMatchTypeOf<
+        Promise<false | (() => string | undefined)>
+      >();
+      expectTypeOf(typedLoadShare).returns.not.toMatchTypeOf<
+        Promise<false | (() => undefined)>
+      >();
+    });
+
+    it('loadShareSync', async () => {
+      const typedLoadShareSync: typeof loadShareSync<string> = loadShareSync;
+      expectTypeOf(typedLoadShareSync).returns.toMatchTypeOf<
+        () => string | never
+      >();
+      expectTypeOf(typedLoadShareSync).returns.not.toMatchTypeOf<() => never>();
+    });
+  });
 });

packages/runtime/src/index.ts

@@ -37,28 +37,34 @@ export function init(options: UserOptions): FederationHost {
   }
 }
 
-export function loadRemote(
+export function loadRemote<T>(
   ...args: Parameters<FederationHost['loadRemote']>
-): ReturnType<FederationHost['loadRemote']> {
+): Promise<T | null> {
   assert(FederationInstance, 'Please call init first');
+  const loadRemote: typeof FederationInstance.loadRemote<T> =
+    FederationInstance.loadRemote;
   // eslint-disable-next-line prefer-spread
-  return FederationInstance.loadRemote.apply(FederationInstance, args);
+  return loadRemote.apply(FederationInstance, args);
 }
 
-export function loadShare(
+export function loadShare<T>(
   ...args: Parameters<FederationHost['loadShare']>
-): ReturnType<FederationHost['loadShare']> {
+): Promise<false | (() => T | undefined)> {
   assert(FederationInstance, 'Please call init first');
   // eslint-disable-next-line prefer-spread
-  return FederationInstance.loadShare.apply(FederationInstance, args);
+  const loadShare: typeof FederationInstance.loadShare<T> =
+    FederationInstance.loadShare;
+  return loadShare.apply(FederationInstance, args);
 }
 
-export function loadShareSync(
+export function loadShareSync<T>(
   ...args: Parameters<FederationHost['loadShareSync']>
-): ReturnType<FederationHost['loadShareSync']> {
+): () => T | never {
   assert(FederationInstance, 'Please call init first');
+  const loadShareSync: typeof FederationInstance.loadShareSync<T> =
+    FederationInstance.loadShareSync;
   // eslint-disable-next-line prefer-spread
-  return FederationInstance.loadShareSync.apply(FederationInstance, args);
+  return loadShareSync.apply(FederationInstance, args);
 }
 
 export function preloadRemote(