Skip to content

Commit 64840dd

Browse files
authored
feat(storybook)!: only ship ESM outputs, align with Storybook 10. (#4223)
1 parent 35c3695 commit 64840dd

File tree

9 files changed

+15
-10
lines changed

9 files changed

+15
-10
lines changed

.changeset/real-squids-retire.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@module-federation/storybook-addon': major
3+
---
4+
5+
only ship ESM outputs, align with Storybook 10.

packages/storybook-addon/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "@module-federation/storybook-addon",
33
"version": "4.0.36",
44
"description": "Storybook addon to consume remote module federated apps/components",
5-
"type": "commonjs",
5+
"type": "module",
66
"license": "MIT",
77
"repository": {
88
"type": "git",

packages/storybook-addon/preset.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { withModuleFederation } from './src/utils/with-module-federation-enhanced-rsbuild';
1+
import { withModuleFederation } from './src/utils/with-module-federation-enhanced-rsbuild.js';
22

33
import type { RsbuildConfig } from '@rsbuild/core';
44
import type { moduleFederationPlugin } from '@module-federation/sdk';
@@ -18,4 +18,4 @@ export default {
1818
});
1919
},
2020
};
21-
export { PLUGIN_NAME } from './src/utils/with-module-federation-enhanced-rsbuild';
21+
export { PLUGIN_NAME } from './src/utils/with-module-federation-enhanced-rsbuild.js';
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export * from './lib/storybook-addon';
1+
export * from './lib/storybook-addon.js';

packages/storybook-addon/src/lib/storybook-addon.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Preset, webpack } from './storybook-addon';
1+
import { Preset, webpack } from './storybook-addon.js';
22
import { Configuration, container } from 'webpack';
33
import VirtualModulesPlugin from 'webpack-virtual-modules';
44

packages/storybook-addon/src/lib/storybook-addon.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ import {
99
} from 'webpack';
1010
import { logger } from '@storybook/node-logger';
1111
import { normalizeStories } from '@storybook/core/common';
12-
import withModuleFederation from '../utils/with-module-federation';
13-
import { correctImportPath } from '../utils/correctImportPath';
12+
import withModuleFederation from '../utils/with-module-federation.js';
13+
import { correctImportPath } from '../utils/correctImportPath.js';
1414

1515
import type { moduleFederationPlugin } from '@module-federation/sdk';
1616
import type { ModuleFederationConfig } from '@nx/webpack';

packages/storybook-addon/src/utils/correctImportPath.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { correctImportPath } from './correctImportPath';
1+
import { correctImportPath } from './correctImportPath.js';
22

33
describe(`${correctImportPath.name}()`, () => {
44
afterEach(() => {

packages/storybook-addon/src/utils/with-module-federation-enhanced-rsbuild.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import path from 'node:path';
33
import { ModuleFederationPlugin } from '@module-federation/enhanced/rspack';
44
import { TEMP_DIR } from '@module-federation/sdk';
55

6-
import { correctImportPath } from './correctImportPath';
6+
import { correctImportPath } from './correctImportPath.js';
77

88
import type { RsbuildConfig, RsbuildPlugin } from '@rsbuild/core';
99
import type { moduleFederationPlugin } from '@module-federation/sdk';

packages/storybook-addon/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"extends": "../../tsconfig.base.json",
33
"compilerOptions": {
4-
"module": "commonjs",
4+
"module": "esnext",
55
"forceConsistentCasingInFileNames": true,
66
"strict": true,
77
"noImplicitOverride": true,

0 commit comments

Comments
 (0)