chore: fix type issues in other plugins (#2901)

Co-authored-by: ScriptedAlchemy <[email protected]>

Author: ScriptedAlchemy

.github/workflows/e2e-next.yml

@@ -46,11 +46,11 @@ jobs:
         run: |
           pnpm run --filter @module-federation/3002-checkout --filter @module-federation/3000-home --filter @module-federation/3001-shop build &&
           pnpm run app:next:prod &
-          sleep 2 &&
+          sleep 4 &&
           npx wait-on tcp:3001 &&
           npx wait-on tcp:3002 &&
           npx wait-on tcp:3000 &&
-          npx nx run-many --target=test:e2e --projects=3000-home,3001-shop,3002-checkout --parallel=3 &&
+          npx nx run-many --target=test:e2e --projects=3000-home,3001-shop,3002-checkout --parallel=1 &&
           lsof -ti tcp:3000,3001,3002 | xargs kill
 
       - name: E2E Test for Next.js Dev

packages/enhanced/src/declarations/plugins/container/WebpackError.d.ts

@@ -1,3 +1,5 @@
+import type { Module } from 'webpack';
+
 declare class WebpackError extends Error {
   /**
    * Creates an instance of WebpackError.
@@ -17,7 +19,6 @@ declare class WebpackError extends Error {
    */
   static captureStackTrace(
     targetObject: object,
-    // eslint-disable-next-line @typescript-eslint/ban-types
     constructorOpt?: Function,
   ): void;
 

packages/enhanced/src/lib/container/ContainerPlugin.ts

@@ -43,6 +43,7 @@ const PLUGIN_NAME = 'ContainerPlugin';
 class ContainerPlugin {
   _options: containerPlugin.ContainerPluginOptions;
   name: string;
+
   /**
    * @param {containerPlugin.ContainerPluginOptions} options options
    */

packages/enhanced/src/lib/container/RemoteRuntimeModule.ts

@@ -3,7 +3,7 @@
 	Author Tobias Koppers @sokra, Zackary Jackson @ScriptedAlchemy
 */
 import { normalizeWebpackPath } from '@module-federation/sdk/normalize-webpack-path';
-import type { Compilation } from 'webpack';
+import type { Compilation, Chunk } from 'webpack';
 import RemoteModule from './RemoteModule';
 import { getFederationGlobalScope } from './runtime/utils';
 import type ExternalModule from 'webpack/lib/ExternalModule';

packages/enhanced/src/lib/sharing/ConsumeSharedPlugin.ts

@@ -8,7 +8,7 @@ import {
   getWebpackPath,
   normalizeWebpackPath,
 } from '@module-federation/sdk/normalize-webpack-path';
-import type { Compiler } from 'webpack';
+import type { Compiler, Compilation } from 'webpack';
 import { parseOptions } from '../container/options';
 import { ConsumeOptions } from './ConsumeSharedModule';
 import { ConsumeSharedPluginOptions } from '../../declarations/plugins/sharing/ConsumeSharedPlugin';
@@ -18,7 +18,10 @@ import {
   getDescriptionFile,
   getRequiredVersionFromDescriptionFile,
 } from './utils';
-import type { ResolveOptionsWithDependencyType } from 'webpack/lib/ResolverFactory';
+import type {
+  ResolveOptionsWithDependencyType,
+  ResolverWithOptions,
+} from 'webpack/lib/ResolverFactory';
 import ConsumeSharedFallbackDependency from './ConsumeSharedFallbackDependency';
 import ConsumeSharedModule from './ConsumeSharedModule';
 import ConsumeSharedRuntimeModule from './ConsumeSharedRuntimeModule';
@@ -136,7 +139,7 @@ class ConsumeSharedPlugin {
 
     compiler.hooks.thisCompilation.tap(
       PLUGIN_NAME,
-      (compilation, { normalModuleFactory }) => {
+      (compilation: Compilation, { normalModuleFactory }) => {
         compilation.dependencyFactories.set(
           ConsumeSharedFallbackDependency,
           normalModuleFactory,
@@ -152,11 +155,9 @@ class ConsumeSharedPlugin {
             prefixedConsumes = prefixed;
           },
         );
-
-        const resolver = compilation.resolverFactory.get(
+        const resolver: ResolverWithOptions = compilation.resolverFactory.get(
           'normal',
-          //@ts-ignore
-          RESOLVE_OPTIONS,
+          RESOLVE_OPTIONS as ResolveOptionsWithDependencyType,
         );
 
         const createConsumeSharedModule = (

packages/enhanced/src/lib/sharing/ProvideSharedDependency.ts

@@ -12,10 +12,10 @@ const { Dependency } = require(
   normalizeWebpackPath('webpack'),
 ) as typeof import('webpack');
 
-import {
+import type {
   ObjectDeserializerContext,
   ObjectSerializerContext,
-} from '../../declarations/plugins/container/Dependency';
+} from 'webpack/lib/Dependency';
 
 class ProvideSharedDependency extends Dependency {
   shareScope: string;

packages/enhanced/src/lib/sharing/ProvideSharedPlugin.ts

@@ -8,7 +8,11 @@ import {
   getWebpackPath,
   normalizeWebpackPath,
 } from '@module-federation/sdk/normalize-webpack-path';
-import type { Compiler, Compilation } from 'webpack';
+import type {
+  Compiler,
+  Compilation,
+  WebpackError as WebpackErrorType,
+} from 'webpack';
 import { parseOptions } from '../container/options';
 import ProvideForSharedDependency from './ProvideForSharedDependency';
 import ProvideSharedDependency from './ProvideSharedDependency';
@@ -243,7 +247,7 @@ class ProvideSharedPlugin {
                   {
                     name: undefined,
                   },
-                  (err: WebpackError | null | undefined) => {
+                  (err?: WebpackErrorType | null | undefined) => {
                     if (err) return reject(err);
                     resolve();
                   },
@@ -263,7 +267,6 @@ class ProvideSharedPlugin {
         );
 
         compilation.dependencyFactories.set(
-          //@ts-ignore
           ProvideSharedDependency,
           // @ts-ignore
           new ProvideSharedModuleFactory(),

packages/manifest/src/StatsManager.ts

@@ -13,7 +13,13 @@ import {
   moduleFederationPlugin,
   RemoteEntryType,
 } from '@module-federation/sdk';
-import { Compilation, Compiler, StatsCompilation, StatsModule } from 'webpack';
+import {
+  Compilation,
+  Compiler,
+  StatsCompilation,
+  StatsModule,
+  Chunk,
+} from 'webpack';
 import {
   isDev,
   getAssetsByChunk,
@@ -86,8 +92,10 @@ class StatsManager {
       const remoteEntryNameChunk = compilation.namedChunks.get(name);
 
       assert(remoteEntryNameChunk, 'Can not get remoteEntry chunk!');
-      const files = Array.from(remoteEntryNameChunk.files).filter(
-        (f) => !f.includes(HOT_UPDATE_SUFFIX) && !f.endsWith('.css'),
+      const files = Array.from(
+        remoteEntryNameChunk.files as Iterable<string>,
+      ).filter(
+        (f: string) => !f.includes(HOT_UPDATE_SUFFIX) && !f.endsWith('.css'),
       );
       assert(files.length > 0, 'no files found for remoteEntry chunk');
       assert(
@@ -209,25 +217,31 @@ class StatsManager {
       const [sharedModuleName, sharedModule] = item;
       if (!manifestOverrideChunkIDMap[sharedModuleName]) {
         manifestOverrideChunkIDMap[sharedModuleName] = {
-          async: new Set(),
-          sync: new Set(),
+          async: new Set<string | number>(),
+          sync: new Set<string | number>(),
         };
       }
-      sharedModule.chunks!.forEach((chunkID) => {
+      sharedModule.chunks!.forEach((chunkID: string | number) => {
         const chunk = findChunk(chunkID, compilation.chunks);
 
         manifestOverrideChunkIDMap[sharedModuleName].sync.add(chunkID);
-        Array.from(chunk!.getAllInitialChunks()).forEach((syncChunk) => {
-          syncChunk.id &&
-            manifestOverrideChunkIDMap[sharedModuleName].sync.add(syncChunk.id);
-        });
+        Array.from(chunk!.getAllInitialChunks() as Iterable<Chunk>).forEach(
+          (syncChunk: Chunk) => {
+            syncChunk.id &&
+              manifestOverrideChunkIDMap[sharedModuleName].sync.add(
+                syncChunk.id,
+              );
+          },
+        );
 
-        Array.from(chunk!.getAllAsyncChunks()).forEach((asyncChunk) => {
-          asyncChunk.id &&
-            manifestOverrideChunkIDMap[sharedModuleName].async.add(
-              asyncChunk.id,
-            );
-        });
+        Array.from(chunk!.getAllAsyncChunks() as Iterable<Chunk>).forEach(
+          (asyncChunk: Chunk) => {
+            asyncChunk.id &&
+              manifestOverrideChunkIDMap[sharedModuleName].async.add(
+                asyncChunk.id,
+              );
+          },
+        );
       });
     });
 

packages/manifest/src/utils.ts

@@ -49,7 +49,7 @@ export function getAssetsByChunkIDs(
   compilation: Compilation,
   chunkIDMap: Record<string, Set<string | number>>,
 ): Record<string, { js: string[]; css: string[] }> {
-  const arrayChunks = Array.from(compilation.chunks);
+  const arrayChunks = Array.from(compilation.chunks) as Chunk[];
   const assetMap: Record<string, { css: Set<string>; js: Set<string> }> = {};
 
   Object.keys(chunkIDMap).forEach((key) => {

packages/typescript/src/plugins/FederatedTypesPlugin.ts

@@ -64,15 +64,15 @@ export class FederatedTypesPlugin {
       this.normalizeOptions.ignoredWatchOptions;
 
     if (!disableTypeCompilation) {
-      compiler.hooks.beforeCompile.tap(PLUGIN_NAME, (_) => {
+      compiler.hooks.beforeCompile.tap(PLUGIN_NAME, (_: unknown) => {
         this.generateTypes({ outputPath: compiler.outputPath });
       });
 
       this.handleTypeServing(compiler, this.normalizeOptions.typeServeOptions);
 
       // TODO - this is not ideal, but it will repopulate types if clean is enabled
       if (compiler.options.output.clean) {
-        compiler.hooks.afterEmit.tap(PLUGIN_NAME, (_) => {
+        compiler.hooks.afterEmit.tap(PLUGIN_NAME, () => {
           this.generateTypes({ outputPath: compiler.outputPath });
         });
       }
@@ -81,7 +81,7 @@ export class FederatedTypesPlugin {
     if (!disableDownloadingRemoteTypes) {
       compiler.hooks.beforeCompile.tapAsync(
         PLUGIN_NAME,
-        async (_, callback) => {
+        async (params: unknown, callback: InnerCallback<Error, void>) => {
           if (typeDownloadCompleted) {
             callback();
             return;
@@ -112,7 +112,7 @@ export class FederatedTypesPlugin {
 
       compiler.hooks.beforeCompile.tapAsync(
         PLUGIN_NAME,
-        async (_, callback) => {
+        async (params: unknown, callback: InnerCallback<Error, void>) => {
           this.logger.log('Preparing to serve types');
 
           try {