File tree Expand file tree Collapse file tree 7 files changed +35
-6
lines changed
consume-multiple-versions-ignore-warnings
consume-multiple-versions Expand file tree Collapse file tree 7 files changed +35
-6
lines changed Original file line number Diff line number Diff line change @@ -608,7 +608,7 @@ class ConsumeSharedPlugin {
608
608
import : options . import
609
609
? options . import + remainder
610
610
: undefined ,
611
- shareKey : options . shareKey ,
611
+ shareKey : options . shareKey + remainder ,
612
612
layer : options . layer ,
613
613
} ,
614
614
) ;
@@ -656,7 +656,7 @@ class ConsumeSharedPlugin {
656
656
import : options . import
657
657
? options . import + remainder
658
658
: undefined ,
659
- shareKey : options . shareKey ,
659
+ shareKey : options . shareKey + remainder ,
660
660
layer : options . layer ,
661
661
} ,
662
662
) ;
Original file line number Diff line number Diff line change @@ -264,7 +264,7 @@ class ProvideSharedPlugin {
264
264
}
265
265
266
266
const finalShareKey = originalPrefixConfig . shareKey
267
- ? originalPrefixConfig . shareKey
267
+ ? originalPrefixConfig . shareKey + remainder
268
268
: configuredPrefix + remainder ;
269
269
270
270
// Validate singleton usage when using include.request
@@ -400,7 +400,7 @@ class ProvideSharedPlugin {
400
400
}
401
401
402
402
const finalShareKey = originalPrefixConfig . shareKey
403
- ? originalPrefixConfig . shareKey
403
+ ? originalPrefixConfig . shareKey + remainder
404
404
: configuredPrefix + remainder ;
405
405
406
406
// Validate singleton usage when using include.request
Original file line number Diff line number Diff line change @@ -12,9 +12,11 @@ module.exports = {
12
12
shared : {
13
13
import : false ,
14
14
strictVersion : true ,
15
+ eager : true ,
15
16
} ,
16
17
shared2 : {
17
18
import : false ,
19
+ eager : true ,
18
20
} ,
19
21
} ,
20
22
} ) ,
Original file line number Diff line number Diff line change @@ -9,85 +9,109 @@ module.exports = {
9
9
shared : {
10
10
import : false ,
11
11
strictVersion : true ,
12
+ eager : true ,
12
13
} ,
13
14
shared2 : {
14
15
import : false ,
16
+ eager : true ,
15
17
} ,
16
18
shared3 : {
17
19
import : false ,
18
20
strictVersion : true ,
21
+ eager : true ,
19
22
} ,
20
23
shared4 : {
21
24
import : false ,
25
+ eager : true ,
22
26
} ,
23
27
shared5 : {
24
28
import : false ,
25
29
strictVersion : true ,
30
+ eager : true ,
26
31
} ,
27
32
shared6 : {
28
33
import : false ,
29
34
strictVersion : true ,
35
+ eager : true ,
30
36
} ,
31
37
shared7 : {
32
38
import : false ,
33
39
strictVersion : true ,
40
+ eager : true ,
34
41
} ,
35
42
shared8 : {
36
43
import : false ,
37
44
strictVersion : true ,
45
+ eager : true ,
38
46
} ,
39
47
shared9 : {
40
48
import : false ,
41
49
strictVersion : true ,
50
+ eager : true ,
42
51
} ,
43
52
shared10 : {
44
53
import : false ,
45
54
strictVersion : true ,
55
+ eager : true ,
46
56
} ,
47
57
shared11 : {
48
58
import : false ,
49
59
strictVersion : true ,
60
+ eager : true ,
50
61
} ,
51
62
shared12 : {
52
63
import : false ,
64
+ eager : true ,
53
65
} ,
54
66
shared13 : {
55
67
import : false ,
68
+ eager : true ,
56
69
} ,
57
70
shared14 : {
58
71
import : false ,
72
+ eager : true ,
59
73
} ,
60
74
shared15 : {
61
75
import : false ,
62
76
strictVersion : true ,
77
+ eager : true ,
63
78
} ,
64
79
shared16 : {
65
80
import : false ,
81
+ eager : true ,
66
82
} ,
67
83
shared17 : {
68
84
import : false ,
69
85
strictVersion : true ,
86
+ eager : true ,
70
87
} ,
71
88
shared18 : {
72
89
import : false ,
90
+ eager : true ,
73
91
} ,
74
92
shared19 : {
75
93
import : false ,
94
+ eager : true ,
76
95
} ,
77
96
shared20 : {
78
97
import : false ,
98
+ eager : true ,
79
99
} ,
80
100
shared21 : {
81
101
import : false ,
102
+ eager : true ,
82
103
} ,
83
104
shared22 : {
84
105
import : false ,
106
+ eager : true ,
85
107
} ,
86
108
shared23 : {
87
109
import : false ,
110
+ eager : true ,
88
111
} ,
89
112
shared24 : {
90
113
import : false ,
114
+ eager : true ,
91
115
} ,
92
116
} ,
93
117
} ) ,
Original file line number Diff line number Diff line change @@ -49,7 +49,7 @@ module.exports = {
49
49
shareKey : 'request-prefix' ,
50
50
version : '1.0.0' ,
51
51
include : {
52
- request : / c o m p o n e n t s / ,
52
+ request : / . * / ,
53
53
} ,
54
54
} ,
55
55
} ,
Original file line number Diff line number Diff line change
1
+ if ( Math . random ( ) < 0 ) {
2
+ require ( 'shared/directory/thing' ) ;
3
+ }
4
+
1
5
it ( 'should share a deep module path' , async ( ) => {
2
6
await __webpack_init_sharing__ ( 'default' ) ;
3
7
// Share scopes are available but we don't need to log them
Original file line number Diff line number Diff line change @@ -5,7 +5,6 @@ module.exports = {
5
5
devtool : false ,
6
6
plugins : [
7
7
new SharePlugin ( {
8
- name : 'shared-strategy' ,
9
8
shared : {
10
9
react : {
11
10
requiredVersion : false ,
You can’t perform that action at this time.
0 commit comments