fix: buildVersion now correctly reads from project's package.json (#3928)

Co-authored-by: Claude <[email protected]>

Author: ScriptedAlchemy

.changeset/fix-build-version-package-json.md

@@ -0,0 +1,12 @@
+---
+"@module-federation/manifest": patch
+"@module-federation/managers": patch
+"@module-federation/enhanced": patch
+---
+
+fix: BuildVersion now correctly reads from project's package.json
+
+- Fixed getBuildVersion() to accept optional root parameter for correct directory resolution
+- Updated StatsManager to use compiler.context when determining build version
+- Ensures buildVersion in mf-manifest.json matches the project's package.json version
+- Resolves issue #3835 where buildVersion was reading from wrong package.json location

packages/enhanced/test/configCases/build-version/package-json-version/index.js

@@ -0,0 +1,14 @@
+it('should read buildVersion from package.json', () => {
+  const fs = require('fs');
+  const path = require('path');
+
+  // Read the generated mf-manifest.json file (Module Federation manifest)
+  const manifestPath = path.join(__dirname, 'mf-manifest.json');
+  expect(fs.existsSync(manifestPath)).toBe(true);
+
+  const manifest = JSON.parse(fs.readFileSync(manifestPath, 'utf8'));
+
+  // Check that buildVersion matches package.json version
+  expect(manifest.metaData.buildInfo).toBeDefined();
+  expect(manifest.metaData.buildInfo.buildVersion).toBe('1.2.3');
+});

packages/enhanced/test/configCases/build-version/package-json-version/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "test-build-version",
+  "version": "1.2.3",
+  "description": "Test case for BuildVersion reading from package.json"
+}

packages/enhanced/test/configCases/build-version/package-json-version/test.js

@@ -0,0 +1 @@
+export default 'test module';

packages/enhanced/test/configCases/build-version/package-json-version/webpack.config.js

@@ -0,0 +1,26 @@
+const ModuleFederationPlugin =
+  require('../../../../dist/src/lib/container/ModuleFederationPlugin').default;
+
+module.exports = {
+  mode: 'development',
+  entry: './index.js',
+  devtool: false,
+  output: {
+    publicPath: 'http://localhost:3000/',
+  },
+  optimization: {
+    minimize: false,
+  },
+  stats: 'none',
+  plugins: [
+    new ModuleFederationPlugin({
+      name: 'build_version_test',
+      library: { type: 'commonjs-module' },
+      filename: 'remoteEntry.js',
+      exposes: {
+        './test': './test.js',
+      },
+      manifest: true,
+    }),
+  ],
+};

packages/managers/src/utils.ts

@@ -62,11 +62,11 @@ export function parseOptions<T, R>(
   return items;
 }
 
-export function getBuildVersion(): string {
+export function getBuildVersion(root?: string): string {
   if (process.env['MF_BUILD_VERSION']) {
     return process.env['MF_BUILD_VERSION'];
   }
-  const pkg = new PKGJsonManager().readPKGJson();
+  const pkg = new PKGJsonManager().readPKGJson(root);
   if (pkg?.['version'] && typeof pkg['version'] === 'string') {
     return pkg['version'];
   }

packages/manifest/src/StatsManager.ts

@@ -50,11 +50,12 @@ class StatsManager {
   private _sharedManager: SharedManager = new SharedManager();
   private _pkgJsonManager: PKGJsonManager = new PKGJsonManager();
 
-  get buildInfo(): StatsBuildInfo {
-    const pkg = this._pkgJsonManager.readPKGJson(process.cwd());
+  private getBuildInfo(context?: string): StatsBuildInfo {
+    const rootPath = context || process.cwd();
+    const pkg = this._pkgJsonManager.readPKGJson(rootPath);
 
     return {
-      buildVersion: utils.getBuildVersion(),
+      buildVersion: utils.getBuildVersion(rootPath),
       buildName: utils.getBuildName() || pkg['name'],
     };
   }
@@ -70,8 +71,8 @@ class StatsManager {
     const { context } = compiler.options;
     const {
       _options: { name },
-      buildInfo,
     } = this;
+    const buildInfo = this.getBuildInfo(context);
     const type = this._pkgJsonManager.getExposeGarfishModuleType(
       context || process.cwd(),
     );