fix(runtime): remove function duplication (#2895)

Co-authored-by: ScriptedAlchemy <[email protected]>

Author: ScriptedAlchemy

.changeset/yellow-bugs-poke.md

@@ -0,0 +1,6 @@
+---
+'@module-federation/runtime': patch
+'@module-federation/sdk': patch
+---
+
+Remove duplicated util functions and referecne central ones

packages/runtime/src/core.ts

@@ -1,4 +1,5 @@
 import type { CreateScriptHookReturn } from '@module-federation/sdk';
+import { isBrowserEnv } from '@module-federation/sdk';
 import {
   Options,
   PreloadRemoteArgs,
@@ -25,7 +26,6 @@ import {
 } from './utils/hooks';
 import { generatePreloadAssetsPlugin } from './plugins/generate-preload-assets';
 import { snapshotPlugin } from './plugins/snapshot';
-import { isBrowserEnv } from './utils/env';
 import { getRemoteInfo } from './utils/load';
 import { DEFAULT_SCOPE } from './constant';
 import { SnapshotHandler } from './plugins/snapshot/SnapshotHandler';

packages/runtime/src/global.ts

@@ -6,8 +6,12 @@ import {
   Optional,
 } from './type';
 import { getFMId } from './utils/tool';
-import { GlobalModuleInfo, ModuleInfo } from '@module-federation/sdk';
-import { getBuilderId, isDebugMode } from './utils/env';
+import {
+  GlobalModuleInfo,
+  ModuleInfo,
+  isDebugMode,
+} from '@module-federation/sdk';
+import { getBuilderId } from './utils/env';
 import { warn } from './utils/logger';
 import { FederationRuntimePlugin } from './type/plugin';
 

packages/runtime/src/module/index.ts

@@ -1,4 +1,5 @@
-import { getFMId, safeToString, assert } from '../utils';
+import { getFMId, assert } from '../utils';
+import { safeToString } from '@module-federation/sdk';
 import { getRemoteEntry } from '../utils/load';
 import { FederationHost } from '../core';
 import { RemoteEntryExports, RemoteInfo, InitScope } from '../type';

packages/runtime/src/plugins/snapshot/SnapshotHandler.ts

@@ -4,13 +4,13 @@ import {
   ModuleInfo,
   generateSnapshotFromManifest,
   isManifestProvider,
+  isBrowserEnv,
 } from '@module-federation/sdk';
 import { Optional, Options, Remote } from '../../type';
 import {
   isRemoteInfoWithEntry,
   error,
   getRemoteEntryInfoFromSnapshot,
-  isBrowserEnv,
 } from '../../utils';
 import {
   getGlobalSnapshot,

packages/runtime/src/plugins/snapshot/index.ts

@@ -1,7 +1,10 @@
-import { ModuleInfo, getResourceUrl } from '@module-federation/sdk';
-import { FederationRuntimePlugin } from '../../type/plugin';
 import {
+  ModuleInfo,
+  getResourceUrl,
   isBrowserEnv,
+} from '@module-federation/sdk';
+import { FederationRuntimePlugin } from '../../type/plugin';
+import {
   error,
   isPureRemoteEntry,
   isRemoteInfoWithEntry,

packages/runtime/src/remote/index.ts

@@ -2,9 +2,10 @@ import {
   isBrowserEnv,
   warn,
   composeKeyWithSeparator,
+  ModuleInfo,
+  GlobalModuleInfo,
 } from '@module-federation/sdk';
 import { Global, getInfoWithoutType, globalLoading } from '../global';
-import type { ModuleInfo, GlobalModuleInfo } from '@module-federation/sdk';
 import {
   Options,
   UserOptions,
@@ -561,6 +562,7 @@ export class RemoteHandler {
           if (remoteKey) {
             delete hostGlobalSnapshot.remotesInfo[remoteKey];
             if (
+              //eslint-disable-next-line no-extra-boolean-cast
               Boolean(Global.__FEDERATION__.__MANIFEST_LOADING__[remoteKey])
             ) {
               delete Global.__FEDERATION__.__MANIFEST_LOADING__[remoteKey];

packages/runtime/src/utils/env.ts

@@ -9,11 +9,3 @@ export function getBuilderId(): string {
       FEDERATION_BUILD_IDENTIFIER
     : '';
 }
-
-export function isDebugMode(): boolean {
-  return typeof FEDERATION_DEBUG !== 'undefined' && Boolean(FEDERATION_DEBUG);
-}
-
-export function isBrowserEnv(): boolean {
-  return typeof window !== 'undefined';
-}

packages/runtime/src/utils/preload.ts

@@ -1,4 +1,4 @@
-import { createLink, createScript } from '@module-federation/sdk';
+import { createLink, createScript, safeToString } from '@module-federation/sdk';
 import {
   PreloadAssets,
   PreloadConfig,
@@ -10,7 +10,6 @@ import {
 } from '../type';
 import { matchRemote } from './manifest';
 import { assert } from './logger';
-import { safeToString } from './tool';
 import { FederationHost } from '../core';
 import { getRemoteEntry } from './load';
 

packages/runtime/src/utils/tool.ts

@@ -1,11 +1,11 @@
-import type {
+import {
   RemoteWithEntry,
   ModuleInfo,
   RemoteEntryType,
+  isBrowserEnv,
 } from '@module-federation/sdk';
-import { Remote, RemoteInfoOptionalVersion, UserOptions } from '../type';
+import { Remote, RemoteInfoOptionalVersion } from '../type';
 import { warn } from './logger';
-import { isBrowserEnv } from './env';
 
 export function addUniqueItem(arr: Array<string>, item: string): Array<string> {
   if (arr.findIndex((name) => name === item) === -1) {
@@ -50,15 +50,6 @@ export async function safeWrapper<T extends (...args: Array<any>) => any>(
   }
 }
 
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
-export function safeToString(info: any): string {
-  try {
-    return JSON.stringify(info, null, 2);
-  } catch (e) {
-    return '';
-  }
-}
-
 export function isObject(val: any): boolean {
   return val && typeof val === 'object';
 }