Skip to content

Commit 85e7482

Browse files
minhhieu76qngminhhieu76qng
authored
fix(bridge-react): change all logs from info to debug in all bridge packages (#3360)
1 parent 0166862 commit 85e7482

File tree

10 files changed

+43
-31
lines changed

10 files changed

+43
-31
lines changed

‎.changeset/brave-boxes-remain.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@module-federation/bridge-react': patch
3+
'@module-federation/bridge-vue3': patch
4+
---
5+
6+
fix(bridge-react): change all logs from info to debug in all bridge packages

‎packages/bridge/bridge-react/src/create.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ function createLazyRemoteComponent<T, E extends keyof T>(
3030
) {
3131
const exportName = info?.export || 'default';
3232
return React.lazy(async () => {
33-
LoggerInstance.log(`createRemoteComponent LazyComponent create >>>`, {
33+
LoggerInstance.debug(`createRemoteComponent LazyComponent create >>>`, {
3434
lazyComponent: info.loader,
3535
exportName,
3636
});
@@ -39,7 +39,7 @@ function createLazyRemoteComponent<T, E extends keyof T>(
3939
const m = (await info.loader()) as RemoteModule;
4040
// @ts-ignore
4141
const moduleName = m && m[Symbol.for('mf_module_id')];
42-
LoggerInstance.log(
42+
LoggerInstance.debug(
4343
`createRemoteComponent LazyComponent loadRemote info >>>`,
4444
{ name: moduleName, module: m, exportName },
4545
);
@@ -71,7 +71,7 @@ function createLazyRemoteComponent<T, E extends keyof T>(
7171
default: RemoteAppComponent,
7272
};
7373
} else {
74-
LoggerInstance.log(
74+
LoggerInstance.debug(
7575
`createRemoteComponent LazyComponent module not found >>>`,
7676
{ name: moduleName, module: m, exportName },
7777
);

‎packages/bridge/bridge-react/src/provider.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export function createBridgeComponent<T>(bridgeInfo: ProviderFnParams<T>) {
3232
return () => {
3333
const rootMap = new Map<any, RootType>();
3434
const instance = federationRuntime.instance;
35-
LoggerInstance.log(
35+
LoggerInstance.debug(
3636
`createBridgeComponent instance from props >>>`,
3737
instance,
3838
);
@@ -53,7 +53,7 @@ export function createBridgeComponent<T>(bridgeInfo: ProviderFnParams<T>) {
5353

5454
return {
5555
async render(info: RenderParams) {
56-
LoggerInstance.log(`createBridgeComponent render Info`, info);
56+
LoggerInstance.debug(`createBridgeComponent render Info`, info);
5757
const {
5858
moduleName,
5959
dom,
@@ -102,7 +102,7 @@ export function createBridgeComponent<T>(bridgeInfo: ProviderFnParams<T>) {
102102
},
103103

104104
async destroy(info: DestroyParams) {
105-
LoggerInstance.log(`createBridgeComponent destroy Info`, {
105+
LoggerInstance.debug(`createBridgeComponent destroy Info`, {
106106
dom: info.dom,
107107
});
108108
instance?.bridgeHook?.lifecycle?.beforeBridgeDestroy?.emit(info);

‎packages/bridge/bridge-react/src/remote/index.tsx‎

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ const RemoteAppWrapper = forwardRef(function (
4141
ref,
4242
) {
4343
const RemoteApp = () => {
44-
LoggerInstance.log(`RemoteAppWrapper RemoteApp props >>>`, { props });
44+
LoggerInstance.debug(`RemoteAppWrapper RemoteApp props >>>`, { props });
4545
const {
4646
moduleName,
4747
memoryRoute,
@@ -62,7 +62,7 @@ const RemoteAppWrapper = forwardRef(function (
6262
const renderDom: React.MutableRefObject<HTMLElement | null> = useRef(null);
6363
const providerInfoRef = useRef<any>(null);
6464

65-
LoggerInstance.log(`RemoteAppWrapper instance from props >>>`, instance);
65+
LoggerInstance.debug(`RemoteAppWrapper instance from props >>>`, instance);
6666

6767
useEffect(() => {
6868
const renderTimeout = setTimeout(() => {
@@ -78,12 +78,12 @@ const RemoteAppWrapper = forwardRef(function (
7878
...resProps,
7979
};
8080
renderDom.current = rootRef.current;
81-
LoggerInstance.log(
81+
LoggerInstance.debug(
8282
`createRemoteComponent LazyComponent render >>>`,
8383
renderProps,
8484
);
8585

86-
LoggerInstance.log(
86+
LoggerInstance.debug(
8787
`createRemoteComponent LazyComponent hostInstance >>>`,
8888
instance,
8989
);
@@ -101,7 +101,7 @@ const RemoteAppWrapper = forwardRef(function (
101101
clearTimeout(renderTimeout);
102102
setTimeout(() => {
103103
if (providerInfoRef.current?.destroy) {
104-
LoggerInstance.log(
104+
LoggerInstance.debug(
105105
`createRemoteComponent LazyComponent destroy >>>`,
106106
{ moduleName, basename, dom: renderDom.current },
107107
);
@@ -206,7 +206,7 @@ export function withRouterData<
206206
}
207207
}
208208

209-
LoggerInstance.log(`createRemoteComponent withRouterData >>>`, {
209+
LoggerInstance.debug(`createRemoteComponent withRouterData >>>`, {
210210
...props,
211211
basename,
212212
routerContextVal,
@@ -219,10 +219,13 @@ export function withRouterData<
219219

220220
useEffect(() => {
221221
if (pathname !== '' && pathname !== location.pathname) {
222-
LoggerInstance.log(`createRemoteComponent dispatchPopstateEnv >>>`, {
223-
name: props.name,
224-
pathname: location.pathname,
225-
});
222+
LoggerInstance.debug(
223+
`createRemoteComponent dispatchPopstateEnv >>>`,
224+
{
225+
name: props.name,
226+
pathname: location.pathname,
227+
},
228+
);
226229
dispatchPopstateEnv();
227230
}
228231
setPathname(location.pathname);

‎packages/bridge/bridge-react/src/router-v5.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ function WraperRouter(
1313
const { basename, ...propsRes } = props;
1414
const routerContextProps = useContext(RouterContext) || {};
1515

16-
LoggerInstance.log(`WraperRouter info >>>`, {
16+
LoggerInstance.debug(`WraperRouter info >>>`, {
1717
...routerContextProps,
1818
routerContextProps,
1919
WraperRouterProps: props,

‎packages/bridge/bridge-react/src/router-v6.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ function WraperRouter(
1313
const { basename, ...propsRes } = props;
1414
const routerContextProps = useContext(RouterContext) || {};
1515

16-
LoggerInstance.log(`WraperRouter info >>>`, {
16+
LoggerInstance.debug(`WraperRouter info >>>`, {
1717
...routerContextProps,
1818
routerContextProps,
1919
WraperRouterProps: props,
@@ -41,7 +41,7 @@ function WraperRouterProvider(
4141
const { router, ...propsRes } = props;
4242
const routerContextProps = useContext(RouterContext) || {};
4343
const routers = router.routes;
44-
LoggerInstance.log(`WraperRouterProvider info >>>`, {
44+
LoggerInstance.debug(`WraperRouterProvider info >>>`, {
4545
...routerContextProps,
4646
routerContextProps,
4747
WraperRouterProviderProps: props,

‎packages/bridge/bridge-react/src/router.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ function WrapperRouter(
1212
const { basename, ...propsRes } = props;
1313
const routerContextProps = useContext(RouterContext) || {};
1414

15-
LoggerInstance.log(`WrapperRouter info >>>`, {
15+
LoggerInstance.debug(`WrapperRouter info >>>`, {
1616
...routerContextProps,
1717
routerContextProps,
1818
WrapperRouterProps: props,
@@ -40,7 +40,7 @@ function WrapperRouterProvider(
4040
const { router, ...propsRes } = props;
4141
const routerContextProps = useContext(RouterContext) || {};
4242
const routers = router.routes;
43-
LoggerInstance.log(`WrapperRouterProvider info >>>`, {
43+
LoggerInstance.debug(`WrapperRouterProvider info >>>`, {
4444
...routerContextProps,
4545
routerContextProps,
4646
WrapperRouterProviderProps: props,

‎packages/bridge/vue3-bridge/src/create.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export function createRemoteComponent(info: {
2828
}
2929

3030
const exportName = info?.export || 'default';
31-
LoggerInstance.log(`createRemoteComponent LazyComponent create >>>`, {
31+
LoggerInstance.debug(`createRemoteComponent LazyComponent create >>>`, {
3232
basename,
3333
info,
3434
});
@@ -37,7 +37,7 @@ export function createRemoteComponent(info: {
3737
const moduleName = module && module[Symbol.for('mf_module_id')];
3838
const exportFn = module[exportName];
3939

40-
LoggerInstance.log(
40+
LoggerInstance.debug(
4141
`createRemoteComponent LazyComponent loadRemote info >>>`,
4242
{ name: moduleName, module, exportName, basename, route },
4343
);

‎packages/bridge/vue3-bridge/src/provider.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export function createBridgeComponent(bridgeInfo: ProviderFnParams) {
2727
return {
2828
__APP_VERSION__,
2929
async render(info: RenderFnParams) {
30-
LoggerInstance.log(`createBridgeComponent render Info`, info);
30+
LoggerInstance.debug(`createBridgeComponent render Info`, info);
3131
const app = Vue.createApp(bridgeInfo.rootComponent);
3232
rootMap.set(info.dom, app);
3333

@@ -75,7 +75,7 @@ export function createBridgeComponent(bridgeInfo: ProviderFnParams) {
7575
instance?.bridgeHook?.lifecycle?.afterBridgeRender?.emit(info);
7676
},
7777
destroy(info: { dom: HTMLElement }) {
78-
LoggerInstance.log(`createBridgeComponent destroy Info`, info);
78+
LoggerInstance.debug(`createBridgeComponent destroy Info`, info);
7979
const root = rootMap.get(info?.dom);
8080

8181
instance?.bridgeHook?.lifecycle?.beforeBridgeDestroy?.emit(info);

‎packages/bridge/vue3-bridge/src/remoteApp.tsx‎

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export default defineComponent({
2929
basename: props.basename,
3030
memoryRoute: props.memoryRoute,
3131
};
32-
LoggerInstance.log(
32+
LoggerInstance.debug(
3333
`createRemoteComponent LazyComponent render >>>`,
3434
renderProps,
3535
);
@@ -53,10 +53,13 @@ export default defineComponent({
5353

5454
// dispatchPopstateEnv
5555
if (pathname.value !== '' && pathname.value !== newPath) {
56-
LoggerInstance.log(`createRemoteComponent dispatchPopstateEnv >>>`, {
57-
...props,
58-
pathname: route.path,
59-
});
56+
LoggerInstance.debug(
57+
`createRemoteComponent dispatchPopstateEnv >>>`,
58+
{
59+
...props,
60+
pathname: route.path,
61+
},
62+
);
6063
dispatchPopstateEnv();
6164
}
6265
pathname.value = newPath;
@@ -68,7 +71,7 @@ export default defineComponent({
6871
});
6972

7073
onBeforeUnmount(() => {
71-
LoggerInstance.log(`createRemoteComponent LazyComponent destroy >>>`, {
74+
LoggerInstance.debug(`createRemoteComponent LazyComponent destroy >>>`, {
7275
...props,
7376
});
7477
watchStopHandle();

0 commit comments

Comments
 (0)