chore: fix package types with webpack (#2882)

Co-authored-by: ScriptedAlchemy <[email protected]>

Author: ScriptedAlchemy

packages/enhanced/src/lib/container/ContainerEntryModule.ts

@@ -119,7 +119,6 @@ class ContainerEntryModule extends Module {
    * @param {function((WebpackError | null)=, boolean=): void} callback callback function, returns true, if the module needs a rebuild
    * @returns {void}
    */
-  // @ts-expect-error typeof webpack/lib !== typeof webpack/types
   override needBuild(
     context: NeedBuildContext,
     callback: (
@@ -138,7 +137,6 @@ class ContainerEntryModule extends Module {
    * @param {function(WebpackError): void} callback callback function
    * @returns {void}
    */
-  // @ts-expect-error typeof webpack/lib !== typeof webpack/types
   override build(
     options: WebpackOptions,
     compilation: Compilation,
@@ -180,10 +178,7 @@ class ContainerEntryModule extends Module {
       ) as unknown as Dependency,
     );
 
-    this.addDependency(
-      // @ts-expect-error flaky type for EntryDependency
-      new EntryDependency(this._injectRuntimeEntry),
-    );
+    this.addDependency(new EntryDependency(this._injectRuntimeEntry));
 
     callback();
   }

packages/enhanced/src/lib/container/ContainerEntryModuleFactory.ts

@@ -33,7 +33,6 @@ export default class ContainerEntryModuleFactory extends ModuleFactory {
     const dep = containerDependencies[0];
 
     callback(null, {
-      // @ts-expect-error missing some deps
       module: new ContainerEntryModule(
         dep.name,
         dep.exposes,

packages/enhanced/src/lib/container/ContainerPlugin.ts

@@ -7,7 +7,13 @@ import ContainerEntryDependency from './ContainerEntryDependency';
 import ContainerEntryModuleFactory from './ContainerEntryModuleFactory';
 import ContainerExposedDependency from './ContainerExposedDependency';
 import { parseOptions } from './options';
-import type { optimize, Compiler, Compilation } from 'webpack';
+import type {
+  optimize,
+  Compiler,
+  Compilation,
+  WebpackError,
+  WebpackPluginInstance,
+} from 'webpack';
 import type { containerPlugin } from '@module-federation/sdk';
 import FederationRuntimePlugin from './runtime/FederationRuntimePlugin';
 import checkOptions from '../../schemas/container/ContainerPlugin.check';
@@ -148,13 +154,15 @@ class ContainerPlugin {
   }
 
   apply(compiler: Compiler): void {
-    const useModuleFederationPlugin = compiler.options.plugins.find((p) => {
-      if (typeof p !== 'object' || !p) {
-        return false;
-      }
+    const useModuleFederationPlugin = compiler.options.plugins.find(
+      (p: WebpackPluginInstance) => {
+        if (typeof p !== 'object' || !p) {
+          return false;
+        }
 
-      return p['name'] === 'ModuleFederationPlugin';
-    });
+        return p['name'] === 'ModuleFederationPlugin';
+      },
+    );
 
     if (!useModuleFederationPlugin) {
       ContainerPlugin.patchChunkSplit(compiler, this._options.name);

packages/enhanced/src/lib/container/FallbackModule.ts

@@ -92,7 +92,6 @@ class FallbackModule extends Module {
    * @param {function((WebpackError | null)=, boolean=): void} callback callback function, returns true, if the module needs a rebuild
    * @returns {void}
    */
-  // @ts-expect-error incompatible context types
   override needBuild(
     context: NeedBuildContext,
     callback: (error: WebpackError | null, result?: boolean) => void,
@@ -108,7 +107,6 @@ class FallbackModule extends Module {
    * @param {function(WebpackError=): void} callback callback function
    * @returns {void}
    */
-  // @ts-expect-error incompatible option types
   override build(
     options: WebpackOptions,
     compilation: Compilation,
@@ -147,7 +145,6 @@ class FallbackModule extends Module {
    * @param {CodeGenerationContext} context context for code generation
    * @returns {CodeGenerationResult} result
    */
-  // @ts-expect-error incompatible CodeGenerationContext
   override codeGeneration({
     runtimeTemplate,
     moduleGraph,

packages/enhanced/src/lib/container/ModuleFederationPlugin.ts

@@ -19,6 +19,7 @@ import ContainerPlugin from './ContainerPlugin';
 import ContainerReferencePlugin from './ContainerReferencePlugin';
 import FederationRuntimePlugin from './runtime/FederationRuntimePlugin';
 import { RemoteEntryPlugin } from './runtime/RemoteEntryPlugin';
+import { ExternalsType } from 'webpack/declarations/WebpackOptions';
 
 const isValidExternalsType = require(
   normalizeWebpackPath(
@@ -53,7 +54,7 @@ class ModuleFederationPlugin implements WebpackPluginInstance {
   private _patchBundlerConfig(compiler: Compiler): void {
     const { name } = this._options;
     const MFPluginNum = compiler.options.plugins.filter(
-      (p) => p && p.name === 'ModuleFederationPlugin',
+      (p: WebpackPluginInstance) => p && p['name'] === 'ModuleFederationPlugin',
     ).length;
     if (name && MFPluginNum < 2) {
       new compiler.webpack.DefinePlugin({
@@ -85,8 +86,8 @@ class ModuleFederationPlugin implements WebpackPluginInstance {
     const remoteType =
       options.remoteType ||
       (options.library && isValidExternalsType(options.library.type)
-        ? options.library.type
-        : 'script');
+        ? (options.library.type as ExternalsType)
+        : ('script' as ExternalsType));
 
     const useContainerPlugin =
       options.exposes &&
@@ -138,7 +139,6 @@ class ModuleFederationPlugin implements WebpackPluginInstance {
           : Object.keys(options.remotes).length > 0)
       ) {
         new ContainerReferencePlugin({
-          // @ts-expect-error this should not be a string
           remoteType,
           shareScope: options.shareScope,
           remotes: options.remotes,

packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts

@@ -1,4 +1,4 @@
-import type { Compiler } from 'webpack';
+import type { Compiler, WebpackPluginInstance } from 'webpack';
 import { normalizeWebpackPath } from '@module-federation/sdk/normalize-webpack-path';
 import FederationRuntimeModule from './FederationRuntimeModule';
 import {
@@ -244,25 +244,29 @@ class FederationRuntimePlugin {
   }
 
   apply(compiler: Compiler) {
-    const useModuleFederationPlugin = compiler.options.plugins.find((p) => {
-      if (typeof p !== 'object' || !p) {
-        return false;
-      }
-      return p['name'] === 'ModuleFederationPlugin';
-    });
+    const useModuleFederationPlugin = compiler.options.plugins.find(
+      (p: WebpackPluginInstance) => {
+        if (typeof p !== 'object' || !p) {
+          return false;
+        }
+        return p['name'] === 'ModuleFederationPlugin';
+      },
+    );
 
     if (useModuleFederationPlugin && !this.options) {
       // @ts-ignore
       this.options = useModuleFederationPlugin._options;
     }
 
-    const useContainerPlugin = compiler.options.plugins.find((p) => {
-      if (typeof p !== 'object' || !p) {
-        return false;
-      }
+    const useContainerPlugin = compiler.options.plugins.find(
+      (p: WebpackPluginInstance) => {
+        if (typeof p !== 'object' || !p) {
+          return false;
+        }
 
-      return p['name'] === 'ContainerPlugin';
-    });
+        return p['name'] === 'ContainerPlugin';
+      },
+    );
 
     if (useContainerPlugin && !this.options) {
       // @ts-ignore

packages/enhanced/src/wrapper/ModuleFederationPlugin.ts

@@ -21,7 +21,11 @@ export default class ModuleFederationPlugin implements WebpackPluginInstance {
   }
 
   apply(compiler: Compiler) {
-    if (!compiler.options.plugins.find((p) => p && p.name === PLUGIN_NAME)) {
+    if (
+      !compiler.options.plugins.find(
+        (p: WebpackPluginInstance) => p && p['name'] === PLUGIN_NAME,
+      )
+    ) {
       compiler.options.plugins.push(this);
     }
     process.env['FEDERATION_WEBPACK_PATH'] =

packages/nextjs-mf/src/plugins/NextFederationPlugin/index.ts

@@ -9,7 +9,7 @@ import type {
   NextFederationPluginExtraOptions,
   NextFederationPluginOptions,
 } from '@module-federation/utilities';
-import type { Compiler } from 'webpack';
+import type { Compiler, WebpackPluginInstance } from 'webpack';
 import { getWebpackPath } from '@module-federation/sdk/normalize-webpack-path';
 import CopyFederationPlugin from '../CopyFederationPlugin';
 import { exposeNextjsPages } from '../../loaders/nextPageMapLoader';
@@ -88,7 +88,8 @@ export class NextFederationPlugin {
 
   private validateOptions(compiler: Compiler): boolean {
     const manifestPlugin = compiler.options.plugins.find(
-      (p) => p?.constructor.name === 'BuildManifestPlugin',
+      (p: WebpackPluginInstance) =>
+        p?.constructor.name === 'BuildManifestPlugin',
     );
 
     if (manifestPlugin) {

packages/typescript/src/plugins/FederatedTypesPlugin.ts

@@ -1,7 +1,7 @@
 import fs from 'fs';
 import path from 'path';
 import axios from 'axios';
-import { Compiler } from 'webpack';
+import { Compiler, WebpackPluginInstance } from 'webpack';
 import { startServer, stopServer } from '../lib/server';
 import { TypescriptCompiler } from '../lib/TypescriptCompiler';
 import {
@@ -40,7 +40,8 @@ export class FederatedTypesPlugin {
 
     if (
       !compiler.options.plugins.some(
-        (p) => SUPPORTED_PLUGINS.indexOf(p?.constructor.name ?? '') !== -1,
+        (p: WebpackPluginInstance) =>
+          SUPPORTED_PLUGINS.indexOf(p?.constructor.name ?? '') !== -1,
       )
     ) {
       this.logger.error(