feat: align with shared import:false (#2330)

Author: 2heal1

.changeset/angry-ways-return.md

@@ -0,0 +1,6 @@
+---
+'@module-federation/runtime': patch
+'@module-federation/enhanced': patch
+---
+
+feat: support config shared import:false in runtime

packages/runtime/__tests__/share.ts

@@ -122,3 +122,35 @@ export const arrayShared = {
 export const arraySharedInfos = {
   'react-dom': arrayShared.shared['react-dom'],
 };
+
+export const shareInfoWithoutLibAndGetConsumer = {
+  name: '@federation/shared-config-consumer',
+  remotes: [],
+  shared: {
+    'react-dom': {
+      scope: ['default'],
+      shareConfig: {
+        singleton: true,
+        requiredVersion: '^16.0.0',
+        eager: false,
+      },
+    },
+  },
+};
+
+export const shareInfoWithoutLibAndGetProvider = {
+  name: '@federation/shared-config-provider',
+  remotes: [],
+  shared: {
+    'react-dom': {
+      version: '16.0.0',
+      scope: ['default'],
+      get: () =>
+        Promise.resolve(() => ({
+          default: 'react-dom',
+          version: '16.0.0',
+          from: '@federation/shared-config-provider',
+        })),
+    },
+  },
+};

packages/runtime/__tests__/shares.spec.ts

@@ -7,6 +7,8 @@ import {
   localMergeShareInfos,
   arrayShared,
   arraySharedInfos,
+  shareInfoWithoutLibAndGetConsumer,
+  shareInfoWithoutLibAndGetProvider,
 } from './share';
 // import { assert } from '../src/utils/logger';
 import { FederationHost } from '../src/core';
@@ -35,6 +37,29 @@ describe('shared', () => {
     expect(FederationInstance.options.shared).toMatchObject(arraySharedInfos);
   });
 
+  it('init shared without lib and get', async () => {
+    const provider = init(shareInfoWithoutLibAndGetProvider);
+
+    await provider.loadShare<{
+      version: string;
+      from: string;
+    }>('react-dom');
+
+    const consumer = init(shareInfoWithoutLibAndGetConsumer);
+    consumer.initShareScopeMap('default', provider.shareScopeMap['default']);
+
+    debugger;
+    const reactDomInstance = await consumer.loadShare<{
+      version: string;
+      from: string;
+    }>('react-dom');
+    assert(reactDomInstance);
+    const reactDomInstanceRes = reactDomInstance();
+    assert(reactDomInstanceRes, "reactInstance can't be undefined");
+    expect(reactDomInstanceRes.from).toBe('@federation/shared-config-provider');
+    expect(reactDomInstanceRes.version).toBe('16.0.0');
+  });
+
   it('loadShare singleton', async () => {
     const gmConfig1 = {
       name: '@federation/loadShare',

packages/runtime/src/type/config.ts

@@ -53,7 +53,7 @@ export interface SharedConfig {
 }
 
 type SharedBaseArgs = {
-  version: string;
+  version?: string;
   shareConfig?: SharedConfig;
   scope?: string | Array<string>;
   deps?: Array<string>;
@@ -64,7 +64,8 @@ export type SharedGetter = (() => () => Module) | (() => Promise<() => Module>);
 
 export type ShareArgs =
   | (SharedBaseArgs & { get: SharedGetter })
-  | (SharedBaseArgs & { lib: () => Module });
+  | (SharedBaseArgs & { lib: () => Module })
+  | SharedBaseArgs;
 
 export type Shared = {
   version: string;

packages/runtime/src/utils/share.ts

@@ -14,14 +14,22 @@ import { satisfy } from './semver';
 import { SyncWaterfallHook } from './hooks';
 import { arrayOptions } from './tool';
 
-export function formatShare(shareArgs: ShareArgs, from: string): Shared {
+export function formatShare(
+  shareArgs: ShareArgs,
+  from: string,
+  name: string,
+): Shared {
   let get: Shared['get'];
   if ('get' in shareArgs) {
     // eslint-disable-next-line prefer-destructuring
     get = shareArgs.get;
-  } else {
-    // @ts-ignore ignore
+  } else if ('lib' in shareArgs) {
     get = () => Promise.resolve(shareArgs.lib);
+  } else {
+    get = () =>
+      Promise.resolve(() => {
+        throw new Error(`Can not get shared '${name}'!`);
+      });
   }
   return {
     deps: [],
@@ -38,6 +46,7 @@ export function formatShare(shareArgs: ShareArgs, from: string): Shared {
     },
     get,
     loaded: 'lib' in shareArgs ? true : undefined,
+    version: shareArgs.version ?? '0',
     scope: Array.isArray(shareArgs.scope) ? shareArgs.scope : ['default'],
     strategy: shareArgs.strategy || 'version-first',
   };
@@ -54,7 +63,7 @@ export function formatShareConfigs(
     const arrayShareArgs = arrayOptions(shareArgs[pkgName]);
     res[pkgName] = res[pkgName] || [];
     arrayShareArgs.forEach((shareConfig) => {
-      res[pkgName].push(formatShare(shareConfig, from));
+      res[pkgName].push(formatShare(shareConfig, from, pkgName));
     });
     return res;
   }, {} as ShareInfos);