fix(enhanced): allow dts plugin to be disabled (#2321)

Co-authored-by: ScriptedAlchemy <[email protected]>
Co-authored-by: Hanric <[email protected]>

Author: ScriptedAlchemy

.changeset/dry-walls-enjoy.md

@@ -0,0 +1,8 @@
+---
+'@module-federation/dts-plugin': patch
+'@module-federation/enhanced': patch
+'website-new': patch
+'@module-federation/sdk': patch
+---
+
+fix: detect whether the project is ts

.changeset/sour-kangaroos-enjoy.md

@@ -0,0 +1,5 @@
+---
+'@module-federation/enhanced': patch
+---
+
+allow dts plugin to be disabled

apps/website-new/docs/en/configure/dts.mdx

@@ -13,6 +13,7 @@ The `PluginDtsOptions` types are as follows:
 interface PluginDtsOptions {
   generateTypes?: boolean | DtsRemoteOptions;
   consumeTypes?: boolean | DtsHostOptions;
+  tsConfigPath?: string;
 }
 ```
 
@@ -102,7 +103,7 @@ Whether to throw an error when a problem is encountered during type generation
 - Type: `string`
 - Required: No
 - Default value: `path.join(process.cwd(),'./tsconfig.json')`
-
+> priority: dts.generateTypes.tsConfigPath > dts.tsConfigPath
 tsconfig configuration file path
 
 #### typesFolder
@@ -206,3 +207,11 @@ Before loading type files, whether to delete the previously loaded `typesFolder`
 - Default value: `'@mf-types'`
 
 `typesFolder` corresponding to `remotes` directory configuration
+
+### tsConfigPath
+
+- Type: `string`
+- Required: No
+- Default value: `path.join(process.cwd(),'./tsconfig.json')`
+
+tsconfig configuration file path

apps/website-new/docs/zh/configure/dts.mdx

@@ -13,6 +13,7 @@
 interface PluginDtsOptions {
   generateTypes?: boolean | DtsRemoteOptions;
   consumeTypes?: boolean | DtsHostOptions;
+  tsConfigPath?: string;
 }
 ```
 
@@ -102,6 +103,7 @@ interface DtsRemoteOptions {
 - 类型：`string`
 - 是否必填：否
 - 默认值：`path.join(process.cwd(),'./tsconfig.json')`
+> 优先级：dts.generateTypes.tsConfigPath > dts.tsConfigPath
 
 tsconfig 配置文件路径
 
@@ -206,3 +208,11 @@ interface DtsHostOptions {
 - 默认值：`'@mf-types'`
 
 对应 `remotes` 目录配置的 `typesFolder`
+
+### tsConfigPath
+
+- 类型：`string`
+- 是否必填：否
+- 默认值：`path.join(process.cwd(),'./tsconfig.json')`
+
+tsconfig 配置文件路径

package.json

@@ -152,7 +152,6 @@
     "@vitest/coverage-istanbul": "1.2.2",
     "@vitest/coverage-v8": "1.2.2",
     "@vitest/ui": "1.2.2",
-    "antora-navigator-extension": "https://gitlab.com/opendevise/oss/antora-navigator-extension/-/archive/main/antora-navigator-extension-main.tar.gz",
     "autoprefixer": "10.4.17",
     "babel-jest": "29.7.0",
     "babel-loader": "9.1.3",

packages/dts-plugin/src/plugins/DevPlugin.ts

@@ -138,7 +138,10 @@ export class DevPlugin implements WebpackPluginInstance {
     const defaultConsumeTypes = { consumeAPITypes: true };
     const normalizedDtsOptions =
       normalizeOptions<moduleFederationPlugin.PluginDtsOptions>(
-        isTSProject(undefined, compiler.context),
+        isTSProject(
+          typeof dts === 'object' ? dts.tsConfigPath : undefined,
+          compiler.context,
+        ),
         {
           //  remote types dist(.dev-server) not be used currently, so no need to set extractThirdParty etc
           generateTypes: defaultGenerateTypes,
@@ -150,7 +153,7 @@ export class DevPlugin implements WebpackPluginInstance {
 
     const normalizedGenerateTypes =
       normalizeOptions<moduleFederationPlugin.DtsRemoteOptions>(
-        normalizedDtsOptions === false,
+        Boolean(normalizedDtsOptions),
         defaultGenerateTypes,
         'mfOptions.dts.generateTypes',
       )(
@@ -202,9 +205,24 @@ export class DevPlugin implements WebpackPluginInstance {
             abortOnError: false,
             ...normalizedConsumeTypes,
           };
+
     const extraOptions = normalizedDtsOptions
       ? normalizedDtsOptions.extraOptions || {}
       : {};
+
+    if (!remote && !host && normalizedDev.disableLiveReload) {
+      return;
+    }
+
+    if (
+      remote &&
+      !remote?.tsConfigPath &&
+      typeof normalizedDtsOptions === 'object' &&
+      normalizedDtsOptions.tsConfigPath
+    ) {
+      remote.tsConfigPath = normalizedDtsOptions.tsConfigPath;
+    }
+
     this._devWorker = createDevWorker({
       name,
       remote: remote,

packages/dts-plugin/src/plugins/GenerateTypesPlugin.ts

@@ -51,6 +51,10 @@ export class GenerateTypesPlugin implements WebpackPluginInstance {
       extraOptions: dtsOptions.extraOptions || {},
     };
 
+    if (dtsOptions.tsConfigPath && !finalOptions.remote.tsConfigPath) {
+      finalOptions.remote.tsConfigPath = dtsOptions.tsConfigPath;
+    }
+
     validateOptions(finalOptions.remote);
     const isProd = !isDev();
     const getGenerateTypesFn = () => {

packages/dts-plugin/src/plugins/TypesPlugin.ts

@@ -26,7 +26,12 @@ class TypesPlugin implements WebpackPluginInstance {
     const defaultConsumeTypes = { abortOnError: false, consumeAPITypes: true };
     const normalizedDtsOptions =
       normalizeOptions<moduleFederationPlugin.PluginDtsOptions>(
-        isTSProject(undefined, compiler.context),
+        isTSProject(
+          typeof options.dts === 'object'
+            ? options.dts.tsConfigPath
+            : undefined,
+          compiler.context,
+        ),
         {
           generateTypes: defaultGenerateTypes,
           consumeTypes: defaultConsumeTypes,

packages/enhanced/src/lib/container/ModuleFederationPlugin.ts

@@ -88,7 +88,9 @@ class ModuleFederationPlugin implements WebpackPluginInstance {
       }
     }
 
-    new DtsPlugin(options).apply(compiler);
+    if (options.dts !== false) {
+      new DtsPlugin(options).apply(compiler);
+    }
 
     if (
       library &&

packages/enhanced/src/schemas/container/ModuleFederationPlugin.ts

@@ -645,6 +645,10 @@ export default {
           type: 'object',
           additionalProperties: true,
         },
+        tsConfigPath: {
+          description: 'The tsconfig path of the project.',
+          type: 'string',
+        },
         implementation: {
           description: 'The implementation of the DTS Manager.',
           type: 'string',