refactor(enhanced): clean up sharing plugins and improve filtering

- Remove unnecessary wrapper functions in ConsumeSharedPlugin and ProvideSharedPlugin
- Use createLookupKeyForSharing utility function directly
- Remove singleton warnings for request include/exclude filters
- Keep singleton warnings only for version include/exclude filters
- Sync devtools.yml with main branch

Author: ScriptedAlchemy

.github/workflows/devtools.yml

@@ -53,7 +53,7 @@ jobs:
         run: npx cypress install
 
       - name: Run Affected Build
-        run: npx nx run-many --targets=build --projects=tag:type:pkg --parallel=1 --skip-nx-cache
+        run: npx nx run-many --targets=build --projects=tag:type:pkg --skip-nx-cache
 
       - name: Configuration xvfb
         shell: bash

packages/enhanced/src/lib/sharing/ConsumeSharedPlugin.ts

@@ -67,14 +67,6 @@ const RESOLVE_OPTIONS: ResolveOptionsWithDependencyType = {
 };
 const PLUGIN_NAME = 'ConsumeSharedPlugin';
 
-// Helper function to create composite key
-function createLookupKey(
-  request: string,
-  contextInfo: ModuleFactoryCreateDataContextInfo,
-): string {
-  return createLookupKeyForSharing(request, contextInfo.issuerLayer);
-}
-
 class ConsumeSharedPlugin {
   private _consumes: [string, ConsumeOptions][];
 
@@ -408,7 +400,7 @@ class ConsumeSharedPlugin {
                 return;
               }
               const match = unresolvedConsumes.get(
-                createLookupKey(request, contextInfo),
+                createLookupKeyForSharing(request, contextInfo.issuerLayer),
               );
 
               if (match !== undefined) {
@@ -432,30 +424,6 @@ class ConsumeSharedPlugin {
 
                   const shareKey = options.shareKey + remainder;
 
-                  // Check singleton warning for request filters
-                  if (options.singleton) {
-                    if (options.include?.request) {
-                      addSingletonFilterWarning(
-                        compilation,
-                        shareKey,
-                        'include',
-                        'request',
-                        options.include.request,
-                        request,
-                      );
-                    }
-                    if (options.exclude?.request) {
-                      addSingletonFilterWarning(
-                        compilation,
-                        shareKey,
-                        'exclude',
-                        'request',
-                        options.exclude.request,
-                        request,
-                      );
-                    }
-                  }
-
                   return createConsumeSharedModule(context, request, {
                     ...options,
                     import: options.import

packages/enhanced/src/lib/sharing/ProvideSharedPlugin.ts

@@ -65,14 +65,6 @@ const validate = createSchemaValidation(
 
 /** @typedef {Map<string, { config: ProvideOptions, version: string | undefined | false }>} ResolvedProvideMap */
 
-// Helper function to create composite key
-function createLookupKey(
-  request: string,
-  config: { layer?: string | null },
-): string {
-  return createLookupKeyForSharing(request, config.layer);
-}
-
 class ProvideSharedPlugin {
   private _provides: [string, ProvidesConfig][];
 
@@ -146,7 +138,10 @@ class ProvideSharedPlugin {
         const prefixMatchProvides: Map<string, ProvidesConfig> = new Map();
         for (const [request, config] of this._provides) {
           const actualRequest = config.request || request;
-          const lookupKey = createLookupKey(actualRequest, config);
+          const lookupKey = createLookupKeyForSharing(
+            actualRequest,
+            config.layer,
+          );
           if (/^(\/|[A-Za-z]:\\|\\\\|\.\.?(\/|$))/.test(actualRequest)) {
             // relative request - apply filtering if include/exclude are defined
             if (this.shouldProvideSharedModule(config)) {
@@ -177,18 +172,20 @@ class ProvideSharedPlugin {
           'ProvideSharedPlugin',
           (module, { resource, resourceResolveData }, resolveData) => {
             const moduleLayer = module.layer;
-            const lookupKey = createLookupKey(resource || '', {
-              layer: moduleLayer || undefined,
-            });
+            const lookupKey = createLookupKeyForSharing(
+              resource || '',
+              moduleLayer || undefined,
+            );
 
             if (resource && resolvedProvideMap.has(lookupKey)) {
               return module;
             }
             const { request } = resolveData;
             {
-              const requestKey = createLookupKey(request, {
-                layer: moduleLayer || undefined,
-              });
+              const requestKey = createLookupKeyForSharing(
+                request,
+                moduleLayer || undefined,
+              );
               const config = matchProvides.get(requestKey);
               if (config !== undefined && resource) {
                 this.provideSharedModule(
@@ -220,32 +217,6 @@ class ProvideSharedPlugin {
 
                 const shareKey = config.shareKey + remainder;
 
-                // Check singleton warning for request filters
-                if (config.singleton) {
-                  if (config.include?.request) {
-                    addSingletonFilterWarning(
-                      compilation,
-                      shareKey,
-                      'include',
-                      'request',
-                      config.include.request,
-                      request,
-                      resource,
-                    );
-                  }
-                  if (config.exclude?.request) {
-                    addSingletonFilterWarning(
-                      compilation,
-                      shareKey,
-                      'exclude',
-                      'request',
-                      config.exclude.request,
-                      request,
-                      resource,
-                    );
-                  }
-                }
-
                 this.provideSharedModule(
                   compilation,
                   resolvedProvideMap,
@@ -431,7 +402,7 @@ class ProvideSharedPlugin {
       }
     }
 
-    const lookupKey = createLookupKey(resource, config);
+    const lookupKey = createLookupKeyForSharing(resource, config.layer);
     resolvedProvideMap.set(lookupKey, {
       config,
       version,