Skip to content

Commit 98b78aa

Browse files
fix: stabilize router e2e workflow (#4137)
1 parent e530db2 commit 98b78aa

File tree

3 files changed

+389
-3
lines changed

3 files changed

+389
-3
lines changed

.github/workflows/e2e-router.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,4 +62,4 @@ jobs:
6262

6363
- name: E2E Test for Runtime Demo
6464
if: steps.check-ci.outcome == 'success'
65-
run: npx kill-port --port 2000,2001,2002,2003,2004,2200,2100 && pnpm run app:router:dev & echo "done" && sleep 30 && npx nx run-many --target=test:e2e --projects=router-host-2000 --parallel=1 && lsof -ti tcp:2000,2001,2002,2003,2004,2200,2100 | xargs kill
65+
run: node tools/scripts/run-router-e2e.mjs --mode=dev

apps/router-demo/router-host-2000/project.json

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,12 @@
4343
"browser": "electron",
4444
"exit": false,
4545
"watch": true
46+
},
47+
"ci": {
48+
"watch": false,
49+
"headed": false,
50+
"exit": true,
51+
"browser": "chrome"
4652
}
4753
}
4854
},
@@ -52,11 +58,11 @@
5258
"parallel": true,
5359
"commands": [
5460
{
55-
"command": "lsof -i:2000 || nx run router-host-2000:serve",
61+
"command": "lsof -i:2000 || NX_TUI=false nx run router-host-2000:serve",
5662
"forwardAllArgs": false
5763
},
5864
{
59-
"command": "sleep 4 && nx run router-host-2000:e2e --watch",
65+
"command": "pnpm exec wait-on http://127.0.0.1:2000 && NX_TUI=false nx run router-host-2000:e2e --configuration=ci",
6066
"forwardAllArgs": true
6167
}
6268
]

0 commit comments

Comments
 (0)