Skip to content

Commit 9b4455b

Browse files
chore: remove vite subproject and add changesets for PRs
- Remove accidentally added vite git submodule from repository - Add changeset for PR #3915 (Enhanced Layer Support) - Documents issuerLayer fallback logic implementation - Minor version bump for new feature - Add changeset for PR #3969 (Comprehensive Test Coverage) - Documents 73 tests for ProvideSharedPlugin - Documents 70+ tests for ConsumeSharedPlugin - Patch version bumps for test additions These changesets ensure proper version bumping and changelog generation for the incremental PR features and test coverage. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 9a6108a commit 9b4455b

File tree

4 files changed

+46
-1
lines changed

4 files changed

+46
-1
lines changed
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
---
2+
"@module-federation/enhanced": patch
3+
---
4+
5+
test: implement comprehensive test coverage for ConsumeSharedPlugin
6+
7+
- Add 70+ comprehensive tests for createConsumeSharedModule method covering all critical business logic
8+
- Implement tests for import resolution logic including error handling and direct fallback regex matching
9+
- Add comprehensive requiredVersion resolution tests for package name extraction and version resolution
10+
- Implement include/exclude version filtering tests with fallback version support
11+
- Add singleton warning generation tests for version filters as specified
12+
- Implement package.json reading error scenarios and edge case handling
13+
- Add apply method tests for plugin registration logic and hook setup
14+
- Achieve test coverage parity with ProvideSharedPlugin (70+ tests each)
15+
16+
This addresses the requirement for "immense test coverage for consume share plugin and provide share plugin to cover all its very complex logic" and ensures comprehensive testing of multi-stage module resolution, layer matching, version filtering, and error handling.
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
---
2+
"@module-federation/enhanced": patch
3+
---
4+
5+
test: add comprehensive test coverage for ProvideSharedPlugin
6+
7+
- Add 73 comprehensive tests covering all critical business logic and edge cases
8+
- Implement complete shouldProvideSharedModule method coverage (15 tests) for version filtering with semver validation
9+
- Add provideSharedModule method tests (16 tests) covering version resolution, request pattern filtering, and warning generation
10+
- Implement module matching and resolution stage tests (20 tests) for multi-stage resolution logic
11+
- Validate business rules: warnings only for version filters with singleton, not request filters
12+
- Cover all critical private methods with proper TypeScript handling using @ts-ignore
13+
- Fix container utils mock for dependency factory operations
14+
- Add performance and memory usage tests for large-scale scenarios
15+
16+
This ensures comprehensive test coverage for ProvideSharedPlugin's complex module sharing logic and prevents regressions.
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
---
2+
"@module-federation/enhanced": minor
3+
---
4+
5+
feat: implement enhanced layer support with issuerLayer fallback logic
6+
7+
- Add issuerLayer parameter support throughout ConsumeSharedPlugin and related modules
8+
- Implement issuerLayer fallback pattern in module resolution (tries issuerLayer first, then falls back to undefined)
9+
- Add createLookupKeyForSharing utility to generate layer-aware lookup keys (e.g., "(client)react")
10+
- Support layer-specific module sharing configuration with proper precedence rules
11+
- Add comprehensive unit tests for issuerLayer fallback behavior and utility functions
12+
- Fix test infrastructure issues and improve test assertions for better CI stability
13+
14+
This completes PR9: Enhanced Layer Support as defined in the incremental PR plan, enabling more granular control over shared module resolution based on issuer layers.

vite

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)