Skip to content

Commit b704f30

Browse files
authored
fix(runtime): remove crossorigin attr from link tag which not preload… (#3057)
1 parent 8a77291 commit b704f30

File tree

2 files changed

+18
-7
lines changed

2 files changed

+18
-7
lines changed

.changeset/cyan-mangos-jog.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@module-federation/runtime': patch
3+
---
4+
5+
fix(runtime): remove crossorigin attr from link tag which not preload success

packages/runtime/src/utils/preload.ts

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ export function preloadAssets(
6969
host: FederationHost,
7070
assets: PreloadAssets,
7171
// It is used to distinguish preload from load remote parallel loading
72-
useLinkPreload: boolean = true,
72+
useLinkPreload = true,
7373
): void {
7474
const { cssAssets, jsAssetsWithoutEntry, entryAssets } = assets;
7575

@@ -96,12 +96,13 @@ export function preloadAssets(
9696
const defaultAttrs = {
9797
rel: 'preload',
9898
as: 'style',
99-
crossorigin: 'anonymous',
10099
};
101100
cssAssets.forEach((cssUrl) => {
102101
const { link: cssEl, needAttach } = createLink({
103102
url: cssUrl,
104-
cb: () => {},
103+
cb: () => {
104+
// noop
105+
},
105106
attrs: defaultAttrs,
106107
createLinkHook: (url, attrs) => {
107108
const res = host.loaderHook.lifecycle.createLink.emit({
@@ -125,7 +126,9 @@ export function preloadAssets(
125126
cssAssets.forEach((cssUrl) => {
126127
const { link: cssEl, needAttach } = createLink({
127128
url: cssUrl,
128-
cb: () => {},
129+
cb: () => {
130+
// noop
131+
},
129132
attrs: defaultAttrs,
130133
createLinkHook: (url, attrs) => {
131134
const res = host.loaderHook.lifecycle.createLink.emit({
@@ -148,12 +151,13 @@ export function preloadAssets(
148151
const defaultAttrs = {
149152
rel: 'preload',
150153
as: 'script',
151-
crossorigin: 'anonymous',
152154
};
153155
jsAssetsWithoutEntry.forEach((jsUrl) => {
154156
const { link: linkEl, needAttach } = createLink({
155157
url: jsUrl,
156-
cb: () => {},
158+
cb: () => {
159+
// noop
160+
},
157161
attrs: defaultAttrs,
158162
createLinkHook: (url: string, attrs) => {
159163
const res = host.loaderHook.lifecycle.createLink.emit({
@@ -176,7 +180,9 @@ export function preloadAssets(
176180
jsAssetsWithoutEntry.forEach((jsUrl) => {
177181
const { script: scriptEl, needAttach } = createScript({
178182
url: jsUrl,
179-
cb: () => {},
183+
cb: () => {
184+
// noop
185+
},
180186
attrs: defaultAttrs,
181187
createScriptHook: (url: string, attrs: any) => {
182188
const res = host.loaderHook.lifecycle.createScript.emit({

0 commit comments

Comments
 (0)