fix: parameter url for fetch retry options should not be necessary (#3175)

Author: danpeen

.changeset/little-insects-lick.md

@@ -0,0 +1,6 @@
+---
+'@module-federation/retry-plugin': patch
+'website-new': patch
+---
+
+fix: parameter url for fetch options should not be necessary

apps/website-new/docs/en/plugin/plugins/retry-plugin.mdx

@@ -184,7 +184,7 @@ init({
         // the retry resource url
         url: 'http://localhost:2001/-mf-manifest.json',
         // after all retried failed, set a fallback function to guarantee a fallback resource
-        fallback: () => 'http://localhost:2002/mf-manifest.json',
+        fallback: (url: string) => 'http://localhost:2002/mf-manifest.json',
       },
       script: {
         // the retry times

apps/website-new/docs/zh/plugin/plugins/retry-plugin.mdx

@@ -95,7 +95,7 @@ type FetchWithRetryOptions = {
   options?: RequestInit;
   retryTimes?: number;
   retryDelay?: number;
-  fallback?: () => string;
+  fallback?: (url: string) => string;
 }
 
 type ScriptWithRetryOptions = {

packages/retry-plugin/src/fetch-retry.ts

@@ -1,4 +1,4 @@
-import type { FetchWithRetryOptions } from './types';
+import type { RequiredFetchWithRetryOptions } from './types';
 import {
   defaultRetries,
   defaultRetryDelay,
@@ -12,7 +12,7 @@ async function fetchWithRetry({
   retryTimes = defaultRetries, // retry times
   retryDelay = defaultRetryDelay, // retry delay
   fallback, // fallback url
-}: FetchWithRetryOptions) {
+}: RequiredFetchWithRetryOptions) {
   try {
     const response = await fetch(url, options);
 

packages/retry-plugin/src/types.d.ts

@@ -1,5 +1,5 @@
 export interface FetchWithRetryOptions {
-  url: string;
+  url?: string;
   options?: RequestInit;
   retryTimes?: number;
   retryDelay?: number;
@@ -19,3 +19,8 @@ export type RetryPluginParams = {
   fetch?: FetchWithRetryOptions;
   script?: ScriptWithRetryOptions;
 };
+
+export type RequiredFetchWithRetryOptions = Required<
+  Pick<FetchWithRetryOptions, 'url'>
+> &
+  Omit<FetchWithRetryOptions, 'url'>;