Skip to content

Commit f3d159b

Browse files
chore: update ci build tags excldues for test (#2344)
Co-authored-by: ScriptedAlchemy <[email protected]> Co-authored-by: 2heal1 <[email protected]>
1 parent 35ebb46 commit f3d159b

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.github/workflows/build-and-test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,13 @@ jobs:
3838
run: npx nx format:check
3939

4040
- name: Run Affected Build
41-
run: npx nx affected -t build --parallel=10 --exclude='*,!tag:package'
41+
run: npx nx affected -t build --parallel=10 --exclude='*,!tag:type:pkg'
4242

4343
- name: Run Affected Lint
4444
run: npx nx affected -t lint --parallel=7 --exclude='*,!tag:package'
4545

4646
- name: Run Affected Test
47-
run: npx nx affected -t test --parallel=3 --exclude='*,!tag:package'
47+
run: npx nx affected -t test --parallel=3 --exclude='*,!tag:type:pkg'
4848

4949
- name: E2E Test for Next.js
5050
run: pnpm run app:next:dev & echo "done" && sleep 50 && npx nx run-many --target=test:e2e --projects=3000-home,3001-shop,3002-checkout --parallel=2 && lsof -ti tcp:3000,3001,3002 | xargs kill

packages/runtime/__tests__/shares.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -743,7 +743,8 @@ describe('with shareScope shared', () => {
743743
assert(shared, "shared can't be null");
744744
const sharedRes = shared();
745745
assert(sharedRes, "sharedRes can't be null");
746-
expect(sharedRes.from).toEqual('@shared-single/runtime-deps');
746+
// default strategy is version-first, so the priority @shared-single/runtime-deps2 > @shared-single/runtime-deps
747+
expect(sharedRes.from).toEqual('@shared-single/runtime-deps2');
747748
});
748749
});
749750

0 commit comments

Comments
 (0)