Do not use hard coded path separator and clean ups (#457)

Author: zakuru

dashboard-plugin/FederationDashboardPlugin.js

@@ -264,7 +264,6 @@ class FederationDashboardPlugin {
 
     if (graphData) {
       const dashData = (this._dashData = JSON.stringify(graphData));
-      this.writeStatsFiles(stats, dashData);
       if (this._options.dashboardURL && !this._options.nextjs) {
         this.postDashboardData(dashData).catch((err) => {
           if (err) {
@@ -475,74 +474,6 @@ class FederationDashboardPlugin {
     return Array.from(directReasons);
   }
 
-  // This is no longer needed - can be deleted or used for refactoring the asset emitter
-  writeStatsFiles(stats, dashData) {
-    if (this._options.filename) {
-      const hashPath = path.join(stats.outputPath, this._options.filename);
-      if (!fs.existsSync(stats.outputPath)) {
-        fs.mkdirSync(stats.outputPath);
-      }
-      fs.writeFile(hashPath, dashData, { encoding: "utf-8" }, () => {});
-    }
-    if (this._options.debug) {
-      console.log(
-        path.join(stats.outputPath, this.FederationPluginOptions.filename)
-      );
-    }
-    const file = fs.readFileSync(
-      path.join(stats.outputPath, this.FederationPluginOptions.filename)
-    );
-    const { version } = JSON.parse(dashData);
-    if (!version) {
-      throw new Error("no version provided, cannot version remote");
-    }
-    if (this._options.debug) {
-      console.log(
-        path.join(
-          stats.outputPath,
-          version,
-          this.FederationPluginOptions.filename
-        )
-      );
-    }
-    fs.mkdir(
-      path.join(stats.outputPath, version),
-      { recursive: true },
-      (err) => {
-        if (err) throw err;
-        fs.writeFile(
-          path.join(
-            stats.outputPath,
-            version,
-            this.FederationPluginOptions.filename
-          ),
-          file,
-          (err) => {
-            if (this._options.debug) {
-              console.trace(err);
-              console.log(
-                "wrote versioned remote",
-                path.join(
-                  stats.outputPath,
-                  version,
-                  this.FederationPluginOptions.filename
-                )
-              );
-            }
-          }
-        );
-      }
-    );
-
-    const statsPath = path.join(stats.outputPath, "stats.json");
-    fs.writeFile(
-      statsPath,
-      JSON.stringify(stats),
-      { encoding: "utf-8" },
-      () => {}
-    );
-  }
-
   async postDashboardData(dashData) {
     if (!this._options.dashboardURL) {
       return Promise.resolve();

dashboard-plugin/convertToGraph.js

@@ -96,13 +96,12 @@ const convertToGraph = (
       });
     } else if (nameForCondition && nameForCondition.includes("node_modules")) {
       const contextArray = nameForCondition.split(path.sep);
-      const afterModule = nameForCondition.split("node_modules/");
+      const afterModule = nameForCondition.split("node_modules" + path.sep);
 
       const search = afterModule[1] && afterModule[1].startsWith("@") ? 3 : 2;
       contextArray.splice(contextArray.indexOf("node_modules") + search);
 
       const context = contextArray.join(path.sep);
-      const npmModule = contextArray[contextArray.indexOf("node_modules") + 1];
 
       const packageJsonFile = path.join(context, "package.json");
       const packageJson = JSON.parse(fs.readFileSync(packageJsonFile, "UTF-8"));