Skip to content

Commit 431d2ac

Browse files
fix: use pnpm filter commands in Playwright webServer for CI compatibility
- Update webServer commands to use pnpm --filter instead of relative cd commands - Ensures commands work from any directory context (repo root in CI vs local directory) - Maintains environment-aware LEGACY_MODE support for webpack/rspack switching - All 13/13 tests still passing locally with updated configuration This resolves the CI directory context issue where Playwright webServer commands were failing due to relative path assumptions. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 6edea24 commit 431d2ac

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

advanced-api/dynamic-remotes/playwright.config.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,19 +31,19 @@ export default defineConfig({
3131

3232
webServer: [
3333
{
34-
command: `cd app1 && pnpm ${process.env.LEGACY_MODE ? 'legacy:start' : 'start'}`,
34+
command: `pnpm --filter dynamic-remotes_app1 ${process.env.LEGACY_MODE ? 'legacy:start' : 'start'}`,
3535
port: 3001,
3636
timeout: 120000,
3737
reuseExistingServer: !process.env.CI,
3838
},
3939
{
40-
command: `cd app2 && pnpm ${process.env.LEGACY_MODE ? 'legacy:start' : 'start'}`,
40+
command: `pnpm --filter dynamic-remotes_app2 ${process.env.LEGACY_MODE ? 'legacy:start' : 'start'}`,
4141
port: 3002,
4242
timeout: 120000,
4343
reuseExistingServer: !process.env.CI,
4444
},
4545
{
46-
command: `cd app3 && pnpm ${process.env.LEGACY_MODE ? 'legacy:start' : 'start'}`,
46+
command: `pnpm --filter dynamic-remotes_app3 ${process.env.LEGACY_MODE ? 'legacy:start' : 'start'}`,
4747
port: 3003,
4848
timeout: 120000,
4949
reuseExistingServer: !process.env.CI,

0 commit comments

Comments
 (0)