Skip to content

Commit 6cd92bb

Browse files
fix: update legacy:e2e:ci scripts to use Playwright webServer configuration
- Update all legacy:e2e:ci scripts to use simple 'npx playwright test' command - This prevents port conflicts in CI where legacy scripts were manually starting servers - The Playwright webServer configuration now handles all server management - Add missing legacy:e2e:ci script to dynamic-remotes-synchronous-imports This ensures CI tests run properly since the GitHub workflow uses legacy:e2e:ci for webpack tests. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 5d6beb6 commit 6cd92bb

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

advanced-api/automatic-vendor-sharing/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"legacy:start": "pnpm --filter automatic-vendor-sharing_app* --parallel legacy:start",
1616
"legacy:build": "pnpm --filter automatic-vendor-sharing_app* --parallel legacy:build",
1717
"e2e:ci": "npx playwright test",
18-
"legacy:e2e:ci": "pnpm legacy:start & wait-on http-get://localhost:3001/ http-get://localhost:3002/ && npx playwright test"
18+
"legacy:e2e:ci": "npx playwright test"
1919
},
2020
"devDependencies": {
2121
"@playwright/test": "^1.54.2",

advanced-api/dynamic-remotes-runtime-environment-variables/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"docker:run": "pnpm --filter dynamic-remotes-runtime-environment-variables_* --parallel docker:run",
1717
"docker:rm": "pnpm --filter dynamic-remotes-runtime-environment-variables_* --parallel docker:rm",
1818
"e2e:ci": "npx playwright test",
19-
"legacy:e2e:ci": "pnpm legacy:start & wait-on http-get://localhost:3000/ http-get://localhost:3001/ && npx playwright test"
19+
"legacy:e2e:ci": "npx playwright test"
2020
},
2121
"devDependencies": {
2222
"@playwright/test": "^1.54.2",

advanced-api/dynamic-remotes-synchronous-imports/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111
"build": "pnpm --filter dynamic-remotes-synchronous-imports_app* --parallel build",
1212
"serve": "pnpm --filter dynamic-remotes-synchronous-imports_app* --parallel serve",
1313
"clean": "pnpm --filter dynamic-remotes-synchronous-imports_app* --parallel clean",
14-
"e2e:ci": "npx playwright test"
14+
"e2e:ci": "npx playwright test",
15+
"legacy:e2e:ci": "npx playwright test"
1516
},
1617
"devDependencies": {
1718
"@playwright/test": "^1.54.2",

advanced-api/dynamic-remotes/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"test:e2e:ui": "npx playwright test --ui",
1919
"test:e2e:debug": "npx playwright test --debug",
2020
"e2e:ci": "npx playwright test --reporter=list",
21-
"legacy:e2e:ci": "pnpm legacy:start & sleep 5 && wait-on tcp:3001 tcp:3002 tcp:3003 && LEGACY_MODE=true npx playwright test --reporter=list; kill $(jobs -p) 2>/dev/null || true"
21+
"legacy:e2e:ci": "npx playwright test --reporter=list"
2222
},
2323
"devDependencies": {
2424
"@playwright/test": "^1.54.2",

0 commit comments

Comments
 (0)